ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE

This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c b/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c
index c84ce97f15acf963d34bfe62edd5cc568ff9f07c..2c6206be936828f12cfb2820f4e8d8ad3a2b8193 100644 (file)
--- a/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c
+++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c
@@ -69,9 +69,9 @@ BaseGetTotalProtocols (
 \r
 /** Common function which returns vendor details.\r
 \r
-  @param[in] MessageId       SCMI_MESSAGE_ID_BASE_DISCOVER_VENDOR\r
+  @param[in] MessageId       ScmiMessageIdBaseDiscoverVendor\r
                              OR\r
-                             SCMI_MESSAGE_ID_BASE_DISCOVER_SUB_VENDOR\r
+                             ScmiMessageIdBaseDiscoverSubVendor\r
 \r
   @param[out] VendorIdentifier ASCII name of the vendor/subvendor.\r
 \r
@@ -133,7 +133,7 @@ BaseDiscoverVendor (
   )\r
 {\r
   return BaseDiscoverVendorDetails (\r
-           SCMI_MESSAGE_ID_BASE_DISCOVER_VENDOR,\r
+           ScmiMessageIdBaseDiscoverVendor,\r
            VendorIdentifier\r
            );\r
 }\r
@@ -156,7 +156,7 @@ BaseDiscoverSubVendor (
   )\r
 {\r
   return BaseDiscoverVendorDetails (\r
-           SCMI_MESSAGE_ID_BASE_DISCOVER_SUB_VENDOR,\r
+           ScmiMessageIdBaseDiscoverSubVendor,\r
            VendorIdentifier\r
            );\r
 }\r
@@ -184,7 +184,7 @@ BaseDiscoverImplVersion (
   UINT32        PayloadLength;\r
 \r
   Cmd.ProtocolId = ScmiProtocolIdBase;\r
-  Cmd.MessageId  = SCMI_MESSAGE_ID_BASE_DISCOVER_IMPLEMENTATION_VERSION;\r
+  Cmd.MessageId  = ScmiMessageIdBaseDiscoverImplementationVersion;\r
 \r
   PayloadLength = 0;\r
 \r
@@ -251,7 +251,7 @@ BaseDiscoverListProtocols (
   }\r
 \r
   Cmd.ProtocolId = ScmiProtocolIdBase;\r
-  Cmd.MessageId  = SCMI_MESSAGE_ID_BASE_DISCOVER_LIST_PROTOCOLS;\r
+  Cmd.MessageId  = ScmiMessageIdBaseDiscoverListProtocols;\r
 \r
   Skip = 0;\r
 \r

diff --git a/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h b/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h
index 2f93ec92325e062f0ac35fdf4009129eb8dfc52a..73ad3e32a2f57da1bc4683ee3143501fe05501df 100644 (file)
--- a/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h
+++ b/ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h
@@ -1,6 +1,6 @@
 /** @file\r
 \r
-  Copyright (c) 2017-2018, Arm Limited. All rights reserved.\r
+  Copyright (c) 2017-2021, Arm Limited. All rights reserved.<BR>\r
 \r
   SPDX-License-Identifier: BSD-2-Clause-Patent\r
 \r
@@ -158,10 +158,10 @@ typedef struct _SCMI_BASE_PROTOCOL {
 \r
 // SCMI Message IDs for Base protocol.\r
 typedef enum {\r
-  SCMI_MESSAGE_ID_BASE_DISCOVER_VENDOR                  = 0x3,\r
-  SCMI_MESSAGE_ID_BASE_DISCOVER_SUB_VENDOR              = 0x4,\r
-  SCMI_MESSAGE_ID_BASE_DISCOVER_IMPLEMENTATION_VERSION  = 0x5,\r
-  SCMI_MESSAGE_ID_BASE_DISCOVER_LIST_PROTOCOLS          = 0x6\r
+  ScmiMessageIdBaseDiscoverVendor                 = 0x3,\r
+  ScmiMessageIdBaseDiscoverSubVendor              = 0x4,\r
+  ScmiMessageIdBaseDiscoverImplementationVersion  = 0x5,\r
+  ScmiMessageIdBaseDiscoverListProtocols          = 0x6\r
 } SCMI_MESSAGE_ID_BASE;\r
 \r
 #endif /* ARM_SCMI_BASE_PROTOCOL_H_ */\r