]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdeModulePkg/PlatformDriOverrideDxe: Fix overflow condition check
authorLi, Walon <walon.li@hpe.com>
Thu, 13 May 2021 02:48:40 +0000 (10:48 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fri, 21 May 2021 08:31:39 +0000 (08:31 +0000)
Code mistake, VariableIndex is smaller normally than buffer+buffersize
so should not break loop.

Signed-off-by: Walon Li <walon.li@hpe.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c

index f91f038b7ad605b76a7814ee96c9399bf791f708..bd2d04452f8bb87e7da2941fa146a39ea54d9bfa 100644 (file)
@@ -776,7 +776,7 @@ InitOverridesMapping (
         // Check buffer overflow\r
         //\r
         if ((DriverImageInfo->DriverImagePath == NULL) || (VariableIndex < (UINT8 *) DriverDevicePath) ||\r
-            (VariableIndex < (UINT8 *) VariableBuffer + BufferSize)) {\r
+            (VariableIndex > (UINT8 *) VariableBuffer + BufferSize)) {\r
           Corrupted = TRUE;\r
           break;\r
         }\r