Code Scrub:

MdeModulePkg\Universal\PcatRealTimeClockRuntimeDxe

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6468 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/MdeModulePkg/Universal/PcatRealTimeClockRuntimeDxe/PcRtc.c b/MdeModulePkg/Universal/PcatRealTimeClockRuntimeDxe/PcRtc.c
index 2cba83eef237468636450ef4d031a305cc7e87cd..7535cd538e18417dcf87987523fabd98496b5375 100644 (file)
--- a/MdeModulePkg/Universal/PcatRealTimeClockRuntimeDxe/PcRtc.c
+++ b/MdeModulePkg/Universal/PcatRealTimeClockRuntimeDxe/PcRtc.c
@@ -750,7 +750,7 @@ ConvertRtcTimeToEfiTime (
 {\r
   BOOLEAN IsPM;\r
 \r
-  if ((Time->Hour) & 0x80) {\r
+  if ((Time->Hour & 0x80) != 0) {\r
     IsPM = TRUE;\r
   } else {\r
     IsPM = FALSE;\r
@@ -863,7 +863,7 @@ RtcTimeFieldsValid (
       Time->Second > 59 ||\r
       Time->Nanosecond > 999999999 ||\r
       (!(Time->TimeZone == EFI_UNSPECIFIED_TIMEZONE || (Time->TimeZone >= -1440 && Time->TimeZone <= 1440))) ||\r
-      (Time->Daylight & (~(EFI_TIME_ADJUST_DAYLIGHT | EFI_TIME_IN_DAYLIGHT)))\r
+      ((Time->Daylight & (~(EFI_TIME_ADJUST_DAYLIGHT | EFI_TIME_IN_DAYLIGHT))) != 0)\r
       ) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r

diff --git a/MdeModulePkg/Universal/PcatRealTimeClockRuntimeDxe/PcRtc.h b/MdeModulePkg/Universal/PcatRealTimeClockRuntimeDxe/PcRtc.h
index 5a6fe762e3e9a327403cf41173a8dafffe11c4f3..7b6c1c10029c32327d5967ad4dc700875d3abd8f 100644 (file)
--- a/MdeModulePkg/Universal/PcatRealTimeClockRuntimeDxe/PcRtc.h
+++ b/MdeModulePkg/Universal/PcatRealTimeClockRuntimeDxe/PcRtc.h
@@ -157,8 +157,7 @@ typedef union {
 EFI_STATUS\r
 PcRtcInit (\r
   IN PC_RTC_MODULE_GLOBALS  *Global\r
-  )\r
-;\r
+  );\r
 \r
 /**\r
   Sets the current local time and date information.\r
@@ -175,8 +174,7 @@ EFI_STATUS
 PcRtcSetTime (\r
   IN EFI_TIME               *Time,\r
   IN PC_RTC_MODULE_GLOBALS  *Global\r
-  )\r
-;\r
+  );\r
 \r
 /**\r
   Returns the current time and date information, and the time-keeping capabilities\r
@@ -197,8 +195,7 @@ PcRtcGetTime (
   OUT EFI_TIME              *Time,\r
   OUT EFI_TIME_CAPABILITIES *Capabilities, OPTIONAL\r
   IN  PC_RTC_MODULE_GLOBALS *Global\r
-  )\r
-;\r
+  );\r
 \r
 /**\r
   Sets the system wakeup alarm clock time.\r
@@ -220,8 +217,7 @@ PcRtcSetWakeupTime (
   IN BOOLEAN                Enable,\r
   IN EFI_TIME               *Time,  OPTIONAL\r
   IN PC_RTC_MODULE_GLOBALS  *Global\r
-  )\r
-;\r
+  );\r
 \r
 /**\r
   Returns the current wakeup alarm clock setting.\r
@@ -245,8 +241,7 @@ PcRtcGetWakeupTime (
   OUT BOOLEAN               *Pending,\r
   OUT EFI_TIME              *Time,\r
   IN  PC_RTC_MODULE_GLOBALS *Global\r
-  )\r
-;\r
+  );\r
 \r
 /**\r
   The user Entry Point for PcRTC module.\r
@@ -266,8 +261,7 @@ EFIAPI
 InitializePcRtc (\r
   IN EFI_HANDLE                            ImageHandle,\r
   IN EFI_SYSTEM_TABLE                      *SystemTable\r
-  )\r
-;\r
+  );\r
 \r
 /**\r
   See if all fields of a variable of EFI_TIME type is correct.\r
@@ -281,8 +275,7 @@ InitializePcRtc (
 EFI_STATUS\r
 RtcTimeFieldsValid (\r
   IN EFI_TIME *Time\r
-  )\r
-;\r
+  );\r
 \r
 /**\r
   Converts time from EFI_TIME format defined by UEFI spec to RTC's.\r
@@ -302,8 +295,7 @@ ConvertEfiTimeToRtcTime (
   IN OUT EFI_TIME        *Time,\r
   IN     RTC_REGISTER_B  RegisterB,\r
   OUT    UINT8           *Century\r
-  )\r
-;\r
+  );\r
 \r
 /**\r
   See if centry register of RTC is valid.\r
@@ -314,8 +306,7 @@ ConvertEfiTimeToRtcTime (
 EFI_STATUS\r
 RtcTestCenturyRegister (\r
   VOID\r
-  )\r
-;\r
+  );\r
 \r
 /**\r
   Converts time read from RTC to EFI_TIME format defined by UEFI spec.\r
@@ -353,8 +344,7 @@ ConvertRtcTimeToEfiTime (
 EFI_STATUS\r
 RtcWaitToUpdate (\r
   UINTN Timeout\r
-  )\r
-;\r
+  );\r
 \r
 /**\r
   See if field Day of an EFI_TIME is correct.\r