code scrub on Ps2MouseDxe module

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8657 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c b/IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c
index 548386f8444f702df995669d393429165dda6efc..aa22b5cf3e1ad9cfd0571f1927e688b79416daae 100644 (file)
--- a/IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c
+++ b/IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c
@@ -1,7 +1,7 @@
 /** @file\r
   PS2 Mouse Communication Interface.\r
   \r
-Copyright (c) 2006 - 2007, Intel Corporation\r
+Copyright (c) 2006 - 2009, Intel Corporation\r
 All rights reserved. This program and the accompanying materials\r
 are licensed and made available under the terms and conditions of the BSD License\r
 which accompanies this distribution.  The full text of the license may be found at\r
@@ -892,23 +892,6 @@ WaitOutputFull (
   IN EFI_ISA_IO_PROTOCOL                  *IsaIo,\r
   IN UINTN                                Timeout\r
   )\r
-/**\r
-\r
-Routine Description:\r
-\r
-  GC_TODO: Add function description\r
-\r
-Arguments:\r
-\r
-  IsaIo   - GC_TODO: add argument description\r
-  Timeout - GC_TODO: add argument description\r
-\r
-Returns:\r
-\r
-  EFI_TIMEOUT - GC_TODO: Add description for return value\r
-  EFI_SUCCESS - GC_TODO: Add description for return value\r
-\r
-**/\r
 {\r
   UINTN Delay;\r
   UINT8 Data;\r

diff --git a/IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h b/IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h
index 8e2b58d44069a648eef120922cb533de77a9efd0..5eb55de13cc3570436ce251e29d88eb742a2b42b 100644 (file)
--- a/IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h
+++ b/IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h
@@ -75,32 +75,50 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 //\r
 // Keyboard Controller Status\r
 //\r
-#define KBC_PARE  0x80  // Parity Error\r
-#define KBC_TIM   0x40  // General Time Out\r
-#define KBC_AUXB  0x20  // Output buffer for auxiliary device (PS/2):\r
-//    0 - Holds keyboard data\r
-//    1 - Holds data for auxiliary device\r
-//\r
-#define KBC_KEYL  0x10  // Keyboard lock status:\r
-//    0 - keyboard locked\r
-//    1 - keyboard free\r
-//\r
-#define KBC_CD  0x08  // Command/Data:\r
-//    0 - data byte written via port 60h\r
-//    1 - command byte written via port 64h\r
-//\r
-#define KBC_SYSF  0x04  // System Flag:\r
-//    0 - power-on reset\r
-//    1 - self-test successful\r
-//\r
-#define KBC_INPB  0x02  // Input Buffer Status :\r
-//    0 - input buffer empty\r
-//    1 - CPU data in input buffer\r
-//\r
-#define KBC_OUTB  0x01  // Output Buffer Status :\r
-//    0 - output buffer empty\r
-//    1 - keyboard controller data in output buffer\r
-//\r
+///\r
+/// Parity Error\r
+///\r
+#define KBC_PARE  0x80  \r
+///\r
+/// General Time Out\r
+///\r
+#define KBC_TIM   0x40  \r
+///\r
+/// Output buffer for auxiliary device (PS/2):\r
+///    0 - Holds keyboard data\r
+///    1 - Holds data for auxiliary device\r
+///\r
+#define KBC_AUXB  0x20  \r
+///\r
+/// Keyboard lock status:\r
+///    0 - keyboard locked\r
+///    1 - keyboard free\r
+///\r
+#define KBC_KEYL  0x10 \r
+///\r
+/// Command/Data:\r
+///    0 - data byte written via port 60h\r
+///    1 - command byte written via port 64h\r
+///\r
+#define KBC_CD  0x08\r
+///\r
+/// System Flag:\r
+///    0 - power-on reset\r
+///    1 - self-test successful\r
+///\r
+#define KBC_SYSF  0x04  \r
+///\r
+/// Input Buffer Status :\r
+///    0 - input buffer empty\r
+///    1 - CPU data in input buffer\r
+///\r
+#define KBC_INPB  0x02  \r
+///\r
+/// Output Buffer Status :\r
+///    0 - output buffer empty\r
+///    1 - keyboard controller data in output buffer\r
+///\r
+#define KBC_OUTB  0x01  \r
 \r
 /**\r
   Issue self test command via IsaIo interface.\r
@@ -413,4 +431,5 @@ WaitOutputFull (
   IN UINTN                                Timeout\r
   );\r
 \r
-#endif // _COMMPS2_H_\r
+#endif\r
+\r

diff --git a/IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c b/IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c
index 2bd8231494dc4379850029cf70a41c22b65c2caf..13c4c206901a946ccbc2b8bf28e15217fe76e017 100644 (file)
--- a/IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c
+++ b/IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.c
@@ -1,8 +1,8 @@
 /** @file\r
   PS/2 Mouse driver. Routines that interacts with callers,\r
-  conforming to EFI driver model\r
+  conforming to EFI driver model.\r
   \r
-Copyright (c) 2006 - 2007, Intel Corporation\r
+Copyright (c) 2006 - 2009, Intel Corporation\r
 All rights reserved. This program and the accompanying materials\r
 are licensed and made available under the terms and conditions of the BSD License\r
 which accompanies this distribution.  The full text of the license may be found at\r
@@ -16,9 +16,9 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include "Ps2Mouse.h"\r
 #include "CommPs2.h"\r
 \r
-//\r
-// DriverBinding Protocol Instance\r
-//\r
+///\r
+/// DriverBinding Protocol Instance\r
+///\r
 EFI_DRIVER_BINDING_PROTOCOL gPS2MouseDriver = {\r
   PS2MouseDriverSupported,\r
   PS2MouseDriverStart,\r
@@ -109,9 +109,9 @@ PS2MouseDriverSupported (
 }\r
 \r
 /**\r
-  Start this driver on ControllerHandle by opening a IsaIo\r
-  protocol, creating PS2_MOUSE_ABSOLUTE_POINTER_DEV device and install gEfiAbsolutePointerProtocolGuid\r
-  finnally.\r
+  Start this driver on ControllerHandle by opening a IsaIo protocol, creating \r
+  PS2_MOUSE_ABSOLUTE_POINTER_DEV device and install gEfiAbsolutePointerProtocolGuid\r
+  finally.\r
 \r
   @param  This                 Protocol instance pointer.\r
   @param  ControllerHandle     Handle of device to bind driver to\r
@@ -377,7 +377,7 @@ ErrorExit:
   }\r
 \r
   if (MouseDev != NULL) {\r
-    gBS->FreePool (MouseDev);\r
+    FreePool (MouseDev);\r
   }\r
 \r
   gBS->CloseProtocol (\r
@@ -480,7 +480,7 @@ PS2MouseDriverStop (
 \r
   gBS->CloseEvent (MouseDev->SimplePointerProtocol.WaitForInput);\r
   FreeUnicodeStringTable (MouseDev->ControllerNameTable);\r
-  gBS->FreePool (MouseDev);\r
+  FreePool (MouseDev);\r
 \r
   gBS->CloseProtocol (\r
          Controller,\r