]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdeModulePkg XhciDxe: Remove redundant functions
authorshenglei <shenglei.zhang@intel.com>
Wed, 8 Aug 2018 05:53:35 +0000 (13:53 +0800)
committerStar Zeng <star.zeng@intel.com>
Tue, 21 Aug 2018 08:28:59 +0000 (16:28 +0800)
The functions that are never called have been removed.
They are XhcReadDoorBellReg and XhcWriteOpReg16.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062

Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.h

index 4d5937de538f8b907c44ec5ecf1a002a44ef3cfc..5f0736a516b6e4f0d23b7ec02ed1dcbdd6b0aefd 100644 (file)
@@ -158,75 +158,9 @@ XhcWriteOpReg (
   }\r
 }\r
 \r
-/**\r
-  Write the data to the 2-bytes width XHCI operational register.\r
 \r
-  @param  Xhc          The XHCI Instance.\r
-  @param  Offset       The offset of the 2-bytes width operational register.\r
-  @param  Data         The data to write.\r
 \r
-**/\r
-VOID\r
-XhcWriteOpReg16 (\r
-  IN USB_XHCI_INSTANCE    *Xhc,\r
-  IN UINT32               Offset,\r
-  IN UINT16               Data\r
-  )\r
-{\r
-  EFI_STATUS              Status;\r
-\r
-  ASSERT (Xhc->CapLength != 0);\r
-\r
-  Status = Xhc->PciIo->Mem.Write (\r
-                             Xhc->PciIo,\r
-                             EfiPciIoWidthUint16,\r
-                             XHC_BAR_INDEX,\r
-                             Xhc->CapLength + Offset,\r
-                             1,\r
-                             &Data\r
-                             );\r
-\r
-  if (EFI_ERROR (Status)) {\r
-    DEBUG ((EFI_D_ERROR, "XhcWriteOpReg16: Pci Io Write error: %r at %d\n", Status, Offset));\r
-  }\r
-}\r
-\r
-/**\r
-  Read XHCI door bell register.\r
-\r
-  @param  Xhc          The XHCI Instance.\r
-  @param  Offset       The offset of the door bell register.\r
 \r
-  @return The register content read\r
-\r
-**/\r
-UINT32\r
-XhcReadDoorBellReg (\r
-  IN  USB_XHCI_INSTANCE   *Xhc,\r
-  IN  UINT32              Offset\r
-  )\r
-{\r
-  UINT32                  Data;\r
-  EFI_STATUS              Status;\r
-\r
-  ASSERT (Xhc->DBOff != 0);\r
-\r
-  Status = Xhc->PciIo->Mem.Read (\r
-                             Xhc->PciIo,\r
-                             EfiPciIoWidthUint32,\r
-                             XHC_BAR_INDEX,\r
-                             Xhc->DBOff + Offset,\r
-                             1,\r
-                             &Data\r
-                             );\r
-\r
-  if (EFI_ERROR (Status)) {\r
-    DEBUG ((EFI_D_ERROR, "XhcReadDoorBellReg: Pci Io Read error - %r at %d\n", Status, Offset));\r
-    Data = 0xFFFFFFFF;\r
-  }\r
-\r
-  return Data;\r
-}\r
 \r
 /**\r
   Write the data to the XHCI door bell register.\r
index 838a44628c2790fa4b468313241b893025470500..20e7ac0e8f02ae43661b8518286557f0988ab9fa 100644 (file)
@@ -286,20 +286,6 @@ XhcWriteOpReg (
   IN UINT32               Data\r
   );\r
 \r
-/**\r
-  Write the data to the 2-bytes width XHCI operational register.\r
-\r
-  @param  Xhc          The XHCI Instance.\r
-  @param  Offset       The offset of the 2-bytes width operational register.\r
-  @param  Data         The data to write.\r
-\r
-**/\r
-VOID\r
-XhcWriteOpReg16 (\r
-  IN USB_XHCI_INSTANCE    *Xhc,\r
-  IN UINT32               Offset,\r
-  IN UINT16               Data\r
-  );\r
 \r
 /**\r
   Read XHCI runtime register.\r
@@ -331,20 +317,6 @@ XhcWriteRuntimeReg (
   IN UINT32               Data\r
   );\r
 \r
-/**\r
-  Read XHCI door bell register.\r
-\r
-  @param  Xhc          The XHCI Instance.\r
-  @param  Offset       The offset of the door bell register.\r
-\r
-  @return The register content read\r
-\r
-**/\r
-UINT32\r
-XhcReadDoorBellReg (\r
-  IN  USB_XHCI_INSTANCE   *Xhc,\r
-  IN  UINT32              Offset\r
-  );\r
 \r
 /**\r
   Write the data to the XHCI door bell register.\r