]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdePkg/Ftp4: Fix wrong function pointer declaration
authorAlcantara, Paulo <paulo.alc.cavalcanti@hp.com>
Tue, 6 Jun 2017 00:33:36 +0000 (08:33 +0800)
committerFu Siyuan <siyuan.fu@intel.com>
Wed, 2 Aug 2017 08:21:45 +0000 (16:21 +0800)
EFI_FTP4_DATA_CALLBACK is a function pointer and defined as follows:

> typedef
> EFI_STATUS
> (EFIAPI *EFI_FTP4_DATA_CALLBACK)(
>  IN EFI_FTP4_PROTOCOL           *This,
>  IN EFI_FTP4_COMMAND_TOKEN      *Token
>  );

And EFI_FTP4_COMMAND_TOKEN structure declared it as:

> EFI_FTP4_DATA_CALLBACK *DataCallback

Which ended up being a pointer to function pointer and clearly wrong.
This patch fixes it by removing the misleading '*' from declaration.
It's also fixed in new UEFI 2.7 spec.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Paulo Alcantara <paulo.alc.cavalcanti@hp.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
MdePkg/Include/Protocol/Ftp4.h

index 1c4a5db92587327c09971987cda925a56e9ead23..536b3f36352598f07cb3b0288873c3e58a6ee663 100644 (file)
@@ -204,7 +204,7 @@ struct _EFI_FTP4_COMMAND_TOKEN {
   /// DataBufferSize, again. If there is no data remained, \r
   /// DataBufferSize should be set to 0.\r
   /// \r
-  EFI_FTP4_DATA_CALLBACK                *DataCallback;\r
+  EFI_FTP4_DATA_CALLBACK                DataCallback;\r
   /// \r
   /// Pointer to the parameter for DataCallback.\r
   /// \r