ArmPkg/MmCommunicationDxe: fix logic bug in DXE driver entrypoint
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Wed, 26 Feb 2020 12:06:31 +0000 (13:06 +0100)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Wed, 4 Mar 2020 17:42:43 +0000 (17:42 +0000)
Commit 2fe25a74d6fee3c2 ("ArmPkg/MmCommunicationDxe: relay architected PI
events to MM context") update the ARM specific standalone MM client
driver to register for certain events in the entrypoint code, but did
so in a way that makes the entrypoint always return with an error.

Instead, return EFI_SUCCESS if registering for those events succeeds,
and back out the registrations that did succeed if one fails, and
return an error.

Fixes: 2fe25a74d6fee3c2 ("ArmPkg/MmCommunicationDxe: relay architected PI events to MM context")
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c

index 5f52afa..a9e06be 100644 (file)
@@ -390,8 +390,16 @@ MmCommunicationInitialize (
                     MmGuidedEventNotify, mGuidedEventGuid[Index],\r
                     mGuidedEventGuid[Index], &mGuidedEvent[Index]);\r
     ASSERT_EFI_ERROR (Status);\r
+    if (EFI_ERROR (Status)) {\r
+      while (Index-- > 0) {\r
+        gBS->CloseEvent (mGuidedEvent[Index]);\r
+      }\r
+      goto UninstallProtocol;\r
+    }\r
   }\r
+  return EFI_SUCCESS;\r
 \r
+UninstallProtocol:\r
   gBS->UninstallProtocolInterface (\r
          mMmCommunicateHandle,\r
          &gEfiMmCommunicationProtocolGuid,\r