MdeModulePkg VarCheckHii: Make sure the bin at required alignment

According to UEFI/PI spec, the AllocateXXXPool() interfaces should
return eight-byte aligned buffer that satisfies the required
HEADER_ALIGNMENT which is 4.

This patch adds ASSERT to make sure the bin at required alignment,
that can help catch the issue earlier about incorrect aligned buffer
returned from AllocateXXXPool().

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

diff --git a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGen.c b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGen.c
index c0efed450bfbf861da9d2fa61d925e0154c75ea9..0db1383491f75318f988831e197da9ad6f303e4d 100644 (file)
--- a/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGen.c
+++ b/MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGen.c
@@ -1518,6 +1518,10 @@ BuildVarCheckHiiBin (
   //\r
   Data = AllocateRuntimeZeroPool (BinSize);\r
   ASSERT (Data != NULL);\r
+  //\r
+  // Make sure the allocated buffer for VarCheckHiiBin at required alignment.\r
+  //\r
+  ASSERT ((((UINTN) Data) & (HEADER_ALIGNMENT - 1)) == 0);\r
   DEBUG ((DEBUG_INFO, "VarCheckHiiBin - built at 0x%x\n", Data));\r
 \r
   //\r