EmulatorPkg/(Pei|Dxe)EmuSerialPortLib: Remove the SerialPortExtLib functions from...

SerialPortSetControl, SerialPortGetControl and SerialPortSetAttributes are functions
of the SerialPortExtLib library interface. They should not be implemented by the
SerialPortLib library.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <Olivier.martin@arm.com>
Reviewed-by: Andrew Fish <afish@apple.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14357 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.c b/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.c
index 2efb8400faba7006c709cc58a8403ba3b9bd7130..792bd62a1c67f038d7be89e5c759046e677941c8 100644 (file)
--- a/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.c
+++ b/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.c
@@ -17,7 +17,6 @@
 \r
 #include <PiDxe.h>\r
 #include <Library/SerialPortLib.h>\r
-#include <Library/SerialPortExtLib.h>\r
 #include <Library/EmuThunkLib.h>\r
 \r
 \r
@@ -117,57 +116,3 @@ SerialPortPoll (
   return gEmuThunk->PollStdIn ();\r
 }\r
 \r
-/**\r
-  Set the serial device control bits.\r
-\r
-  @return    Always return EFI_UNSUPPORTED.\r
-\r
-**/\r
-RETURN_STATUS\r
-EFIAPI\r
-SerialPortSetControl (\r
-  IN UINT32                   Control\r
-  )\r
-{\r
-  return RETURN_SUCCESS;\r
-}\r
-\r
-/**\r
-  Get the serial device control bits.\r
-\r
-  @param  Control                 Control signals read from the serial device.\r
-\r
-  @retval EFI_SUCCESS             The control bits were read from the serial device.\r
-  @retval EFI_DEVICE_ERROR        The serial device is not functioning correctly.\r
-\r
-**/\r
-RETURN_STATUS\r
-EFIAPI\r
-SerialPortGetControl (\r
-  OUT UINT32                  *Control\r
-  )\r
-{\r
-  return RETURN_SUCCESS;\r
-}\r
-\r
-\r
-/**\r
-  Set the serial device attributes.\r
-\r
-  @return    Always return EFI_UNSUPPORTED.\r
-\r
-**/\r
-RETURN_STATUS\r
-EFIAPI\r
-SerialPortSetAttributes (\r
-  IN UINT64              BaudRate,\r
-  IN UINT32              ReceiveFifoDepth,\r
-  IN UINT32              Timeout,\r
-  IN EFI_PARITY_TYPE     Parity,\r
-  IN UINT8               DataBits,\r
-  IN EFI_STOP_BITS_TYPE  StopBits\r
-  )\r
-{\r
-  return RETURN_SUCCESS;\r
-}\r
-\r

diff --git a/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.c b/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.c
index 3b74a0c325c6685f130f0a193492b7ba8ec03d25..b3a20a981173318b6df3927ff25002131165abe7 100644 (file)
--- a/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.c
+++ b/EmulatorPkg/Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.c
@@ -18,7 +18,6 @@
 \r
 #include <PiPei.h>\r
 #include <Library/SerialPortLib.h>\r
-#include <Library/SerialPortExtLib.h>\r
 #include <Library/PeiServicesLib.h>\r
 \r
 #include <Ppi/EmuThunk.h>\r
@@ -138,58 +137,3 @@ SerialPortPoll (
   return FALSE;\r
 }\r
 \r
-/**\r
-  Set the serial device control bits.\r
-\r
-  @return    Always return EFI_UNSUPPORTED.\r
-\r
-**/\r
-RETURN_STATUS\r
-EFIAPI\r
-SerialPortSetControl (\r
-  IN UINT32                   Control\r
-  )\r
-{\r
-  return RETURN_SUCCESS;\r
-}\r
-\r
-/**\r
-  Get the serial device control bits.\r
-\r
-  @param  Control                 Control signals read from the serial device.\r
-\r
-  @retval EFI_SUCCESS             The control bits were read from the serial device.\r
-  @retval EFI_DEVICE_ERROR        The serial device is not functioning correctly.\r
-\r
-**/\r
-RETURN_STATUS\r
-EFIAPI\r
-SerialPortGetControl (\r
-  OUT UINT32                  *Control\r
-  )\r
-{\r
-  return RETURN_SUCCESS;\r
-}\r
-\r
-\r
-/**\r
-  Set the serial device attributes.\r
-\r
-  @return    Always return EFI_UNSUPPORTED.\r
-\r
-**/\r
-RETURN_STATUS\r
-EFIAPI\r
-SerialPortSetAttributes (\r
-  IN UINT64              BaudRate,\r
-  IN UINT32              ReceiveFifoDepth,\r
-  IN UINT32              Timeout,\r
-  IN EFI_PARITY_TYPE     Parity,\r
-  IN UINT8               DataBits,\r
-  IN EFI_STOP_BITS_TYPE  StopBits\r
-  )\r
-{\r
-  return RETURN_SUCCESS;\r
-}\r
-\r
-\r