MdeModulePkg/PciBusDxe: Fix possible uninitialized use

If the function gets invalid value for the `ResizableBarOp` parameter
and asserts are disabled, `Bit` can be used uninitialized.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Sergei Dmitrouk <sergei@posteo.net>
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
index 6bba2836716520f8f1f55d30b08cff9f002d1030..4caac56f1dcd8c2a7b73bd008fe118c4d1aa6942 100644 (file)
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
@@ -1778,10 +1778,9 @@ PciProgramResizableBar (
 \r
     if (ResizableBarOp == PciResizableBarMax) {\r
       Bit = HighBitSet64(Capabilities);\r
-    } else if (ResizableBarOp == PciResizableBarMin) {\r
-      Bit = LowBitSet64(Capabilities);\r
     } else {\r
-      ASSERT ((ResizableBarOp == PciResizableBarMax) || (ResizableBarOp == PciResizableBarMin));\r
+      ASSERT (ResizableBarOp == PciResizableBarMin);\r
+      Bit = LowBitSet64(Capabilities);\r
     }\r
 \r
     ASSERT (Bit >= 0);\r