]> git.proxmox.com Git - mirror_edk2.git/commitdiff
ShellPkg: Fix memory leak in function'ShellCommandRunHelp'.
authorYao Jiewen <Jiewen.Yao@intel.com>
Fri, 25 Dec 2015 01:33:53 +0000 (01:33 +0000)
committershenshushi <shenshushi@Edk2>
Fri, 25 Dec 2015 01:33:53 +0000 (01:33 +0000)
When run help command Shell may have memory leak. This patch fix this bug.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yao Jiewen <Jiewen.Yao@intel.com>
Reviewed-by: Qiu Shumin <shumin.qiu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19526 6f19259b-4bc3-4df7-8a09-765794883524

ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c

index c8d0e7887cffa874f30933f26227cffbda1143e6..619cdd38a71117a1b8e882e690eae0422c7aabb6 100644 (file)
@@ -311,6 +311,7 @@ ShellCommandRunHelp (
   ShellStatus         = SHELL_SUCCESS;\r
   CommandToGetHelpOn  = NULL;\r
   SectionToGetHelpOn  = NULL;\r
+  SortedCommandList   = NULL;\r
   Found               = FALSE;\r
 \r
   //\r
@@ -471,6 +472,7 @@ ShellCommandRunHelp (
   if (SectionToGetHelpOn != NULL) {\r
     FreePool(SectionToGetHelpOn);\r
   }\r
+  SHELL_FREE_NON_NULL(SortedCommandList);\r
 \r
   return (ShellStatus);\r
 }\r