]> git.proxmox.com Git - mirror_edk2.git/commitdiff
remove klocwork issue.
authorvanjeff <vanjeff@6f19259b-4bc3-4df7-8a09-765794883524>
Thu, 22 Jan 2009 09:07:53 +0000 (09:07 +0000)
committervanjeff <vanjeff@6f19259b-4bc3-4df7-8a09-765794883524>
Thu, 22 Jan 2009 09:07:53 +0000 (09:07 +0000)
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7346 6f19259b-4bc3-4df7-8a09-765794883524

MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c

index bdcc19e41a416fb010a4ec10c5e9457930d0dbf0..45f447b52fa993d2e6a53410b340ef4966001844 100644 (file)
@@ -535,29 +535,28 @@ Error:
     //\r
     if (Private->GraphicsOutput != NULL) {\r
       gBS->CloseProtocol (\r
-            Controller,\r
-            &gEfiGraphicsOutputProtocolGuid,\r
-            This->DriverBindingHandle,\r
-            Controller\r
-            );\r
+             Controller,\r
+             &gEfiGraphicsOutputProtocolGuid,\r
+             This->DriverBindingHandle,\r
+             Controller\r
+             );\r
     } else if (FeaturePcdGet (PcdUgaConsumeSupport)) {\r
       gBS->CloseProtocol (\r
-            Controller,\r
-            &gEfiUgaDrawProtocolGuid,\r
-            This->DriverBindingHandle,\r
-            Controller\r
-            );\r
+             Controller,\r
+             &gEfiUgaDrawProtocolGuid,\r
+             This->DriverBindingHandle,\r
+             Controller\r
+             );\r
+    }\r
+\r
+    if (Private->LineBuffer != NULL) {\r
+      FreePool (Private->LineBuffer);\r
     }\r
 \r
     //\r
     // Free private data\r
     //\r
-    if (Private != NULL) {\r
-      if (Private->LineBuffer != NULL) {\r
-        FreePool (Private->LineBuffer);\r
-      }\r
-      FreePool (Private);\r
-    }\r
+    FreePool (Private);\r
   }\r
 \r
   return Status;\r
@@ -642,13 +641,14 @@ GraphicsConsoleControllerDriverStop (
       mFirstAccessFlag = TRUE;\r
     }\r
 \r
+    if (Private->LineBuffer != NULL) {\r
+      FreePool (Private->LineBuffer);\r
+    }\r
+\r
     //\r
     // Free our instance data\r
     //\r
-    if (Private != NULL) {\r
-      FreePool (Private->LineBuffer);\r
-      FreePool (Private);\r
-    }\r
+    FreePool (Private);\r
   }\r
 \r
   return Status;\r