These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.
Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=165
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # RVCT
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
UINTN GicRevision;\r
EFI_STATUS Status;\r
UINT64 DistBase, CpuBase, RedistBase;\r
UINTN GicRevision;\r
EFI_STATUS Status;\r
UINT64 DistBase, CpuBase, RedistBase;\r
+ RETURN_STATUS PcdStatus;\r
\r
Status = gBS->LocateProtocol (&gFdtClientProtocolGuid, NULL,\r
(VOID **)&FdtClient);\r
\r
Status = gBS->LocateProtocol (&gFdtClientProtocolGuid, NULL,\r
(VOID **)&FdtClient);\r
RedistBase = SwapBytes64 (Reg[2]);\r
ASSERT (RedistBase < MAX_UINTN);\r
\r
RedistBase = SwapBytes64 (Reg[2]);\r
ASSERT (RedistBase < MAX_UINTN);\r
\r
- PcdSet64 (PcdGicDistributorBase, DistBase);\r
- PcdSet64 (PcdGicRedistributorsBase, RedistBase);\r
+ PcdStatus = PcdSet64S (PcdGicDistributorBase, DistBase);\r
+ ASSERT_RETURN_ERROR (PcdStatus);\r
+ PcdStatus = PcdSet64S (PcdGicRedistributorsBase, RedistBase);\r
+ ASSERT_RETURN_ERROR (PcdStatus);\r
\r
DEBUG ((EFI_D_INFO, "Found GIC v3 (re)distributor @ 0x%Lx (0x%Lx)\n",\r
DistBase, RedistBase));\r
\r
DEBUG ((EFI_D_INFO, "Found GIC v3 (re)distributor @ 0x%Lx (0x%Lx)\n",\r
DistBase, RedistBase));\r
ASSERT (DistBase < MAX_UINTN);\r
ASSERT (CpuBase < MAX_UINTN);\r
\r
ASSERT (DistBase < MAX_UINTN);\r
ASSERT (CpuBase < MAX_UINTN);\r
\r
- PcdSet64 (PcdGicDistributorBase, DistBase);\r
- PcdSet64 (PcdGicInterruptInterfaceBase, CpuBase);\r
+ PcdStatus = PcdSet64S (PcdGicDistributorBase, DistBase);\r
+ ASSERT_RETURN_ERROR (PcdStatus);\r
+ PcdStatus = PcdSet64S (PcdGicInterruptInterfaceBase, CpuBase);\r
+ ASSERT_RETURN_ERROR (PcdStatus);\r
\r
DEBUG ((EFI_D_INFO, "Found GIC @ 0x%Lx/0x%Lx\n", DistBase, CpuBase));\r
\r
\r
DEBUG ((EFI_D_INFO, "Found GIC @ 0x%Lx/0x%Lx\n", DistBase, CpuBase));\r
\r