]> git.proxmox.com Git - mirror_edk2.git/commitdiff
BaseTools: Correct if condition expression for DatumType == 'VOID*'
authorYonghong Zhu <yonghong.zhu@intel.com>
Wed, 24 May 2017 08:16:07 +0000 (16:16 +0800)
committerYonghong Zhu <yonghong.zhu@intel.com>
Thu, 25 May 2017 03:16:39 +0000 (11:16 +0800)
Correct the if condition expression for DatumType == 'VOID*'. Current
this condition is not work since the DatumType is changed before we do
the value judgement.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
BaseTools/Source/Python/AutoGen/GenC.py

index ae191d8c13cd06b94e0fc5994660d1771b8f21b5..67aaef70a1b3f3767672527943a6ec874cadb548 100644 (file)
@@ -1226,7 +1226,7 @@ def CreateLibraryPcdCode(Info, AutoGenC, AutoGenH, Pcd):
         AutoGenH.Append('//#define %s  ASSERT(FALSE)  // It is not allowed to set value for a FIXED_AT_BUILD PCD\n' % SetModeName)\r
         \r
         if PcdItemType == TAB_PCDS_FIXED_AT_BUILD and (key in Info.ConstPcd or (Info.IsLibrary and not Info._ReferenceModules)):\r
-            if DatumType == 'VOID*':\r
+            if  Pcd.DatumType == 'VOID*':\r
                 AutoGenH.Append('#define _PCD_VALUE_%s %s%s\n' %(TokenCName, Type, PcdVariableName))\r
             else:\r
                 AutoGenH.Append('#define _PCD_VALUE_%s %s\n' %(TokenCName, Pcd.DefaultValue))\r