MdeModulePkg RamDiskDxe: Remove unnecessary TPL raise operations

There is no asynchronous operations to the registered RAM disks link list
maintained within RamDiskDxe driver, therefore, the TPL raise and restore
operations when dealing with the link list are unnecessary.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>

diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c
index d4317019a5ad2ab87d5f463dee697b56254a0f1d..9df9b5b9654216b6f64eab6bb712c1ecebd9bff0 100644 (file)
--- a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c
+++ b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c
@@ -521,7 +521,6 @@ UpdateMainForm (
   CHAR16                    *String;\r
   CHAR16                    RamDiskStr[128];\r
   EFI_STRING_ID             StringId;\r
-  EFI_TPL                   OldTpl;\r
 \r
   //\r
   // Init OpCode Handle\r
@@ -557,7 +556,6 @@ UpdateMainForm (
   EndLabel->Number       = MAIN_LABEL_LIST_END;\r
 \r
   Index = 0;\r
-  OldTpl = gBS->RaiseTPL (TPL_NOTIFY);\r
   EFI_LIST_FOR_EACH (Entry, &RegisteredRamDisks) {\r
     PrivateData = RAM_DISK_PRIVATE_FROM_THIS (Entry);\r
     String      = RamDiskStr;\r
@@ -588,7 +586,6 @@ UpdateMainForm (
 \r
     Index++;\r
   }\r
-  gBS->RestoreTPL (OldTpl);\r
 \r
   HiiUpdateForm (\r
     ConfigPrivate->HiiHandle,\r
@@ -645,7 +642,6 @@ RamDiskCallback (
   EFI_FILE_HANDLE                 FileHandle;\r
   LIST_ENTRY                      *Entry;\r
   LIST_ENTRY                      *NextEntry;\r
-  EFI_TPL                         OldTpl;\r
 \r
   if ((This == NULL) || (Value == NULL) || (ActionRequest == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -747,7 +743,6 @@ RamDiskCallback (
       // Remove the selected RAM disks\r
       //\r
       Index = 0;\r
-      OldTpl = gBS->RaiseTPL (TPL_NOTIFY);\r
       EFI_LIST_FOR_EACH_SAFE (Entry, NextEntry, &RegisteredRamDisks) {\r
         if (Configuration->RamDiskList[Index++] != 0) {\r
           PrivateData = RAM_DISK_PRIVATE_FROM_THIS (Entry);\r
@@ -757,7 +752,6 @@ RamDiskCallback (
             );\r
         }\r
       }\r
-      gBS->RestoreTPL (OldTpl);\r
 \r
       UpdateMainForm (ConfigPrivate);\r
 \r

diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c
index 6d97994b5c4e74bb22dfb1d023a63f663314a9f4..0c1df9dc73395e6e6240e617d69cb52529183e6d 100644 (file)
--- a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c
+++ b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c
@@ -103,7 +103,6 @@ RamDiskRegister (
   MEDIA_RAM_DISK_DEVICE_PATH      *RamDiskDevNode;\r
   UINTN                           DevicePathSize;\r
   LIST_ENTRY                      *Entry;\r
-  EFI_TPL                         OldTpl;\r
 \r
   if ((0 == RamDiskSize) || (NULL == RamDiskType) || (NULL == DevicePath)) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -163,7 +162,6 @@ RamDiskRegister (
   // Check whether the created device path is already present in the handle\r
   // database\r
   //\r
-  OldTpl = gBS->RaiseTPL (TPL_NOTIFY);\r
   if (!IsListEmpty(&RegisteredRamDisks)) {\r
     DevicePathSize = GetDevicePathSize (PrivateData->DevicePath);\r
 \r
@@ -184,7 +182,6 @@ RamDiskRegister (
       }\r
     }\r
   }\r
-  gBS->RestoreTPL (OldTpl);\r
 \r
   //\r
   // Fill Block IO protocol informations for the RAM disk\r
@@ -212,10 +209,8 @@ RamDiskRegister (
   //\r
   // Insert the newly created one to the registered RAM disk list\r
   //\r
-  OldTpl = gBS->RaiseTPL (TPL_NOTIFY);\r
   InsertTailList (&RegisteredRamDisks, &PrivateData->ThisInstance);\r
   ListEntryNum++;\r
-  gBS->RestoreTPL (OldTpl);\r
 \r
   gBS->ConnectController (PrivateData->Handle, NULL, NULL, TRUE);\r
 \r
@@ -269,7 +264,6 @@ RamDiskUnregister (
   EFI_DEVICE_PATH_PROTOCOL        *Header;\r
   MEDIA_RAM_DISK_DEVICE_PATH      *RamDiskDevNode;\r
   RAM_DISK_PRIVATE_DATA           *PrivateData;\r
-  EFI_TPL                         OldTpl;\r
 \r
   if (NULL == DevicePath) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -302,7 +296,6 @@ RamDiskUnregister (
   StartingAddr   = ReadUnaligned64 ((UINT64 *) &(RamDiskDevNode->StartingAddr[0]));\r
   EndingAddr     = ReadUnaligned64 ((UINT64 *) &(RamDiskDevNode->EndingAddr[0]));\r
 \r
-  OldTpl = gBS->RaiseTPL (TPL_NOTIFY);\r
   if (!IsListEmpty(&RegisteredRamDisks)) {\r
     EFI_LIST_FOR_EACH_SAFE (Entry, NextEntry, &RegisteredRamDisks) {\r
       PrivateData = RAM_DISK_PRIVATE_FROM_THIS (Entry);\r
@@ -348,7 +341,6 @@ RamDiskUnregister (
       }\r
     }\r
   }\r
-  gBS->RestoreTPL (OldTpl);\r
 \r
   if (TRUE == Found) {\r
     return EFI_SUCCESS;\r