]> git.proxmox.com Git - mirror_edk2.git/commitdiff
Revert "TerminalDxe: select the UART's default receive FIFO depth"
authorRuiyu Ni <ruiyu.ni@intel.com>
Tue, 29 Mar 2016 07:30:37 +0000 (15:30 +0800)
committerRuiyu Ni <ruiyu.ni@intel.com>
Fri, 1 Apr 2016 01:18:23 +0000 (09:18 +0800)
This reverts commit 31ae446b1a039a55d0336f2201d77d1032533413.
Changing the receive FIFO depth in Terminal driver Start() is not
recommended.
A new PCD PcdUartDefaultReceiveFifoDepth was added and
MdeModulePkg/SerialDxe driver uses the PCD as the default receive
FIFO depth.

Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Ryan Harkin <ryan.harkin@linaro.org>
MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c

index 5adaa9745f3e164d496b91a4817bf8fa5aade9ed..6fde3b2c7aa9c337c8b560bfd753c31386671fe1 100644 (file)
@@ -806,7 +806,7 @@ TerminalDriverBindingStart (
     Status = TerminalDevice->SerialIo->SetAttributes (\r
                                         TerminalDevice->SerialIo,\r
                                         Mode->BaudRate,\r
-                                        0, // the device's default FIFO depth\r
+                                        Mode->ReceiveFifoDepth,\r
                                         (UINT32) SerialInTimeOut,\r
                                         (EFI_PARITY_TYPE) (Mode->Parity),\r
                                         (UINT8) Mode->DataBits,\r
index 2215df6c124c71547eb81caf0481cbf578c3acba..3be877b4661eab930dfd1b55dcf15159d8c1f551 100644 (file)
@@ -547,7 +547,7 @@ TerminalConInTimerHandler (
     Status = SerialIo->SetAttributes (\r
                         SerialIo,\r
                         Mode->BaudRate,\r
-                        0, // the device's default FIFO depth\r
+                        Mode->ReceiveFifoDepth,\r
                         (UINT32) SerialInTimeOut,\r
                         (EFI_PARITY_TYPE) (Mode->Parity),\r
                         (UINT8) Mode->DataBits,\r