]> git.proxmox.com Git - mirror_edk2.git/commitdiff
SecurityPkg: Remove enforcement of final GoIdle transition for CRB commands
authorRodrigo Gonzalez Del Cueto <rodrigo.gonzalez.del.cueto@intel.com>
Thu, 22 Sep 2022 07:35:36 +0000 (15:35 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fri, 30 Sep 2022 12:00:24 +0000 (12:00 +0000)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4077

Following the design described in the TCG specification,
the driver implementation of the CRB protocol does not require
enforcing completing the transition to goIdle at the end of a command
sequence.

Signed-off-by: Rodrigo Gonzalez Del Cueto <rodrigo.gonzalez.del.cueto@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c

index 840265292a88c38e3b7b61111ea06a2ad8f9c022..1f9ac5ab5a304d5ebd3acf9f78390dee421870c1 100644 (file)
@@ -381,19 +381,6 @@ GoIdle_Exit:
   //\r
   MmioWrite32 ((UINTN)&CrbReg->CrbControlRequest, PTP_CRB_CONTROL_AREA_REQUEST_GO_IDLE);\r
 \r
-  //\r
-  // Only enforce Idle state transition if execution fails when CRBIdleBypass==1\r
-  // Leave regular Idle delay at the beginning of next command execution\r
-  //\r
-  if (GetCachedIdleByPass () == 1) {\r
-    Status = PtpCrbWaitRegisterBits (\r
-               &CrbReg->CrbControlStatus,\r
-               PTP_CRB_CONTROL_AREA_STATUS_TPM_IDLE,\r
-               0,\r
-               PTP_TIMEOUT_C\r
-               );\r
-  }\r
-\r
   return Status;\r
 }\r
 \r