ShellPkg/HandleParsingLib: Correct format specifier for LoadedImage
authorJeff Westfahl <jeff.westfahl@ni.com>
Tue, 14 Mar 2017 21:02:01 +0000 (05:02 +0800)
committerRuiyu Ni <ruiyu.ni@intel.com>
Fri, 17 Mar 2017 04:25:14 +0000 (12:25 +0800)
The format specifier for the LoadOptions field of the LoadedImage protocol
is "%s". However, the data in LoadOptions is often generic binary data. A
format specifier of "%x" is more appropriate for this field.

Using "dh -v" with format specifier "%s" on BIOS images based on EDK II
source before commit 891d844 can cause a crash.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Westfahl <jeff.westfahl@ni.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni

index 0d51627c5fc80597511d507eaf16f48abf6c57c7..273a4201bcae911656e8d405540ed4aade81476b 100644 (file)
                                                   "     DeviceHandle..: %%H%x%%N\r\n"\r
                                                   "     FilePath......: %%H%x%%N\r\n"\r
                                                   "     OptionsSize...: %%H%x%%N\r\n"\r
                                                   "     DeviceHandle..: %%H%x%%N\r\n"\r
                                                   "     FilePath......: %%H%x%%N\r\n"\r
                                                   "     OptionsSize...: %%H%x%%N\r\n"\r
-                                                  "     LoadOptions...: %%H%s%%N\r\n"\r
+                                                  "     LoadOptions...: %%H%x%%N\r\n"\r
                                                   "     ImageBase.....: %%H%x%%N\r\n"\r
                                                   "     ImageSize.....: %%H%Lx%%N\r\n"\r
                                                   "     CodeType......: %%H%s%%N\r\n"\r
                                                   "     ImageBase.....: %%H%x%%N\r\n"\r
                                                   "     ImageSize.....: %%H%Lx%%N\r\n"\r
                                                   "     CodeType......: %%H%s%%N\r\n"\r