]> git.proxmox.com Git - mirror_edk2.git/commitdiff
BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked
authorPhilippe Mathieu-Daude <philmd@redhat.com>
Thu, 9 Jan 2020 10:55:44 +0000 (18:55 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fri, 10 Jan 2020 04:06:42 +0000 (04:06 +0000)
We are checking different emails from the signature list. We are
going to check more. To be able to differency, add a description
field, so the error reported is clearer.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
BaseTools/Scripts/PatchCheck.py

index 174d442aa70fbc22f6d1ed1f85d40236700402a8..58d0112544c99c5221674ebd4511586eb58b7d97 100755 (executable)
@@ -26,18 +26,22 @@ class Verbose:
 class EmailAddressCheck:\r
     """Checks an email address."""\r
 \r
-    def __init__(self, email):\r
+    def __init__(self, email, description):\r
         self.ok = True\r
 \r
         if email is None:\r
             self.error('Email address is missing!')\r
             return\r
+        if description is None:\r
+            self.error('Email description is missing!')\r
+            return\r
 \r
+        self.description = "'" + description + "'"\r
         self.check_email_address(email)\r
 \r
     def error(self, *err):\r
         if self.ok and Verbose.level > Verbose.ONELINE:\r
-            print('The email address is not valid:')\r
+            print('The ' + self.description + ' email address is not valid:')\r
         self.ok = False\r
         if Verbose.level < Verbose.NORMAL:\r
             return\r
@@ -174,7 +178,7 @@ class CommitMessageCheck:
             if s[2] != ' ':\r
                 self.error("There should be a space after '" + sig + ":'")\r
 \r
-            EmailAddressCheck(s[3])\r
+            EmailAddressCheck(s[3], sig)\r
 \r
         return sigs\r
 \r