]> git.proxmox.com Git - mirror_edk2.git/commitdiff
OvmfPkg: SataControllerDxe: SataControllerStop: remove useless null check
authorLaszlo Ersek <lersek@redhat.com>
Tue, 26 Apr 2016 11:51:55 +0000 (13:51 +0200)
committerLaszlo Ersek <lersek@redhat.com>
Tue, 26 Apr 2016 15:59:22 +0000 (17:59 +0200)
"ASSERT (SataPrivateData != NULL)" is just a few lines higher up.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
OvmfPkg/SataControllerDxe/SataController.c

index ba21717cad81416b3677b731551d899949796617..e5ee63a0ab631e192bc60ecb720dd50e806d5bf1 100644 (file)
@@ -602,18 +602,16 @@ SataControllerStop (
     return Status;\r
   }\r
 \r
-  if (SataPrivateData != NULL) {\r
-    if (SataPrivateData->DisqualifiedModes != NULL) {\r
-      FreePool (SataPrivateData->DisqualifiedModes);\r
-    }\r
-    if (SataPrivateData->IdentifyData != NULL) {\r
-      FreePool (SataPrivateData->IdentifyData);\r
-    }\r
-    if (SataPrivateData->IdentifyValid != NULL) {\r
-      FreePool (SataPrivateData->IdentifyValid);\r
-    }\r
-    FreePool (SataPrivateData);\r
+  if (SataPrivateData->DisqualifiedModes != NULL) {\r
+    FreePool (SataPrivateData->DisqualifiedModes);\r
   }\r
+  if (SataPrivateData->IdentifyData != NULL) {\r
+    FreePool (SataPrivateData->IdentifyData);\r
+  }\r
+  if (SataPrivateData->IdentifyValid != NULL) {\r
+    FreePool (SataPrivateData->IdentifyValid);\r
+  }\r
+  FreePool (SataPrivateData);\r
 \r
   //\r
   // Restore original PCI attributes\r