The root cause is an unnecessary check to Size parameter in function
AdjustMemoryS(). It will cause one standalone free page (happen to have
Guard page around) in the free memory list cannot be allocated, even if
the requested memory size is less than a page.
//
// At least one more page needed for Guard page.
//
if (Size < (SizeRequested + EFI_PAGES_TO_SIZE (1))) {
return 0;
}
The following code in the same function actually covers above check
implicitly. So the fix is simply removing above check.
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
/** @file\r
UEFI Heap Guard functions.\r
\r
/** @file\r
UEFI Heap Guard functions.\r
\r
-Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>\r
+Copyright (c) 2017-2018, Intel Corporation. All rights reserved.<BR>\r
This program and the accompanying materials\r
are licensed and made available under the terms and conditions of the BSD License\r
which accompanies this distribution. The full text of the license may be found at\r
This program and the accompanying materials\r
are licensed and made available under the terms and conditions of the BSD License\r
which accompanies this distribution. The full text of the license may be found at\r
\r
Target = Start + Size - SizeRequested;\r
\r
\r
Target = Start + Size - SizeRequested;\r
\r
- //\r
- // At least one more page needed for Guard page.\r
- //\r
- if (Size < (SizeRequested + EFI_PAGES_TO_SIZE (1))) {\r
- return 0;\r
- }\r
-\r
if (!IsGuardPage (Start + Size)) {\r
// No Guard at tail to share. One more page is needed.\r
Target -= EFI_PAGES_TO_SIZE (1);\r
if (!IsGuardPage (Start + Size)) {\r
// No Guard at tail to share. One more page is needed.\r
Target -= EFI_PAGES_TO_SIZE (1);\r
/** @file\r
UEFI Heap Guard functions.\r
\r
/** @file\r
UEFI Heap Guard functions.\r
\r
-Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>\r
+Copyright (c) 2017-2018, Intel Corporation. All rights reserved.<BR>\r
This program and the accompanying materials\r
are licensed and made available under the terms and conditions of the BSD License\r
which accompanies this distribution. The full text of the license may be found at\r
This program and the accompanying materials\r
are licensed and made available under the terms and conditions of the BSD License\r
which accompanies this distribution. The full text of the license may be found at\r
\r
Target = Start + Size - SizeRequested;\r
\r
\r
Target = Start + Size - SizeRequested;\r
\r
- //\r
- // At least one more page needed for Guard page.\r
- //\r
- if (Size < (SizeRequested + EFI_PAGES_TO_SIZE (1))) {\r
- return 0;\r
- }\r
-\r
if (!IsGuardPage (Start + Size)) {\r
// No Guard at tail to share. One more page is needed.\r
Target -= EFI_PAGES_TO_SIZE (1);\r
if (!IsGuardPage (Start + Size)) {\r
// No Guard at tail to share. One more page is needed.\r
Target -= EFI_PAGES_TO_SIZE (1);\r