]> git.proxmox.com Git - mirror_edk2.git/commitdiff
BaseTools ConvertMasmToNasm: put filter/map result in tuple for python3
authorJordan Justen <jordan.l.justen@intel.com>
Wed, 16 Mar 2016 23:14:14 +0000 (16:14 -0700)
committerJordan Justen <jordan.l.justen@intel.com>
Tue, 28 Jun 2016 20:16:39 +0000 (13:16 -0700)
Python 3's filter and map functions returns an iterator which you
can't call len() on. Since we'll want to use len() later, we put the
filter results into a tuple.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
BaseTools/Scripts/ConvertMasmToNasm.py

index 8b08a8855708955b43dee918bbf8885aa56ac21a..6343fbd94c6df4c9ff4725ef6a47a47707408e44 100755 (executable)
@@ -473,7 +473,7 @@ class ConvertAsmFile(CommonUtils):
             self.EmitAsmWithComment(oldAsm, newAsm, endOfLine)\r
             uses = self.mo.group(3)\r
             if uses is not None:\r
-                uses = filter(None, uses.split())\r
+                uses = tuple(filter(None, uses.split()))\r
             else:\r
                 uses = tuple()\r
             self.uses = uses\r
@@ -484,7 +484,7 @@ class ConvertAsmFile(CommonUtils):
             self.EmitAsmWithComment(oldAsm, newAsm, endOfLine)\r
         elif self.MatchAndSetMo(self.publicRe, oldAsm):\r
             publics = re.findall(self.varAndTypeSubRe, self.mo.group(1))\r
-            publics = map(lambda p: p.split(':')[0].strip(), publics)\r
+            publics = tuple(map(lambda p: p.split(':')[0].strip(), publics))\r
             for i in range(len(publics) - 1):\r
                 name = publics[i]\r
                 self.EmitNewContent('global ASM_PFX(%s)' % publics[i])\r