]> git.proxmox.com Git - mirror_edk2.git/commitdiff
OvmfPkg/PlatformPei: explain EFI_MEMORY_TYPE_INFORMATION page counts
authorLaszlo Ersek <lersek@redhat.com>
Thu, 12 Mar 2020 22:35:54 +0000 (23:35 +0100)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fri, 13 Mar 2020 17:25:00 +0000 (17:25 +0000)
Add a code comment that explains the nature of the NumberOfPages field
values. Including this kind of historical information was suggested by
Leif in <https://edk2.groups.io/g/devel/message/55797> (alternative link:
<http://mid.mail-archive.com/20200312104006.GB23627@bivouac.eciton.net>).

Right now, the most recent commit updating the page counts has been commit
991d95636264 ("[...] Update default memory type information to reduce EFI
Memory Map fragmentation.", 2010-07-16).

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Suggested-by: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20200312223555.29267-2-lersek@redhat.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
OvmfPkg/PlatformPei/MemTypeInfo.c

index c709236a457a23bbb934c6ec8c12c9811fb33f08..863c6f382680d30a3e43b59aff5158710460c0a2 100644 (file)
 \r
 #include "Platform.h"\r
 \r
+//\r
+// The NumberOfPages values below are ad-hoc. They are updated sporadically at\r
+// best (please refer to git-blame for past updates). The values capture a set\r
+// of BIN hints that made sense at a particular time, for some (now likely\r
+// unknown) workloads / boot paths.\r
+//\r
 STATIC EFI_MEMORY_TYPE_INFORMATION mDefaultMemoryTypeInformation[] = {\r
   { EfiACPIMemoryNVS,       0x004 },\r
   { EfiACPIReclaimMemory,   0x008 },\r