EmbeddedPkg/PrePiHobLib: drop CreateHobList() from library

Drop the declaration and the implementation of CreateHoblist(),
which is not used anywhere.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

diff --git a/EmbeddedPkg/Include/Library/PrePiLib.h b/EmbeddedPkg/Include/Library/PrePiLib.h
index cf70fca3b619da90ddfb08726fe41e4e15691ed7..a857308ecec20534dc55853c96332ad074053c57 100644 (file)
--- a/EmbeddedPkg/Include/Library/PrePiLib.h
+++ b/EmbeddedPkg/Include/Library/PrePiLib.h
@@ -274,24 +274,6 @@ HobConstructor (
   IN VOID   *EfiFreeMemoryTop\r
   );\r
 \r
-/**\r
-  Retrieves the magic value from the PE/COFF header.\r
-\r
-  @param  Hdr             The buffer in which to return the PE32, PE32+, or TE header.\r
-\r
-  @return EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC - Image is PE32\r
-  @return EFI_IMAGE_NT_OPTIONAL_HDR64_MAGIC - Image is PE32+\r
-\r
-**/\r
-VOID\r
-CreateHobList (\r
-  IN VOID   *MemoryBegin,\r
-  IN UINTN  MemoryLength,\r
-  IN VOID   *HobBase,\r
-  IN VOID   *StackBase\r
-  );\r
-\r
-\r
 /**\r
   This service enables PEIMs to create various types of HOBs.\r
 \r

diff --git a/EmbeddedPkg/Library/PrePiHobLib/Hob.c b/EmbeddedPkg/Library/PrePiHobLib/Hob.c
index aff8ea05797b10b81e975efc614d6ec5baa6f0ac..ba16899a918485fec4d6fee0f900c59edbae5fc1 100644 (file)
--- a/EmbeddedPkg/Library/PrePiHobLib/Hob.c
+++ b/EmbeddedPkg/Library/PrePiHobLib/Hob.c
@@ -175,47 +175,6 @@ BuildResourceDescriptorHob (
   Hob->ResourceLength    = NumberOfBytes;\r
 }\r
 \r
-/**\r
-\r
-\r
-**/\r
-VOID\r
-CreateHobList (\r
-  IN VOID   *MemoryBegin,\r
-  IN UINTN  MemoryLength,\r
-  IN VOID   *HobBase,\r
-  IN VOID   *StackBase\r
-  )\r
-{\r
-  EFI_HOB_HANDOFF_INFO_TABLE  *Hob;\r
-  EFI_RESOURCE_ATTRIBUTE_TYPE Attributes;\r
-\r
-  Hob = HobConstructor (MemoryBegin,MemoryLength,HobBase,StackBase);\r
-  SetHobList (Hob);\r
-\r
-  BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize));\r
-\r
-  Attributes =(\r
-    EFI_RESOURCE_ATTRIBUTE_PRESENT |\r
-    EFI_RESOURCE_ATTRIBUTE_INITIALIZED |\r
-    EFI_RESOURCE_ATTRIBUTE_TESTED |\r
-    EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE |\r
-    EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE |\r
-    EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE |\r
-    EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE\r
-  );\r
-\r
-  BuildResourceDescriptorHob (EFI_RESOURCE_SYSTEM_MEMORY, Attributes, (UINTN)MemoryBegin, MemoryLength);\r
-\r
-  BuildStackHob ((EFI_PHYSICAL_ADDRESS)(UINTN)StackBase, ((UINTN)MemoryBegin + MemoryLength) - (UINTN)StackBase);\r
-\r
-  if (FeaturePcdGet (PcdPrePiProduceMemoryTypeInformationHob)) {\r
-    // Optional feature that helps prevent EFI memory map fragmentation.\r
-    BuildMemoryTypeInformationHob ();\r
-  }\r
-}\r
-\r
-\r
 VOID\r
 EFIAPI\r
 BuildFvHobs (\r

diff --git a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
index 526db4c0d8f9bf6cfbd4e2fe1b2610228cb48e7c..ef5c5bdb8a9cd61836c6e1d635d5b3ea0a47305a 100644 (file)
--- a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
+++ b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
@@ -47,9 +47,6 @@
   gEfiHobMemoryAllocStackGuid\r
 \r
 [FixedPcd.common]\r
-  gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize\r
-  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize\r
-\r
   gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory\r
   gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS\r
   gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType\r