ShellPkg: prevent Close call when Open failed

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Tapan Shah <tapandshah@hp.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18096 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
index 0c99e23650de86e56c3d4a7ed21508585a624050..6e0f61130ff463f3bc2860245eb0944961770863 100644 (file)
--- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
+++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
@@ -702,8 +702,9 @@ ShellOpenFileByName(
       }\r
       PathCleanUpDirectories (FileNameCopy);\r
       if (PathRemoveLastItem (FileNameCopy)) {\r
-        ShellCreateDirectory (FileNameCopy, FileHandle);\r
-        ShellCloseFile (FileHandle);\r
+        if (!EFI_ERROR(ShellCreateDirectory (FileNameCopy, FileHandle))) {\r
+          ShellCloseFile (FileHandle);\r
+        }\r
       }\r
       SHELL_FREE_NON_NULL (FileNameCopy);\r
     }\r