OvmfPkg/VirtioGpuDxe: Check QueryMode arguments

The current implementation does not check if Info or SizeInfo
pointers are NULL. This causes the SCT test suite to crash.

Add a check to return EFI_INVALID_PARAMETER if any of these
pointers are NULL.

Signed-off-by: Dimitrije Pavlov <Dimitrije.Pavlov@arm.com>
Reviewed-by: Sunny Wang <sunny.wang@arm.com>

diff --git a/OvmfPkg/VirtioGpuDxe/Gop.c b/OvmfPkg/VirtioGpuDxe/Gop.c
index 401db47672ec8d6db5a0d4bfe25bfdb2288e3612..16e92830d411b3283bf2df5b06741dc39e2af989 100644 (file)
--- a/OvmfPkg/VirtioGpuDxe/Gop.c
+++ b/OvmfPkg/VirtioGpuDxe/Gop.c
@@ -308,7 +308,10 @@ GopQueryMode (
 {\r
   EFI_GRAPHICS_OUTPUT_MODE_INFORMATION  *GopModeInfo;\r
 \r
-  if (ModeNumber >= This->Mode->MaxMode) {\r
+  if ((Info == NULL) ||\r
+      (SizeOfInfo == NULL) ||\r
+      (ModeNumber >= This->Mode->MaxMode))\r
+  {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r