Add missing break and add comment to non-necessary break.

Signed-off-by: Li Elvin <elvin.li@intel.com>
Reviewed-by: Ni Ruiyu <ruiyu.ni@intel.com>
Reviewed-by: Dong Eric <eric.dong@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13642 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
index d80c3d5c6f6579f8f090fce3b28eac03eb85e78a..1a88a746cbf5b9d8fce07a1e892c5d8c4f714b8a 100644 (file)
--- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
+++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
@@ -1457,6 +1457,7 @@ UnicodeToEfiKey (
           if (TerminalDevice->TerminalType == PCANSITYPE) {\r
             Key.ScanCode = SCAN_F10;\r
           }\r
+          break;\r
         case '?':\r
           if (TerminalDevice->TerminalType == VT100TYPE) {\r
             Key.ScanCode = SCAN_PAGE_UP;\r
@@ -1471,6 +1472,7 @@ UnicodeToEfiKey (
           if (TerminalDevice->TerminalType == PCANSITYPE) {\r
             Key.ScanCode = SCAN_F9;\r
           }\r
+          break;\r
         case '/':\r
           if (TerminalDevice->TerminalType == VT100TYPE) {\r
             Key.ScanCode = SCAN_PAGE_DOWN;\r

diff --git a/MdeModulePkg/Universal/DevicePathDxe/DevicePathFromText.c b/MdeModulePkg/Universal/DevicePathDxe/DevicePathFromText.c
index 11f5c159df449acb1482c1f9e3dbeb2e08b19cc5..d94e149e588cec0d78058538d2c238e13628120b 100644 (file)
--- a/MdeModulePkg/Universal/DevicePathDxe/DevicePathFromText.c
+++ b/MdeModulePkg/Universal/DevicePathDxe/DevicePathFromText.c
@@ -1,7 +1,7 @@
 /** @file\r
   DevicePathFromText protocol as defined in the UEFI 2.0 specification.\r
 \r
-Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>\r
+Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.<BR>\r
 This program and the accompanying materials\r
 are licensed and made available under the terms and conditions of the BSD License\r
 which accompanies this distribution.  The full text of the license may be found at\r
@@ -2006,6 +2006,7 @@ DevPathFromTextUart (
 \r
   case L'S':\r
     Uart->Parity = 5;\r
+    break;\r
 \r
   default:\r
     Uart->Parity = 0xff;\r

diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c b/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c
index e16b2e424a7338106afd9dff304942294dc26d28..f48afbf66c68d839dedcc41c7d9bf1643443df22 100644 (file)
--- a/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c
@@ -767,7 +767,9 @@ UiAddMenuOption (
         //\r
         MenuOption->GrayOut = TRUE;\r
       }\r
-\r
+      //\r
+      // break skipped on purpose\r
+      //\r
     default:\r
       MenuOption->IsQuestion = FALSE;\r
       break;\r