Add some comments, clear describe the efi varstore type.

Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14594 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c b/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c
index 1c3ab2bedca4e1e45b6160c7b1ce027827a4501e..11839ad6cee5602ec884bffeafab54bde41544c9 100644 (file)
--- a/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c
@@ -1625,8 +1625,14 @@ ParseOpCodes (
       // Create a EFI variable Storage for this FormSet\r
       //\r
       if (OpCodeLength < sizeof (EFI_IFR_VARSTORE_EFI)) {\r
+        //\r
+        // Create efi varstore with format follow UEFI spec before 2.3.1.\r
+        //\r
         Storage = CreateStorage (FormSet, EFI_HII_VARSTORE_EFI_VARIABLE, OpCodeData);\r
       } else {\r
+        //\r
+        // Create efi varstore with format follow UEFI spec 2.3.1 and later.\r
+        //\r
         Storage = CreateStorage (FormSet, EFI_HII_VARSTORE_EFI_VARIABLE_BUFFER, OpCodeData);\r
       }\r
       CopyMem (&Storage->VarStoreId, &((EFI_IFR_VARSTORE_EFI *) OpCodeData)->VarStoreId, sizeof (EFI_VARSTORE_ID));\r

diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.h b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.h
index 030cf32eac72ba0e63d509394c66b2327b18d1c6..e5f9d18b5b1b43b0945bf3accfc24f9c7fcff56e 100644 (file)
--- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.h
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.h
@@ -109,8 +109,8 @@ typedef struct {
 \r
 #define EFI_HII_VARSTORE_BUFFER              0\r
 #define EFI_HII_VARSTORE_NAME_VALUE          1\r
-#define EFI_HII_VARSTORE_EFI_VARIABLE        2\r
-#define EFI_HII_VARSTORE_EFI_VARIABLE_BUFFER 3\r
+#define EFI_HII_VARSTORE_EFI_VARIABLE        2    // EFI Varstore type follow UEFI spec before 2.3.1.\r
+#define EFI_HII_VARSTORE_EFI_VARIABLE_BUFFER 3    // EFI varstore type follow UEFI spec 2.3.1 and later.\r
 \r
 #define FORM_INCONSISTENT_VALIDATION         0\r
 #define FORM_NO_SUBMIT_VALIDATION            1\r