UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2609

SavedState is not sticky, copied pointer update will not change source
pointer

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>

diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
index b136992d99a0774228ed656d95d676d0d45139e0..ba4b18568d5f2c31c507dd99f86277f44815b175 100644 (file)
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
@@ -209,7 +209,6 @@ InitUnitTestFramework (
   EFI_STATUS                  Status;\r
   UNIT_TEST_FRAMEWORK_HANDLE  NewFrameworkHandle;\r
   UNIT_TEST_FRAMEWORK         *NewFramework;\r
-  UNIT_TEST_SAVE_HEADER       *SavedState;\r
 \r
   Status       = EFI_SUCCESS;\r
   NewFramework = NULL;\r
@@ -264,8 +263,7 @@ InitUnitTestFramework (
   // If there is a persisted context, load it now.\r
   //\r
   if (DoesCacheExist (NewFrameworkHandle)) {\r
-    SavedState = (UNIT_TEST_SAVE_HEADER *)NewFramework->SavedState;\r
-    Status = LoadUnitTestCache (NewFrameworkHandle, &SavedState);\r
+    Status = LoadUnitTestCache (NewFrameworkHandle,  (UNIT_TEST_SAVE_HEADER**)(&NewFramework->SavedState));\r
     if (EFI_ERROR (Status)) {\r
       //\r
       // Don't actually report it as an error, but emit a warning.\r