]> git.proxmox.com Git - mirror_edk2.git/commitdiff
Fix cyclic dependency error on OptionROM build
authorKonstantin Aladyshev <aladyshev22@gmail.com>
Tue, 13 Dec 2022 16:22:22 +0000 (00:22 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Tue, 17 Jan 2023 06:14:03 +0000 (06:14 +0000)
EDKII build system supports OptionROM generation if particular PCI_*
defines are present in the module INF file:
```
[Defines]
  ...
  PCI_VENDOR_ID                  = <...>
  PCI_DEVICE_ID                  = <...>
  PCI_CLASS_CODE                 = <...>
  PCI_REVISION                   = <...>
```
Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698
("BaseTools/Conf: Fix Dynamic-Library-File template") it is no longer
possible.
The build system fails with the error:
```
Cyclic dependency detected while generating rule for
"<...>/DEBUG/<...>.efi" file
```
Remove "$(DEBUG_DIR)(+)$(MODULE_NAME).efi" from the 'dll' output files
to fix the cyclic dependency.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
BaseTools/Conf/build_rule.template

index ec8363814496b351a0d70de5c0927d56a3f635f6..d42e7937cc906acf3a7542cf165eb611a3789fa3 100755 (executable)
 \r
     <OutputFile>\r
         $(OUTPUT_DIR)(+)$(MODULE_NAME).efi\r
-        $(DEBUG_DIR)(+)$(MODULE_NAME).efi\r
         $(OUTPUT_DIR)(+)$(MODULE_NAME).map\r
 \r
     <Command.MSFT, Command.INTEL, Command.CLANGPDB>\r