]> git.proxmox.com Git - mirror_edk2.git/commitdiff
BaseTools: Should always define PCD TOKEN value as Zero for static PCD
authorYunhua Feng <fengyunhua@byosoft.com.cn>
Thu, 17 Dec 2020 01:09:51 +0000 (09:09 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Wed, 23 Dec 2020 02:33:36 +0000 (02:33 +0000)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3120
FixedAtBuild, PatchableInModule and FeatureFlag PCD don't use PCD TOKEN.
Their PCD TOKEN value can always be zero.
AutoGen.h will not be changed when static PCD is added or removed.
Dynamic PCD add or remove will still cause dynamic PCD token value be
changed.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
BaseTools/Source/Python/AutoGen/PlatformAutoGen.py

index c001828937ea85f3f6192e42b9ec94956cbb0e72..7d8e7b3c7cc1eaa207889a61fe552c9989996d6e 100644 (file)
@@ -1037,8 +1037,7 @@ class PlatformAutoGen(AutoGen):
                 TokenNumber += 1\r
 \r
         for Pcd in self.NonDynamicPcdList:\r
-            RetVal[Pcd.TokenCName, Pcd.TokenSpaceGuidCName] = TokenNumber\r
-            TokenNumber += 1\r
+            RetVal[Pcd.TokenCName, Pcd.TokenSpaceGuidCName] = 0\r
         return RetVal\r
 \r
     @cached_property\r