]> git.proxmox.com Git - mirror_edk2.git/commitdiff
ArmPlatformPkg: PL111Lcd: Replace magic number with macro
authorGirish Pathak <girish.pathak at arm.com>
Tue, 26 Sep 2017 20:15:16 +0000 (21:15 +0100)
committerLeif Lindholm <leif.lindholm@linaro.org>
Mon, 23 Apr 2018 11:00:37 +0000 (12:00 +0100)
Minor code change, replaces magic number with macro in LCD disable.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Girish Pathak <girish.pathak@arm.com>
Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c

index cb64c57dd79f3bb1345e4d3dbda7f5b3ce859f40..287e3ca272c0c19f8045a3bf4e69a092d8da6fd8 100644 (file)
@@ -119,8 +119,7 @@ LcdSetMode (
   }\r
 \r
   // Disable the CLCD_LcdEn bit\r
-  LcdControl = MmioRead32 (PL111_REG_LCD_CONTROL);\r
-  MmioWrite32 (PL111_REG_LCD_CONTROL, LcdControl & ~1);\r
+  MmioAnd32 (PL111_REG_LCD_CONTROL, ~PL111_CTRL_LCD_EN);\r
 \r
   // Set Timings\r
   MmioWrite32 (\r