]> git.proxmox.com Git - mirror_edk2.git/commitdiff
EmbeddedPkg/AcpiLib: fix SBSA Generic Watchdog helper definition
authorSami Mujawar <sami.mujawar@arm.com>
Fri, 4 Mar 2016 13:46:01 +0000 (13:46 +0000)
committerArd Biesheuvel <ard.biesheuvel@linaro.org>
Fri, 1 Apr 2016 15:04:12 +0000 (17:04 +0200)
The Reserved field in the SBSA Generic Watchdog Structure is 1 byte in
length. Refer Table 5-123 in the ACPI 5.1 Specification Errata A.

The EFI_ACPI_5_1_SBSA_GENERIC_WATCHDOG_STRUCTURE_INIT() helper
macro was initializing this field as EFI_ACPI_RESERVED_WORD instead of
EFI_ACPI_RESERVED_BYTE.

Although this does not cause any functional issue; it does not comply
with the specification.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
EmbeddedPkg/Include/Library/AcpiLib.h

index 42710fd1fd62f477c560b98922ceae59c4ccccaa..74a929c9c02c71219f6acbf4dc764478666019d4 100644 (file)
@@ -1,7 +1,7 @@
 /** @file\r
   Helper Library for ACPI\r
 \r
-  Copyright (c) 2014-2015, ARM Ltd. All rights reserved.\r
+  Copyright (c) 2014-2016, ARM Ltd. All rights reserved.\r
 \r
   This program and the accompanying materials\r
   are licensed and made available under the terms and conditions of the BSD License\r
@@ -67,7 +67,7 @@
     ControlFramePhysicalAddress, WatchdogTimerGSIV, WatchdogTimerFlags)                                 \\r
   {                                                                                                     \\r
     EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG, sizeof(EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE), \\r
-    EFI_ACPI_RESERVED_WORD, RefreshFramePhysicalAddress, ControlFramePhysicalAddress,                   \\r
+    EFI_ACPI_RESERVED_BYTE, RefreshFramePhysicalAddress, ControlFramePhysicalAddress,                   \\r
     WatchdogTimerGSIV, WatchdogTimerFlags                                                               \\r
   }\r
 \r