Fix ECC issue.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6142 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/MdeModulePkg/Core/Pei/BootMode/BootMode.c b/MdeModulePkg/Core/Pei/BootMode/BootMode.c
index 8c38fa8dc6d3fd62633cf32824cd819e18bf08d6..74b90529ae4f4762f2e4b3e1a20875d9942a6241 100644 (file)
--- a/MdeModulePkg/Core/Pei/BootMode/BootMode.c
+++ b/MdeModulePkg/Core/Pei/BootMode/BootMode.c
@@ -32,7 +32,7 @@ EFI_STATUS
 EFIAPI\r
 PeiGetBootMode (\r
   IN  CONST EFI_PEI_SERVICES  **PeiServices,\r
-  OUT       EFI_BOOT_MODE     *BootMode\r
+  IN  OUT   EFI_BOOT_MODE     *BootMode\r
   )\r
 {\r
   PEI_CORE_INSTANCE             *PrivateData;    \r

diff --git a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
index 49b3d368647dcd1e129358736449ee057f6bd0e5..54b145b8f06146b7448eba13ec88e561f10a5549 100644 (file)
--- a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
+++ b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
@@ -231,9 +231,6 @@ ShadowPeiCore(
                          the BFV location.\r
   @param Private         Pointer to the private data passed in from caller\r
 \r
-  @retval EFI_SUCCESS   - Successfully dispatched PEIM.\r
-  @retval EFI_NOT_FOUND - The dispatch failed.\r
-\r
 **/\r
 VOID\r
 PeiDispatcher (\r

diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
index 37ddb797fe567f52952f3f6665a8b2c4a5f0e9be..807476fba492bd137a44d6c93482ccc7388bd6be 100644 (file)
--- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
+++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
@@ -163,7 +163,7 @@ PeiFindFileEx (
   FileHeader  = (EFI_FFS_FILE_HEADER **)FileHandle;\r
 \r
   FvLength = FwVolHeader->FvLength;\r
-  if (FwVolHeader->Attributes & EFI_FVB2_ERASE_POLARITY) {\r
+  if ((FwVolHeader->Attributes & EFI_FVB2_ERASE_POLARITY) != 0) {\r
     ErasePolarity = 1;\r
   } else {\r
     ErasePolarity = 0;\r

diff --git a/MdeModulePkg/Core/Pei/Image/Image.c b/MdeModulePkg/Core/Pei/Image/Image.c
index 25c6330db79cef7b217705aa59ea6e1f99e6ccf0..4918c1a6da88237fbaf343029db53cec291af28c 100644 (file)
--- a/MdeModulePkg/Core/Pei/Image/Image.c
+++ b/MdeModulePkg/Core/Pei/Image/Image.c
@@ -78,7 +78,7 @@ PeiImageRead (
   Destination8  = Buffer;\r
   Source8       = (CHAR8 *) ((UINTN) FileHandle + FileOffset);\r
   Length        = *ReadSize;\r
-  while (Length--) {\r
+  while ((Length--) > 0) {\r
     *(Destination8++) = *(Source8++);\r
   }\r
 \r

diff --git a/MdeModulePkg/Core/Pei/PeiMain.h b/MdeModulePkg/Core/Pei/PeiMain.h
index 6f040d015586837034ea2f0d2be0173e03182ac1..4e66b71beefb4a60b3633012277ea75d3703bd6e 100644 (file)
--- a/MdeModulePkg/Core/Pei/PeiMain.h
+++ b/MdeModulePkg/Core/Pei/PeiMain.h
@@ -234,7 +234,7 @@ EFI_STATUS
 EFIAPI\r
 PeiCore (\r
   IN CONST EFI_SEC_PEI_HAND_OFF        *SecCoreData,\r
-  IN CONST EFI_PEI_PPI_DESCRIPTOR      *PpList,\r
+  IN CONST EFI_PEI_PPI_DESCRIPTOR      *PpiList,\r
   IN VOID                              *Data\r
   );\r
 \r
@@ -274,9 +274,6 @@ PeimDispatchReadiness (
   @param SecCoreData     Pointer to the data structure containing SEC to PEI handoff data\r
   @param PrivateData     Pointer to the private data passed in from caller\r
 \r
-  @retval EFI_SUCCESS    Successfully dispatched PEIM.\r
-  @retval EFI_NOT_FOUND  The dispatch failed.\r
-\r
 **/\r
 VOID\r
 PeiDispatcher (\r
@@ -500,7 +497,7 @@ EFI_STATUS
 EFIAPI\r
 PeiGetBootMode (\r
   IN CONST EFI_PEI_SERVICES  **PeiServices,\r
-  IN OUT EFI_BOOT_MODE *BootMode\r
+  IN OUT   EFI_BOOT_MODE     *BootMode\r
   );\r
 \r
 /**\r
@@ -539,7 +536,7 @@ InitializeSecurityServices (
   );\r
 \r
 /**\r
-  Verify a Firmware volume\r
+  Verify a Firmware volume.\r
 \r
   @param CurrentFvAddress           Pointer to the current Firmware Volume under consideration\r
 \r
@@ -1016,7 +1013,7 @@ InitializeImageServices (
   Get Fv image from the FV type file, then install FV INFO ppi, Build FV hob.\r
 \r
   @param PeiServices          An indirect pointer to the EFI_PEI_SERVICES table published by the PEI Foundation.\r
-  @param FileHandle           File handle of a Fv type file.\r
+  @param FvFileHandle         File handle of a Fv type file.\r
   @param AuthenticationState  Pointer to attestation authentication state of image.\r
                               If return 0, means pass security checking.\r
 \r