]> git.proxmox.com Git - mirror_edk2.git/commitdiff
ArmPkg: Fix Ecc error 8005 for SCMI_STATUS
authorPierre Gondois <Pierre.Gondois@arm.com>
Fri, 15 Jan 2021 17:07:16 +0000 (17:07 +0000)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Thu, 15 Apr 2021 19:53:39 +0000 (19:53 +0000)
This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
ArmPkg/Drivers/ArmScmiDxe/Scmi.c
ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h

index 25f6cc3371afc34bac8ad5f7855f43f51801e261..a1bf1b95c052e0163eb3ea1e208756c93986bdfb 100644 (file)
@@ -123,7 +123,7 @@ ScmiCommandExecute (
 \r
   Response = (SCMI_MESSAGE_RESPONSE*)MtlGetChannelPayload (Channel);\r
 \r
-  if (Response->Status != SCMI_SUCCESS) {\r
+  if (Response->Status != ScmiSuccess) {\r
     DEBUG ((DEBUG_ERROR, "SCMI error: ProtocolId = 0x%x, MessageId = 0x%x, error = %d\n",\r
       Command->ProtocolId,\r
       Command->MessageId,\r
index 6de57a5c9514667ccd81269041a8af02821d1a6c..118961dbe219c2bf575731d870c855dacf1f5986 100644 (file)
@@ -30,17 +30,17 @@ typedef enum {
 \r
 // SCMI response error codes.\r
 typedef enum {\r
-  SCMI_SUCCESS            =  0,\r
-  SCMI_NOT_SUPPORTED      = -1,\r
-  SCMI_INVALID_PARAMETERS = -2,\r
-  SCMI_DENIED             = -3,\r
-  SCMI_NOT_FOUND          = -4,\r
-  SCMI_OUT_OF_RANGE       = -5,\r
-  SCMI_BUSY               = -6,\r
-  SCMI_COMMS_ERROR        = -7,\r
-  SCMI_GENERIC_ERROR      = -8,\r
-  SCMI_HARDWARE_ERROR     = -9,\r
-  SCMI_PROTOCOL_ERROR     = -10\r
+  ScmiSuccess           =  0,\r
+  ScmiNotSupported      = -1,\r
+  ScmiInvalidParameters = -2,\r
+  ScmiDenied            = -3,\r
+  ScmiNotFound          = -4,\r
+  ScmiOutOfRange        = -5,\r
+  ScmiBusy              = -6,\r
+  ScmiCommsError        = -7,\r
+  ScmiGenericError      = -8,\r
+  ScmiHardwareError     = -9,\r
+  ScmiProtocolError     = -10\r
 } SCMI_STATUS;\r
 \r
 // SCMI message IDs common to all protocols.\r