ArmPlatformPkg: Fix Ecc error 5007 in LcdGraphicsOutputDxe

This patch fixes the following Ecc reported error:
There should be no initialization of a variable as
part of its declaration

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
index c865215ec68ecba1e809108cffec9354f042561e..07d2cb0d5dec0f85219fe5cdc438e18ae3a32a38 100644 (file)
--- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
+++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
@@ -1,6 +1,6 @@
 /** @file\r
 \r
- Copyright (c) 2011-2013, ARM Ltd. All rights reserved.<BR>\r
+ Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.<BR>\r
  SPDX-License-Identifier: BSD-2-Clause-Patent\r
 \r
  **/\r
@@ -36,7 +36,7 @@ VideoCopyNoHorizontalOverlap (
   IN UINTN          Height\r
 )\r
 {\r
-  EFI_STATUS    Status = EFI_SUCCESS;\r
+  EFI_STATUS    Status;\r
   UINTN         SourceLine;\r
   UINTN         DestinationLine;\r
   UINTN         WidthInBytes;\r
@@ -45,6 +45,8 @@ VideoCopyNoHorizontalOverlap (
   VOID          *SourceAddr;\r
   VOID          *DestinationAddr;\r
 \r
+  Status = EFI_SUCCESS;\r
+\r
   if( DestinationY <= SourceY ) {\r
     // scrolling up (or horizontally but without overlap)\r
     SourceLine       = SourceY;\r
@@ -128,7 +130,7 @@ VideoCopyHorizontalOverlap (
   IN UINTN          Height\r
 )\r
 {\r
-  EFI_STATUS      Status = EFI_SUCCESS;\r
+  EFI_STATUS      Status;\r
 \r
   UINT32 *PixelBuffer32bit;\r
   UINT32 *SourcePixel32bit;\r
@@ -143,6 +145,8 @@ VideoCopyHorizontalOverlap (
   UINTN           SizeIn32Bits;\r
   UINTN           SizeIn16Bits;\r
 \r
+  Status = EFI_SUCCESS;\r
+\r
   switch (BitsPerPixel) {\r
 \r
   case LCD_BITS_PER_PIXEL_24:\r

diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c
index f1f104858d8ed456089180e6e82bcc54d4b46b62..bfd03d8f84258158e76690cc5a0d9333f11d67f0 100644 (file)
--- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c
+++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c
@@ -1,7 +1,7 @@
 /** @file\r
   This file implements the Graphics Output protocol for Arm platforms\r
 \r
-  Copyright (c) 2011-2018, ARM Ltd. All rights reserved.<BR>\r
+  Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.<BR>\r
   SPDX-License-Identifier: BSD-2-Clause-Patent\r
 \r
 **/\r
@@ -102,7 +102,7 @@ InitializeDisplay (
   IN LCD_INSTANCE* Instance\r
   )\r
 {\r
-  EFI_STATUS             Status = EFI_SUCCESS;\r
+  EFI_STATUS             Status;\r
   EFI_PHYSICAL_ADDRESS   VramBaseAddress;\r
   UINTN                  VramSize;\r
 \r
@@ -148,7 +148,7 @@ LcdGraphicsOutputDxeInitialize (
   IN EFI_SYSTEM_TABLE   *SystemTable\r
   )\r
 {\r
-  EFI_STATUS  Status = EFI_SUCCESS;\r
+  EFI_STATUS  Status;\r
   LCD_INSTANCE* Instance;\r
 \r
   Status = LcdIdentify ();\r
@@ -246,7 +246,7 @@ LcdGraphicsQueryMode (
   OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION   **Info\r
   )\r
 {\r
-  EFI_STATUS Status = EFI_SUCCESS;\r
+  EFI_STATUS Status;\r
   LCD_INSTANCE *Instance;\r
 \r
   Instance = LCD_INSTANCE_FROM_GOP_THIS (This);\r
@@ -296,7 +296,7 @@ LcdGraphicsSetMode (
   IN UINT32                         ModeNumber\r
   )\r
 {\r
-  EFI_STATUS                      Status = EFI_SUCCESS;\r
+  EFI_STATUS                      Status;\r
   EFI_GRAPHICS_OUTPUT_BLT_PIXEL   FillColour;\r
   LCD_INSTANCE*                   Instance;\r
   LCD_BPP                         Bpp;\r