ShellPkg: Fix comments. Refine code style.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15815 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c
index 798f5476f6db36e61ab089efab0813f5c5057eb9..24fa485137dc6f1d39e5364171ed38940553e5eb 100644 (file)
--- a/ShellPkg/Application/Shell/ShellProtocol.c
+++ b/ShellPkg/Application/Shell/ShellProtocol.c
@@ -2054,7 +2054,7 @@ EfiShellFindFilesInDir(
   }\r
   SHELL_FREE_NON_NULL(BasePath);\r
   return(Status);\r
-  }\r
+}\r
 \r
 /**\r
   Get the GUID value from a human readable name.\r
@@ -2586,8 +2586,8 @@ EfiShellOpenFileList(
                                 multiple environment variables are being returned, Attributes\r
                                 is undefined.\r
 \r
-  @retval NULL                  The environment variable doesn\92t exist.\r
-  @return                       A non-NULL value points to the variable\92s value. The returned\r
+  @retval NULL                  The environment variable doesn't exist.\r
+  @return                       A non-NULL value points to the variable's value. The returned\r
                                 pointer does not need to be freed by the caller.\r
 **/\r
 CONST CHAR16 *\r

diff --git a/ShellPkg/Include/Protocol/EfiShell.h b/ShellPkg/Include/Protocol/EfiShell.h
index c39843ea4532ad09c2c8c4364f5dfb7e9895a3ad..ca21899df74ff80edca72e6e02f74188f46b762d 100644 (file)
--- a/ShellPkg/Include/Protocol/EfiShell.h
+++ b/ShellPkg/Include/Protocol/EfiShell.h
@@ -431,8 +431,8 @@ CONST CHAR16 *
                                 multiple environment variables are being returned, Attributes\r
                                 is undefined.\r
 \r
-  @retval NULL                  The environment variable doesn\92t exist.  \r
-  @return                       The environment variable\92s value. The returned pointer does not \r
+  @retval NULL                  The environment variable doesn't exist.  \r
+  @return                       The environment variable's value. The returned pointer does not \r
                                 need to be freed by the caller.  \r
 **/\r
 typedef\r

diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
index 7f272da7f5887202f8f6e30257de873a2f8fd891..f361f3a2749511554a65c7ffa245c26edb90e214 100644 (file)
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
@@ -820,8 +820,8 @@ InternalShellGetNodeFromGuid(
 Function to add a new GUID/Name mapping.\r
 \r
 @param[in] Guid       The Guid\r
-@param[in] NameId     The STRING id of the HII string to use\r
-@param[in] Dump       The pointer to the dump function\r
+@param[in] NameID     The STRING id of the HII string to use\r
+@param[in] DumpFunc   The pointer to the dump function\r
 \r
 \r
 @retval EFI_SUCCESS           The operation was sucessful\r

diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
index ebb84dd55ec1d5405221370d65b9c3b8c1bbb6f3..2984da9699ec7caa14e01768510d9539cc3e52ff 100644 (file)
--- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
+++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
@@ -215,7 +215,7 @@ ShellCommandLibDestructor (
 }\r
 \r
 /**\r
-  Find a dynamic command protocol instance given a command name string\r
+  Find a dynamic command protocol instance given a command name string.\r
 \r
   @param CommandString  the command name string\r
 \r
@@ -277,7 +277,7 @@ ShellCommandDynamicCommandExists (
   IN CONST CHAR16 *CommandString\r
   )\r
 {\r
-  return (ShellCommandFindDynamicCommand(CommandString) != NULL);\r
+  return (BOOLEAN) ((ShellCommandFindDynamicCommand(CommandString) != NULL));\r
 }\r
 \r
 /**\r

diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c b/ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c
index a5dfade8f11826b4afa21004c9b60cec4d583c57..e0e15dbc3d1200bd7753eca32da0ff165fa9b3b0 100644 (file)
--- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c
+++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c
@@ -35,11 +35,15 @@ PrintDynamicCommandHelp(
   )\r
 {\r
   EFI_STATUS                          Status;\r
-  BOOLEAN                             Found = FALSE;\r
-  EFI_HANDLE                          *CommandHandleList = NULL;\r
+  BOOLEAN                             Found;\r
+  EFI_HANDLE                          *CommandHandleList;\r
   EFI_HANDLE                          *NextCommand;\r
   EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL  *DynamicCommand;\r
-  CHAR16                              *OutText = NULL;\r
+  CHAR16                              *OutText;\r
+  \r
+  Found = FALSE;\r
+  CommandHandleList = NULL;\r
+  OutText = NULL;\r
 \r
   CommandHandleList = GetHandleListByProtocol(&gEfiShellDynamicCommandProtocolGuid);\r
 \r