]> git.proxmox.com Git - mirror_edk2.git/commitdiff
MdeModulePkg: stop abusing EFI_HANDLE for keystroke notify registration
authorLaszlo Ersek <lersek@redhat.com>
Sat, 7 Sep 2019 11:34:09 +0000 (13:34 +0200)
committerLaszlo Ersek <lersek@redhat.com>
Wed, 9 Oct 2019 07:40:09 +0000 (09:40 +0200)
EFI_REGISTER_KEYSTROKE_NOTIFY and EFI_UNREGISTER_KEYSTROKE_NOTIFY require
the notification handle to have type (VOID*). The notification handle has
nothing to do with the EFI_HANDLE type.

This change is a semantic fix; functionally, it's a no-op.

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c

index 63c814ae1816755f3011fcb588037d3dddea1320..9c38271b65f9e0663825ed552d482da96cb80280 100644 (file)
@@ -4026,7 +4026,7 @@ ConSplitterTextInRegisterKeyNotify (
   if (NewNotify == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
-  NewNotify->NotifyHandleList = (EFI_HANDLE *) AllocateZeroPool (sizeof (EFI_HANDLE) *  Private->TextInExListCount);\r
+  NewNotify->NotifyHandleList = (VOID **) AllocateZeroPool (sizeof (VOID *) *  Private->TextInExListCount);\r
   if (NewNotify->NotifyHandleList == NULL) {\r
     gBS->FreePool (NewNotify);\r
     return EFI_OUT_OF_RESOURCES;\r
index 7cfd5c17886164120fa3beecdf474643b8fc6360..f98797225b639b3eeea26ae167cb5e5afae9a866 100644 (file)
@@ -143,7 +143,7 @@ InternalStartMonitor(
   EFI_HANDLE                        *Handles;\r
   UINTN                             HandleCount;\r
   UINTN                             HandleIndex;\r
-  EFI_HANDLE                        NotifyHandle;\r
+  VOID                              *NotifyHandle;\r
 \r
   Status = gBS->LocateHandleBuffer (\r
               ByProtocol,\r
@@ -202,7 +202,7 @@ InternalStopMonitor(
   EFI_KEY_DATA                      KeyData;\r
   UINTN                             HandleCount;\r
   UINTN                             HandleIndex;\r
-  EFI_HANDLE                        NotifyHandle;\r
+  VOID                              *NotifyHandle;\r
 \r
   Status = gBS->LocateHandleBuffer (\r
                 ByProtocol,\r