/*
* atacmds.cpp
*
- * Home page of code is: http://smartmontools.sourceforge.net
+ * Home page of code is: http://www.smartmontools.org
*
- * Copyright (C) 2002-11 Bruce Allen <smartmontools-support@lists.sourceforge.net>
- * Copyright (C) 2008-12 Christian Franke <smartmontools-support@lists.sourceforge.net>
+ * Copyright (C) 2002-11 Bruce Allen
+ * Copyright (C) 2008-15 Christian Franke
* Copyright (C) 1999-2000 Michael Cornwell <cornwell@acm.org>
* Copyright (C) 2000 Andre Hedrick <andre@linux-ide.org>
*
* any later version.
*
* You should have received a copy of the GNU General Public License
- * (for example COPYING); if not, write to the Free
- * Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ * (for example COPYING); If not, see <http://www.gnu.org/licenses/>.
*
* This code was originally developed as a Senior Thesis by Michael Cornwell
* at the Concurrent Systems Laboratory (now part of the Storage Systems
#include "config.h"
#include "int64.h"
#include "atacmds.h"
+#include "knowndrives.h" // get_default_attr_defs()
#include "utility.h"
#include "dev_ata_cmd_set.h" // for parsed_ata_device
-const char * atacmds_cpp_cvsid = "$Id: atacmds.cpp 3528 2012-03-25 17:13:47Z chrfranke $"
+const char * atacmds_cpp_cvsid = "$Id: atacmds.cpp 4301 2016-04-16 20:48:29Z chrfranke $"
ATACMDS_H_CVSID;
// Print ATA debug messages?
#define SRET_STATUS_HI_EXCEEDED 0x2C
#define SRET_STATUS_MID_EXCEEDED 0xF4
-// These Drive Identity tables are taken from hdparm 5.2, and are also
-// given in the ATA/ATAPI specs for the IDENTIFY DEVICE command. Note
-// that SMART was first added into the ATA/ATAPI-3 Standard with
-// Revision 3 of the document, July 25, 1995. Look at the "Document
-// Status" revision commands at the beginning of
-// http://www.t13.org/Documents/UploadedDocuments/project/d2008r7b-ATA-3.pdf
-// to see this.
-#define NOVAL_0 0x0000
-#define NOVAL_1 0xffff
-/* word 81: minor version number */
-#define MINOR_MAX 0x22
-static const char * const minor_str[] = { /* word 81 value: */
- "Device does not report version", /* 0x0000 */
- "ATA-1 X3T9.2 781D prior to revision 4", /* 0x0001 */
- "ATA-1 published, ANSI X3.221-1994", /* 0x0002 */
- "ATA-1 X3T9.2 781D revision 4", /* 0x0003 */
- "ATA-2 published, ANSI X3.279-1996", /* 0x0004 */
- "ATA-2 X3T10 948D prior to revision 2k", /* 0x0005 */
- "ATA-3 X3T10 2008D revision 1", /* 0x0006 */ /* SMART NOT INCLUDED */
- "ATA-2 X3T10 948D revision 2k", /* 0x0007 */
- "ATA-3 X3T10 2008D revision 0", /* 0x0008 */
- "ATA-2 X3T10 948D revision 3", /* 0x0009 */
- "ATA-3 published, ANSI X3.298-199x", /* 0x000a */
- "ATA-3 X3T10 2008D revision 6", /* 0x000b */ /* 1st VERSION WITH SMART */
- "ATA-3 X3T13 2008D revision 7 and 7a", /* 0x000c */
- "ATA/ATAPI-4 X3T13 1153D revision 6", /* 0x000d */
- "ATA/ATAPI-4 T13 1153D revision 13", /* 0x000e */
- "ATA/ATAPI-4 X3T13 1153D revision 7", /* 0x000f */
- "ATA/ATAPI-4 T13 1153D revision 18", /* 0x0010 */
- "ATA/ATAPI-4 T13 1153D revision 15", /* 0x0011 */
- "ATA/ATAPI-4 published, ANSI NCITS 317-1998", /* 0x0012 */
- "ATA/ATAPI-5 T13 1321D revision 3", /* 0x0013 */
- "ATA/ATAPI-4 T13 1153D revision 14", /* 0x0014 */
- "ATA/ATAPI-5 T13 1321D revision 1", /* 0x0015 */
- "ATA/ATAPI-5 published, ANSI NCITS 340-2000", /* 0x0016 */
- "ATA/ATAPI-4 T13 1153D revision 17", /* 0x0017 */
- "ATA/ATAPI-6 T13 1410D revision 0", /* 0x0018 */
- "ATA/ATAPI-6 T13 1410D revision 3a", /* 0x0019 */
- "ATA/ATAPI-7 T13 1532D revision 1", /* 0x001a */
- "ATA/ATAPI-6 T13 1410D revision 2", /* 0x001b */
- "ATA/ATAPI-6 T13 1410D revision 1", /* 0x001c */
- "ATA/ATAPI-7 published, ANSI INCITS 397-2005",/* 0x001d */
- "ATA/ATAPI-7 T13 1532D revision 0", /* 0x001e */
- "reserved", /* 0x001f */
- "reserved", /* 0x0020 */
- "ATA/ATAPI-7 T13 1532D revision 4a", /* 0x0021 */
- "ATA/ATAPI-6 published, ANSI INCITS 361-2002" /* 0x0022 */
-};
-
-// NOTE ATA/ATAPI-4 REV 4 was the LAST revision where the device
-// attribute structures were NOT completely vendor specific. So any
-// disk that is ATA/ATAPI-4 or above can not be trusted to show the
-// vendor values in sensible format.
-
-// Negative values below are because it doesn't support SMART
-static const int actual_ver[] = {
- /* word 81 value: */
- 0, /* 0x0000 WARNING: */
- 1, /* 0x0001 WARNING: */
- 1, /* 0x0002 WARNING: */
- 1, /* 0x0003 WARNING: */
- 2, /* 0x0004 WARNING: This array */
- 2, /* 0x0005 WARNING: corresponds */
- -3, /*<== */ /* 0x0006 WARNING: *exactly* */
- 2, /* 0x0007 WARNING: to the ATA/ */
- -3, /*<== */ /* 0x0008 WARNING: ATAPI version */
- 2, /* 0x0009 WARNING: listed in */
- 3, /* 0x000a WARNING: the */
- 3, /* 0x000b WARNING: minor_str */
- 3, /* 0x000c WARNING: array */
- 4, /* 0x000d WARNING: above. */
- 4, /* 0x000e WARNING: */
- 4, /* 0x000f WARNING: If you change */
- 4, /* 0x0010 WARNING: that one, */
- 4, /* 0x0011 WARNING: change this one */
- 4, /* 0x0012 WARNING: too!!! */
- 5, /* 0x0013 WARNING: */
- 4, /* 0x0014 WARNING: */
- 5, /* 0x0015 WARNING: */
- 5, /* 0x0016 WARNING: */
- 4, /* 0x0017 WARNING: */
- 6, /* 0x0018 WARNING: */
- 6, /* 0x0019 WARNING: */
- 7, /* 0x001a WARNING: */
- 6, /* 0x001b WARNING: */
- 6, /* 0x001c WARNING: */
- 7, /* 0x001d WARNING: */
- 7, /* 0x001e WARNING: */
- 0, /* 0x001f WARNING: */
- 0, /* 0x0020 WARNING: */
- 7, /* 0x0021 WARNING: */
- 6 /* 0x0022 WARNING: */
-};
-
-// Compile time check of above array sizes
-typedef char assert_sizeof_minor_str [sizeof(minor_str) /sizeof(minor_str[0]) == MINOR_MAX+1 ? 1 : -1];
-typedef char assert_sizeof_actual_ver[sizeof(actual_ver)/sizeof(actual_ver[0]) == MINOR_MAX+1 ? 1 : -1];
// Get ID and increase flag of current pending or offline
// uncorrectable attribute.
const unsigned num_format_names = sizeof(format_names)/sizeof(format_names[0]);
// Table to map old to new '-v' option arguments
-const char * map_old_vendor_opts[][2] = {
+const char * const map_old_vendor_opts[][2] = {
{ "9,halfminutes" , "9,halfmin2hour,Power_On_Half_Minutes"},
{ "9,minutes" , "9,min2hour,Power_On_Minutes"},
{ "9,seconds" , "9,sec2hour,Power_On_Seconds"},
{"198,increasing" , "198,raw48+,Total_Offl_Uncorrectabl"}, // '+' sets flag
{"200,writeerrorcount" , "200,raw48,Write_Error_Count"},
{"201,detectedtacount" , "201,raw48,Detected_TA_Count"},
- {"220,temp" , "220,raw48,Temperature_Celsius"},
+ {"220,temp" , "220,tempminmax,Temperature_Celsius"},
};
const unsigned num_old_vendor_opts = sizeof(map_old_vendor_opts)/sizeof(map_old_vendor_opts[0]);
// Parse option
int len = strlen(opt);
int id = 0, n1 = -1, n2 = -1;
- char fmtname[32+1], attrname[32+1];
+ char fmtname[32+1], attrname[32+1], hddssd[3+1];
+ attrname[0] = hddssd[0] = 0;
+
if (opt[0] == 'N') {
- // "N,format"
+ // "N,format[,name]"
if (!( sscanf(opt, "N,%32[^,]%n,%32[^,]%n", fmtname, &n1, attrname, &n2) >= 1
&& (n1 == len || n2 == len)))
return false;
}
else {
- // "id,format[+][,name]"
- if (!( sscanf(opt, "%d,%32[^,]%n,%32[^,]%n", &id, fmtname, &n1, attrname, &n2) >= 2
- && 1 <= id && id <= 255 && (n1 == len || n2 == len)))
+ // "id,format[+][,name[,HDD|SSD]]"
+ int n3 = -1;
+ if (!( sscanf(opt, "%d,%32[^,]%n,%32[^,]%n,%3[DHS]%n",
+ &id, fmtname, &n1, attrname, &n2, hddssd, &n3) >= 2
+ && 1 <= id && id <= 255
+ && ( n1 == len || n2 == len
+ // ",HDD|SSD" for DEFAULT settings only
+ || (n3 == len && priority == PRIOR_DEFAULT))))
return false;
}
- if (n1 == len)
- attrname[0] = 0;
unsigned flags = 0;
// For "-v 19[78],increasing" above
// Split "format[:byteorder]"
char byteorder[8+1] = "";
if (strchr(fmtname, ':')) {
+ if (priority == PRIOR_DEFAULT)
+ // TODO: Allow Byteorder in DEFAULT entry
+ return false;
+ n1 = n2 = -1;
if (!( sscanf(fmtname, "%*[^:]%n:%8[012345rvwz]%n", &n1, byteorder, &n2) >= 1
&& n2 == (int)strlen(fmtname)))
return false;
if (!*byteorder && (format == RAWFMT_RAW64 || format == RAWFMT_HEX64))
flags |= (ATTRFLAG_NO_NORMVAL|ATTRFLAG_NO_WORSTVAL);
+ // ",HDD|SSD" suffix for DEFAULT settings
+ if (hddssd[0]) {
+ if (!strcmp(hddssd, "HDD"))
+ flags |= ATTRFLAG_HDD_ONLY;
+ else if (!strcmp(hddssd, "SSD"))
+ flags |= ATTRFLAG_SSD_ONLY;
+ else
+ return false;
+ }
+
if (!id) {
// "N,format" -> set format for all entries
for (i = 0; i < MAX_ATTRIBUTE_NUM; i++) {
defs[i].priority = priority;
defs[i].raw_format = format;
defs[i].flags = flags;
- strcpy(defs[i].byteorder, byteorder);
+ snprintf(defs[i].byteorder, sizeof(defs[i].byteorder), "%s", byteorder);
}
}
else if (defs[id].priority <= priority) {
defs[id].raw_format = format;
defs[id].priority = priority;
defs[id].flags = flags;
- strcpy(defs[id].byteorder, byteorder);
+ snprintf(defs[id].byteorder, sizeof(defs[id].byteorder), "%s", byteorder);
}
return true;
return s;
}
+
+// Parse firmwarebug def (-F option).
+// Return false on error.
+bool parse_firmwarebug_def(const char * opt, firmwarebug_defs & firmwarebugs)
+{
+ if (!strcmp(opt, "none"))
+ firmwarebugs.set(BUG_NONE);
+ else if (!strcmp(opt, "nologdir"))
+ firmwarebugs.set(BUG_NOLOGDIR);
+ else if (!strcmp(opt, "samsung"))
+ firmwarebugs.set(BUG_SAMSUNG);
+ else if (!strcmp(opt, "samsung2"))
+ firmwarebugs.set(BUG_SAMSUNG2);
+ else if (!strcmp(opt, "samsung3"))
+ firmwarebugs.set(BUG_SAMSUNG3);
+ else if (!strcmp(opt, "xerrorlba"))
+ firmwarebugs.set(BUG_XERRORLBA);
+ else
+ return false;
+ return true;
+}
+
+// Return a string of valid argument words for parse_firmwarebug_def()
+const char * get_valid_firmwarebug_args()
+{
+ return "none, nologdir, samsung, samsung2, samsung3, xerrorlba";
+}
+
+
// swap two bytes. Point to low address
void swap2(char *location){
char tmp=*location;
};
-static const char * preg(const ata_register & r, char * buf)
+static const char * preg(const ata_register & r, char (& buf)[8])
{
if (!r.is_set())
//return "n/a ";
return "....";
- sprintf(buf, "0x%02x", r.val()); return buf;
+ snprintf(buf, sizeof(buf), "0x%02x", r.val());
+ return buf;
}
static void print_regs(const char * prefix, const ata_in_regs & r, const char * suffix = "\n")
{
- char bufs[7][4+1+13];
+ char bufs[7][8];
pout("%s FR=%s, SC=%s, LL=%s, LM=%s, LH=%s, DEV=%s, CMD=%s%s", prefix,
preg(r.features, bufs[0]), preg(r.sector_count, bufs[1]), preg(r.lba_low, bufs[2]),
preg(r.lba_mid, bufs[3]), preg(r.lba_high, bufs[4]), preg(r.device, bufs[5]),
static void print_regs(const char * prefix, const ata_out_regs & r, const char * suffix = "\n")
{
- char bufs[7][4+1+13];
+ char bufs[7][8];
pout("%sERR=%s, SC=%s, LL=%s, LM=%s, LH=%s, DEV=%s, STS=%s%s", prefix,
preg(r.error, bufs[0]), preg(r.sector_count, bufs[1]), preg(r.lba_low, bufs[2]),
preg(r.lba_mid, bufs[3]), preg(r.lba_high, bufs[4]), preg(r.device, bufs[5]),
"probable SAT/USB truncation\n");
}
else if (!out.out_regs.is_set()) {
- pout("SMART STATUS RETURN: incomplete response, ATA output registers missing\n");
- device->set_err(ENOSYS);
+ device->set_err(ENOSYS, "Incomplete response, ATA output registers missing");
retval = -1;
}
else {
// We haven't gotten output that makes sense; print out some debugging info
- pout("Error SMART Status command failed\n");
+ pout("SMART Status command failed\n");
pout("Please get assistance from %s\n", PACKAGE_HOMEPAGE);
pout("Register values returned from SMART Status command are:\n");
print_regs(" ", out.out_regs);
- device->set_err(EIO);
+ device->set_err(ENOSYS, "Invalid ATA output register values");
retval = -1;
}
break;
// If requested, invalidate serial number before any printing is done
if ((command == IDENTIFY || command == PIDENTIFY) && !retval && dont_print_serial_number)
- invalidate_serno((ata_identify_device *)data);
+ invalidate_serno( reinterpret_cast<ata_identify_device *>(data) );
// If reporting is enabled, say what output was produced by the command
if (ata_debugmode) {
if ((smartcommandhandler(device, CHECK_POWER_MODE, 0, (char *)&result)))
return -1;
- if (result!=0 && result!=0x80 && result!=0xff)
- pout("ataCheckPowerMode(): ATA CHECK POWER MODE returned unknown Sector Count Register value %02x\n", result);
-
return (int)result;
}
// capable). The value of the integer helps identify the type of
// Packet device, which is useful so that the user can connect the
// formal device number with whatever object is inside their computer.
-int ata_read_identity(ata_device * device, ata_identify_device * buf, bool fix_swapped_id)
+int ata_read_identity(ata_device * device, ata_identify_device * buf, bool fix_swapped_id,
+ unsigned char * raw_buf /* = 0 */)
{
unsigned short *rawshort=(unsigned short *)buf;
unsigned char *rawbyte =(unsigned char *)buf;
packet = true;
}
- unsigned i;
if (fix_swapped_id) {
// Swap ID strings
+ unsigned i;
for (i = 0; i < sizeof(buf->serial_no)-1; i += 2)
swap2((char *)(buf->serial_no+i));
for (i = 0; i < sizeof(buf->fw_rev)-1; i += 2)
swap2((char *)(buf->model+i));
}
+ // If requested, save raw data before endianness adjustments
+ if (raw_buf)
+ memcpy(raw_buf, buf, sizeof(*buf));
+
#ifndef __NetBSD__
// if machine is big-endian, swap byte order as needed
// NetBSD kernel delivers IDENTIFY data in host byte order
// TODO: Handle NetBSD case in os_netbsd.cpp
if (isbigendian()){
-
// swap various capability words that are needed
+ unsigned i;
for (i=0; i<33; i++)
swap2((char *)(buf->words047_079+i));
-
for (i=80; i<=87; i++)
swap2((char *)(rawshort+i));
-
for (i=0; i<168; i++)
swap2((char *)(buf->words088_255+i));
}
return 0;
}
-// Returns ATA version as an integer, and a pointer to a string
-// describing which revision. Note that Revision 0 of ATA-3 does NOT
-// support SMART. For this one case we return -3 rather than +3 as
-// the version number. See notes above.
-int ataVersionInfo(const char ** description, const ata_identify_device * drive, unsigned short * minor)
-{
- // get major and minor ATA revision numbers
- unsigned short major = drive->major_rev_num;
- *minor=drive->minor_rev_num;
-
- // First check if device has ANY ATA version information in it
- if (major==NOVAL_0 || major==NOVAL_1) {
- *description=NULL;
- return 0; // No info found
- }
-
- // The minor revision number has more information - try there first
- if (*minor && (*minor<=MINOR_MAX)){
- int std = actual_ver[*minor];
- if (std) {
- *description=minor_str[*minor];
- return std;
- }
- }
-
- // Try new ATA-8 ACS minor revision numbers.
- // Table 55 of T13/2015-D Revision 4a (ACS-2), December 9, 2010.
- // (not in actual_ver/minor_str to avoid large sparse tables)
- const char *desc;
- switch (*minor) {
- case 0x0027: desc = "ATA-8-ACS revision 3c"; break;
- case 0x0028: desc = "ATA-8-ACS revision 6"; break;
- case 0x0029: desc = "ATA-8-ACS revision 4"; break;
- case 0x0031: desc = "ACS-2 revision 2"; break;
- case 0x0033: desc = "ATA-8-ACS revision 3e"; break;
- case 0x0039: desc = "ATA-8-ACS revision 4c"; break;
- case 0x0042: desc = "ATA-8-ACS revision 3f"; break;
- case 0x0052: desc = "ATA-8-ACS revision 3b"; break;
- case 0x0107: desc = "ATA-8-ACS revision 2d"; break;
- case 0x0110: desc = "ACS-2 revision 3"; break;
- default: desc = 0; break;
- }
- if (desc) {
- *description = desc;
- return 8;
- }
-
- // HDPARM has a very complicated algorithm from here on. Since SMART only
- // exists on ATA-3 and later standards, let's punt on this. If you don't
- // like it, please fix it. The code's in CVS.
- int i;
- for (i=15; i>0; i--)
- if (major & (0x1<<i))
- break;
-
- *description=NULL;
- if (i==0)
- return 1;
- else
- return i;
-}
-
// Get World Wide Name (WWN) fields.
// Return NAA field or -1 if WWN is unsupported.
// Table 34 of T13/1699-D Revision 6a (ATA8-ACS), September 6, 2008.
return (word108 >> 12);
}
+// Get nominal media rotation rate.
+// Returns: 0 = not reported, 1 = SSD, >1 = HDD rpm, < 0 = -(Unknown value)
+int ata_get_rotation_rate(const ata_identify_device * id)
+{
+ // Table 37 of T13/1699-D (ATA8-ACS) Revision 6a, September 6, 2008
+ // Table A.31 of T13/2161-D (ACS-3) Revision 3b, August 25, 2012
+ unsigned short word217 = id->words088_255[217-88];
+ if (word217 == 0x0000 || word217 == 0xffff)
+ return 0;
+ else if (word217 == 0x0001)
+ return 1;
+ else if (word217 > 0x0400)
+ return word217;
+ else
+ return -(int)word217;
+}
+
// returns 1 if SMART supported, 0 if SMART unsupported, -1 if can't tell
int ataSmartSupport(const ata_identify_device * drive)
{
int ataReadSmartValues(ata_device * device, struct ata_smart_values *data){
if (smartcommandhandler(device, READ_VALUES, 0, (char *)data)){
- pout("Error SMART Values Read failed: %s\n", device->get_errmsg());
return -1;
}
// Reads the Self Test Log (log #6)
int ataReadSelfTestLog (ata_device * device, ata_smart_selftestlog * data,
- unsigned char fix_firmwarebug)
+ firmwarebug_defs firmwarebugs)
{
// get data from device
if (smartcommandhandler(device, READ_LOG, 0x06, (char *)data)){
- pout("Error SMART Error Self-Test Log Read failed: %s\n", device->get_errmsg());
return -1;
}
checksumwarning("SMART Self-Test Log Structure");
// fix firmware bugs in self-test log
- if (fix_firmwarebug == FIX_SAMSUNG)
+ if (firmwarebugs.is_set(BUG_SAMSUNG))
fixsamsungselftestlog(data);
// swap endian order if needed
// get data from device
if (smartcommandhandler(device, READ_LOG, 0x09, (char *)data)){
- pout("Error SMART Read Selective Self-Test Log failed: %s\n", device->get_errmsg());
return -1;
}
swap2((char *)&(data->pendingtime));
}
- if (data->logversion != 1)
- pout("Note: selective self-test log revision number (%d) not 1 implies that no selective self-test has ever been run\n", data->logversion);
-
return 0;
}
struct ata_selective_self_test_log sstlog, *data=&sstlog;
unsigned char *ptr=(unsigned char *)data;
if (ataReadSelectiveSelfTestLog(device, data)) {
+ pout("SMART Read Selective Self-test Log failed: %s\n", device->get_errmsg());
pout("Since Read failed, will not attempt to WRITE Selective Self-test Log\n");
return -1;
}
// Host is NOT allowed to write selective self-test log if a selective
// self-test is in progress.
if (0<data->currentspan && data->currentspan<6 && ((sv->self_test_exec_status)>>4)==15) {
- pout("Error SMART Selective or other Self-Test in progress.\n");
+ pout("SMART Selective or other Self-test in progress\n");
return -4;
}
uint64_t spans = (num_sectors + oldsize-1) / oldsize;
uint64_t newsize = (num_sectors + spans-1) / spans;
uint64_t newstart = num_sectors - newsize, newend = num_sectors - 1;
- pout("Span %d changed from %"PRIu64"-%"PRIu64" (%"PRIu64" sectors)\n",
+ pout("Span %d changed from %" PRIu64 "-%" PRIu64 " (%" PRIu64 " sectors)\n",
i, start, end, oldsize);
- pout(" to %"PRIu64"-%"PRIu64" (%"PRIu64" sectors) (%"PRIu64" spans)\n",
+ pout(" to %" PRIu64 "-%" PRIu64 " (%" PRIu64 " sectors) (%" PRIu64 " spans)\n",
newstart, newend, newsize, spans);
start = newstart; end = newend;
}
end = num_sectors - 1;
}
if (!(start <= end && end < num_sectors)) {
- pout("Invalid selective self-test span %d: %"PRIu64"-%"PRIu64" (%"PRIu64" sectors)\n",
+ pout("Invalid selective self-test span %d: %" PRIu64 "-%" PRIu64 " (%" PRIu64 " sectors)\n",
i, start, end, num_sectors);
return -1;
}
// write new selective self-test log
if (smartcommandhandler(device, WRITE_LOG, 0x09, (char *)data)){
- pout("Error Write Selective Self-Test Log failed: %s\n", device->get_errmsg());
+ pout("Write Selective Self-test Log failed: %s\n", device->get_errmsg());
return -3;
}
// Error Log is #2, and the Extended Comprehensive SMART Error log is
// #3
int ataReadErrorLog (ata_device * device, ata_smart_errorlog *data,
- unsigned char fix_firmwarebug)
+ firmwarebug_defs firmwarebugs)
{
// get data from device
if (smartcommandhandler(device, READ_LOG, 0x01, (char *)data)){
- pout("Error SMART Error Log Read failed: %s\n", device->get_errmsg());
return -1;
}
// Some disks have the byte order reversed in some SMART Summary
// Error log entries
- if (fix_firmwarebug == FIX_SAMSUNG)
+ if (firmwarebugs.is_set(BUG_SAMSUNG))
fixsamsungerrorlog(data);
- else if (fix_firmwarebug == FIX_SAMSUNG2)
+ else if (firmwarebugs.is_set(BUG_SAMSUNG2))
fixsamsungerrorlog2(data);
// swap endian order if needed
return 0;
}
+
+// Fix LBA byte ordering of Extended Comprehensive Error Log
+// if little endian instead of ATA register ordering is provided
+template <class T>
+static inline void fix_exterrlog_lba_cmd(T & cmd)
+{
+ T org = cmd;
+ cmd.lba_mid_register_hi = org.lba_high_register;
+ cmd.lba_low_register_hi = org.lba_mid_register_hi;
+ cmd.lba_high_register = org.lba_mid_register;
+ cmd.lba_mid_register = org.lba_low_register_hi;
+}
+
+static void fix_exterrlog_lba(ata_smart_exterrlog * log, unsigned nsectors)
+{
+ for (unsigned i = 0; i < nsectors; i++) {
+ for (int ei = 0; ei < 4; ei++) {
+ ata_smart_exterrlog_error_log & entry = log[i].error_logs[ei];
+ fix_exterrlog_lba_cmd(entry.error);
+ for (int ci = 0; ci < 5; ci++)
+ fix_exterrlog_lba_cmd(entry.commands[ci]);
+ }
+ }
+}
+
// Read Extended Comprehensive Error Log
bool ataReadExtErrorLog(ata_device * device, ata_smart_exterrlog * log,
- unsigned nsectors)
+ unsigned page, unsigned nsectors, firmwarebug_defs firmwarebugs)
{
- if (!ataReadLogExt(device, 0x03, 0x00, 0, log, nsectors))
+ if (!ataReadLogExt(device, 0x03, 0x00, page, log, nsectors))
return false;
check_multi_sector_sum(log, nsectors, "SMART Extended Comprehensive Error Log Structure");
if (isbigendian()) {
swapx(&log->device_error_count);
swapx(&log->error_log_index);
-
for (unsigned i = 0; i < nsectors; i++) {
- for (unsigned j = 0; j < 4; j++)
- swapx(&log->error_logs[i].commands[j].timestamp);
- swapx(&log->error_logs[i].error.timestamp);
+ for (unsigned j = 0; j < 4; j++) {
+ for (unsigned k = 0; k < 5; k++)
+ swapx(&log[i].error_logs[j].commands[k].timestamp);
+ swapx(&log[i].error_logs[j].error.timestamp);
+ }
}
}
+ if (firmwarebugs.is_set(BUG_XERRORLBA))
+ fix_exterrlog_lba(log, nsectors);
+
return true;
}
// get data from device
if (smartcommandhandler(device, READ_THRESHOLDS, 0, (char *)data)){
- pout("Error SMART Thresholds Read failed: %s\n", device->get_errmsg());
return -1;
}
int ataEnableSmart (ata_device * device ){
if (smartcommandhandler(device, ENABLE, 0, NULL)){
- pout("Error SMART Enable failed: %s\n", device->get_errmsg());
return -1;
}
return 0;
int ataDisableSmart (ata_device * device ){
if (smartcommandhandler(device, DISABLE, 0, NULL)){
- pout("Error SMART Disable failed: %s\n", device->get_errmsg());
return -1;
}
return 0;
int ataEnableAutoSave(ata_device * device){
if (smartcommandhandler(device, AUTOSAVE, 241, NULL)){
- pout("Error SMART Enable Auto-save failed: %s\n", device->get_errmsg());
return -1;
}
return 0;
int ataDisableAutoSave(ata_device * device){
if (smartcommandhandler(device, AUTOSAVE, 0, NULL)){
- pout("Error SMART Disable Auto-save failed: %s\n", device->get_errmsg());
return -1;
}
return 0;
/* timer hard coded to 4 hours */
if (smartcommandhandler(device, AUTO_OFFLINE, 248, NULL)){
- pout("Error SMART Enable Automatic Offline failed: %s\n", device->get_errmsg());
return -1;
}
return 0;
int ataDisableAutoOffline (ata_device * device){
if (smartcommandhandler(device, AUTO_OFFLINE, 0, NULL)){
- pout("Error SMART Disable Automatic Offline failed: %s\n", device->get_errmsg());
return -1;
}
return 0;
// Print ouf message that we are sending the command to test
if (testtype==ABORT_SELF_TEST)
- sprintf(cmdmsg,"Abort SMART off-line mode self-test routine");
+ snprintf(cmdmsg, sizeof(cmdmsg), "Abort SMART off-line mode self-test routine");
else if (!type)
- sprintf(cmdmsg, "SMART EXECUTE OFF-LINE IMMEDIATE subcommand 0x%02x", testtype);
+ snprintf(cmdmsg, sizeof(cmdmsg), "SMART EXECUTE OFF-LINE IMMEDIATE subcommand 0x%02x", testtype);
else
- sprintf(cmdmsg,"Execute SMART %s routine immediately in %s mode",type,captive);
+ snprintf(cmdmsg, sizeof(cmdmsg), "Execute SMART %s routine immediately in %s mode", type, captive);
pout("Sending command: \"%s\".\n",cmdmsg);
if (select) {
int i;
pout("SPAN STARTING_LBA ENDING_LBA\n");
for (i = 0; i < selargs_io.num_spans; i++)
- pout(" %d %20"PRId64" %20"PRId64"\n", i,
+ pout(" %d %20" PRId64 " %20" PRId64 "\n", i,
selargs_io.span[i].start,
selargs_io.span[i].end);
}
return ATTRSTATE_OK;
}
-// Get default raw value print format
-static ata_attr_raw_format get_default_raw_format(unsigned char id)
-{
- switch (id) {
- case 3: // Spin-up time
- return RAWFMT_RAW16_OPT_AVG16;
-
- case 5: // Reallocated sector count
- case 196: // Reallocated event count
- return RAWFMT_RAW16_OPT_RAW16;
-
- case 9: // Power on hours
- return RAWFMT_RAW24_OPT_RAW8;
-
- case 190: // Temperature
- case 194:
- return RAWFMT_TEMPMINMAX;
-
- default:
- return RAWFMT_RAW48;
- }
-}
-
// Get attribute raw value.
uint64_t ata_get_attr_raw_value(const ata_smart_attribute & attr,
const ata_vendor_attr_defs & defs)
{
const ata_vendor_attr_defs::entry & def = defs[attr.id];
+ // TODO: Allow Byteorder in DEFAULT entry
// Use default byteorder if not specified
const char * byteorder = def.byteorder;
return rawvalue;
}
+// Helper functions for RAWFMT_TEMPMINMAX
+static inline int check_temp_word(unsigned word)
+{
+ if (word <= 0x7f)
+ return 0x11; // >= 0, signed byte or word
+ if (word <= 0xff)
+ return 0x01; // < 0, signed byte
+ if (0xff80 <= word)
+ return 0x10; // < 0, signed word
+ return 0x00;
+}
+
+static bool check_temp_range(int t, unsigned char ut1, unsigned char ut2,
+ int & lo, int & hi)
+{
+ int t1 = (signed char)ut1, t2 = (signed char)ut2;
+ if (t1 > t2) {
+ int tx = t1; t1 = t2; t2 = tx;
+ }
+
+ if ( -60 <= t1 && t1 <= t && t <= t2 && t2 <= 120
+ && !(t1 == -1 && t2 <= 0) ) {
+ lo = t1; hi = t2;
+ return true;
+ }
+ return false;
+}
// Format attribute raw value.
std::string ata_format_attr_raw_value(const ata_smart_attribute & attr,
// Get print format
ata_attr_raw_format format = defs[attr.id].raw_format;
- if (format == RAWFMT_DEFAULT)
- format = get_default_raw_format(attr.id);
+ if (format == RAWFMT_DEFAULT) {
+ // Get format from DEFAULT entry
+ format = get_default_attr_defs()[attr.id].raw_format;
+ if (format == RAWFMT_DEFAULT)
+ // Unknown Attribute
+ format = RAWFMT_RAW48;
+ }
// Print
std::string s;
case RAWFMT_RAW48:
case RAWFMT_RAW56:
case RAWFMT_RAW64:
- s = strprintf("%"PRIu64, rawvalue);
+ s = strprintf("%" PRIu64, rawvalue);
break;
case RAWFMT_HEX48:
- s = strprintf("0x%012"PRIx64, rawvalue);
+ s = strprintf("0x%012" PRIx64, rawvalue);
break;
case RAWFMT_HEX56:
- s = strprintf("0x%014"PRIx64, rawvalue);
+ s = strprintf("0x%014" PRIx64, rawvalue);
break;
case RAWFMT_HEX64:
- s = strprintf("0x%016"PRIx64, rawvalue);
+ s = strprintf("0x%016" PRIx64, rawvalue);
break;
case RAWFMT_RAW16_OPT_RAW16:
int64_t temp = word[0]+(word[1]<<16);
int64_t tmp1 = temp/60;
int64_t tmp2 = temp%60;
- s = strprintf("%"PRIu64"h+%02"PRIu64"m", tmp1, tmp2);
+ s = strprintf("%" PRIu64 "h+%02" PRIu64 "m", tmp1, tmp2);
if (word[2])
s += strprintf(" (%u)", word[2]);
}
int64_t hours = rawvalue/3600;
int64_t minutes = (rawvalue-3600*hours)/60;
int64_t seconds = rawvalue%60;
- s = strprintf("%"PRIu64"h+%02"PRIu64"m+%02"PRIu64"s", hours, minutes, seconds);
+ s = strprintf("%" PRIu64 "h+%02" PRIu64 "m+%02" PRIu64 "s", hours, minutes, seconds);
}
break;
// 30-second counter
int64_t hours = rawvalue/120;
int64_t minutes = (rawvalue-120*hours)/2;
- s += strprintf("%"PRIu64"h+%02"PRIu64"m", hours, minutes);
+ s += strprintf("%" PRIu64 "h+%02" PRIu64 "m", hours, minutes);
}
break;
// Temperature
{
// Search for possible min/max values
- // 00 HH 00 LL 00 TT (Hitachi/IBM)
- // 00 00 HH LL 00 TT (Maxtor, Samsung)
+ // [5][4][3][2][1][0] raw[]
+ // [ 2 ] [ 1 ] [ 0 ] word[]
+ // xx HH xx LL xx TT (Hitachi/HGST)
+ // xx LL xx HH xx TT (Kingston SSDs)
+ // 00 00 HH LL xx TT (Maxtor, Samsung, Seagate, Toshiba)
// 00 00 00 HH LL TT (WDC)
- unsigned char lo = 0, hi = 0;
- int cnt = 0;
- for (int i = 1; i < 6; i++) {
- if (raw[i])
- switch (cnt++) {
- case 0:
- lo = raw[i];
- break;
- case 1:
- if (raw[i] < lo) {
- hi = lo; lo = raw[i];
- }
- else
- hi = raw[i];
- break;
- }
+ // CC CC HH LL xx TT (WDC, CCCC=over temperature count)
+ // (xx = 00/ff, possibly sign extension of lower byte)
+
+ int t = (signed char)raw[0];
+ int lo = 0, hi = 0;
+
+ int tformat;
+ int ctw0 = check_temp_word(word[0]);
+ if (!word[2]) {
+ if (!word[1] && ctw0)
+ // 00 00 00 00 xx TT
+ tformat = 0;
+ else if (ctw0 && check_temp_range(t, raw[2], raw[3], lo, hi))
+ // 00 00 HL LH xx TT
+ tformat = 1;
+ else if (!raw[3] && check_temp_range(t, raw[1], raw[2], lo, hi))
+ // 00 00 00 HL LH TT
+ tformat = 2;
+ else
+ tformat = -1;
+ }
+ else if (ctw0) {
+ if ( (ctw0 & check_temp_word(word[1]) & check_temp_word(word[2])) != 0x00
+ && check_temp_range(t, raw[2], raw[4], lo, hi) )
+ // xx HL xx LH xx TT
+ tformat = 3;
+ else if ( word[2] < 0x7fff
+ && check_temp_range(t, raw[2], raw[3], lo, hi)
+ && hi >= 40 )
+ // CC CC HL LH xx TT
+ tformat = 4;
+ else
+ tformat = -2;
}
-
- unsigned char t = raw[0];
- if (cnt == 0)
- s = strprintf("%d", t);
- else if (cnt == 2 && 0 < lo && lo <= t && t <= hi && hi < 128)
- s = strprintf("%d (Min/Max %d/%d)", t, lo, hi);
else
- s = strprintf("%d (%d %d %d %d %d)", t, raw[5], raw[4], raw[3], raw[2], raw[1]);
+ tformat = -3;
+
+ switch (tformat) {
+ case 0:
+ s = strprintf("%d", t);
+ break;
+ case 1: case 2: case 3:
+ s = strprintf("%d (Min/Max %d/%d)", t, lo, hi);
+ break;
+ case 4:
+ s = strprintf("%d (Min/Max %d/%d #%d)", t, lo, hi, word[2]);
+ break;
+ default:
+ s = strprintf("%d (%d %d %d %d %d)", raw[0], raw[5], raw[4], raw[3], raw[2], raw[1]);
+ break;
+ }
}
break;
return s;
}
-// Attribute names shouldn't be longer than 23 chars, otherwise they break the
-// output of smartctl.
-static const char * get_default_attr_name(unsigned char id)
-{
- switch (id) {
- case 1:
- return "Raw_Read_Error_Rate";
- case 2:
- return "Throughput_Performance";
- case 3:
- return "Spin_Up_Time";
- case 4:
- return "Start_Stop_Count";
- case 5:
- return "Reallocated_Sector_Ct";
- case 6:
- return "Read_Channel_Margin";
- case 7:
- return "Seek_Error_Rate";
- case 8:
- return "Seek_Time_Performance";
- case 9:
- return "Power_On_Hours";
- case 10:
- return "Spin_Retry_Count";
- case 11:
- return "Calibration_Retry_Count";
- case 12:
- return "Power_Cycle_Count";
- case 13:
- return "Read_Soft_Error_Rate";
- case 175:
- return "Program_Fail_Count_Chip";
- case 176:
- return "Erase_Fail_Count_Chip";
- case 177:
- return "Wear_Leveling_Count";
- case 178:
- return "Used_Rsvd_Blk_Cnt_Chip";
- case 179:
- return "Used_Rsvd_Blk_Cnt_Tot";
- case 180:
- return "Unused_Rsvd_Blk_Cnt_Tot";
- case 181:
- return "Program_Fail_Cnt_Total";
- case 182:
- return "Erase_Fail_Count_Total";
- case 183:
- return "Runtime_Bad_Block";
- case 184:
- return "End-to-End_Error";
- case 187:
- return "Reported_Uncorrect";
- case 188:
- return "Command_Timeout";
- case 189:
- return "High_Fly_Writes";
- case 190:
- // Western Digital uses this for temperature.
- // It's identical to Attribute 194 except that it
- // has a failure threshold set to correspond to the
- // max allowed operating temperature of the drive, which
- // is typically 55C. So if this attribute has failed
- // in the past, it indicates that the drive temp exceeded
- // 55C sometime in the past.
- return "Airflow_Temperature_Cel";
- case 191:
- return "G-Sense_Error_Rate";
- case 192:
- return "Power-Off_Retract_Count";
- case 193:
- return "Load_Cycle_Count";
- case 194:
- return "Temperature_Celsius";
- case 195:
- // Fujitsu: "ECC_On_The_Fly_Count";
- return "Hardware_ECC_Recovered";
- case 196:
- return "Reallocated_Event_Count";
- case 197:
- return "Current_Pending_Sector";
- case 198:
- return "Offline_Uncorrectable";
- case 199:
- return "UDMA_CRC_Error_Count";
- case 200:
- // Western Digital
- return "Multi_Zone_Error_Rate";
- case 201:
- return "Soft_Read_Error_Rate";
- case 202:
- // Fujitsu: "TA_Increase_Count"
- return "Data_Address_Mark_Errs";
- case 203:
- // Fujitsu
- return "Run_Out_Cancel";
- // Maxtor: ECC Errors
- case 204:
- // Fujitsu: "Shock_Count_Write_Opern"
- return "Soft_ECC_Correction";
- case 205:
- // Fujitsu: "Shock_Rate_Write_Opern"
- return "Thermal_Asperity_Rate";
- case 206:
- // Fujitsu
- return "Flying_Height";
- case 207:
- // Maxtor
- return "Spin_High_Current";
- case 208:
- // Maxtor
- return "Spin_Buzz";
- case 209:
- // Maxtor
- return "Offline_Seek_Performnce";
- case 220:
- return "Disk_Shift";
- case 221:
- return "G-Sense_Error_Rate";
- case 222:
- return "Loaded_Hours";
- case 223:
- return "Load_Retry_Count";
- case 224:
- return "Load_Friction";
- case 225:
- return "Load_Cycle_Count";
- case 226:
- return "Load-in_Time";
- case 227:
- return "Torq-amp_Count";
- case 228:
- return "Power-off_Retract_Count";
- case 230:
- // seen in IBM DTPA-353750
- return "Head_Amplitude";
- case 231:
- return "Temperature_Celsius";
- case 232:
- // seen in Intel X25-E SSD
- return "Available_Reservd_Space";
- case 233:
- // seen in Intel X25-E SSD
- return "Media_Wearout_Indicator";
- case 240:
- return "Head_Flying_Hours";
- case 241:
- return "Total_LBAs_Written";
- case 242:
- return "Total_LBAs_Read";
- case 250:
- return "Read_Error_Retry_Rate";
- case 254:
- return "Free_Fall_Sensor";
- default:
- return "Unknown_Attribute";
- }
-}
-
// Get attribute name
-std::string ata_get_smart_attr_name(unsigned char id, const ata_vendor_attr_defs & defs)
+std::string ata_get_smart_attr_name(unsigned char id, const ata_vendor_attr_defs & defs,
+ int rpm /* = 0 */)
{
if (!defs[id].name.empty())
return defs[id].name;
- else
- return get_default_attr_name(id);
+ else {
+ const ata_vendor_attr_defs::entry & def = get_default_attr_defs()[id];
+ if (def.name.empty())
+ return "Unknown_Attribute";
+ else if ((def.flags & ATTRFLAG_HDD_ONLY) && rpm == 1)
+ return "Unknown_SSD_Attribute";
+ else if ((def.flags & ATTRFLAG_SSD_ONLY) && rpm > 1)
+ return "Unknown_HDD_Attribute";
+ else
+ return def.name;
+ }
}
// Find attribute index for attribute id, -1 if not found.
// non-default interpretations. If the Attribute does not exist, return 0
unsigned char ata_return_temperature_value(const ata_smart_values * data, const ata_vendor_attr_defs & defs)
{
- for (int i = 0; i < 3; i++) {
- static const unsigned char ids[3] = {194, 9, 220};
+ for (int i = 0; i < 4; i++) {
+ static const unsigned char ids[4] = {194, 190, 9, 220};
unsigned char id = ids[i];
const ata_attr_raw_format format = defs[id].raw_format;
- if (!( (id == 194 && format == RAWFMT_DEFAULT)
+ if (!( ((id == 194 || id == 190) && format == RAWFMT_DEFAULT)
|| format == RAWFMT_TEMPMINMAX || format == RAWFMT_TEMP10X))
continue;
int idx = ata_find_attr_index(id, *data);
// read SCT status via SMART log 0xe0
memset(sts, 0, sizeof(*sts));
if (smartcommandhandler(device, READ_LOG, 0xe0, (char *)sts)){
- pout("Error Read SCT Status failed: %s\n", device->get_errmsg());
+ pout("Read SCT Status failed: %s\n", device->get_errmsg());
return -1;
}
swapx(&sts->function_code);
swapx(&sts->over_limit_count);
swapx(&sts->under_limit_count);
+ swapx(&sts->smart_status);
}
// Check format version
if (!(sts->format_version == 2 || sts->format_version == 3)) {
- pout("Error unknown SCT Status format version %u, should be 2 or 3.\n", sts->format_version);
+ pout("Unknown SCT Status format version %u, should be 2 or 3.\n", sts->format_version);
return -1;
}
return 0;
}
-// Read SCT Temperature History Table and Status
+// Read SCT Temperature History Table
int ataReadSCTTempHist(ata_device * device, ata_sct_temperature_history_table * tmh,
ata_sct_status_response * sts)
{
- // Check initial status
- if (ataReadSCTStatus(device, sts))
- return -1;
+ // Initial SCT status must be provided by caller
// Do nothing if other SCT command is executing
if (sts->ext_status_code == 0xffff) {
// write command via SMART log page 0xe0
if (smartcommandhandler(device, WRITE_LOG, 0xe0, (char *)&cmd)){
- pout("Error Write SCT Data Table command failed: %s\n", device->get_errmsg());
+ pout("Write SCT Data Table failed: %s\n", device->get_errmsg());
return -1;
}
// read SCT data via SMART log page 0xe1
memset(tmh, 0, sizeof(*tmh));
if (smartcommandhandler(device, READ_LOG, 0xe1, (char *)tmh)){
- pout("Error Read SCT Data Table failed: %s\n", device->get_errmsg());
+ pout("Read SCT Data Table failed: %s\n", device->get_errmsg());
return -1;
}
return -1;
if (!(sts->ext_status_code == 0 && sts->action_code == 5 && sts->function_code == 1)) {
- pout("Error unexpected SCT status 0x%04x (action_code=%u, function_code=%u)\n",
+ pout("Unexpected SCT status 0x%04x (action_code=%u, function_code=%u)\n",
sts->ext_status_code, sts->action_code, sts->function_code);
return -1;
}
swapx(&tmh->format_version);
swapx(&tmh->sampling_period);
swapx(&tmh->interval);
+ swapx(&tmh->cb_index);
+ swapx(&tmh->cb_size);
}
+ return 0;
+}
- // Check format version
- if (tmh->format_version != 2) {
- pout("Error unknown SCT Temperature History Format Version (%u), should be 2.\n", tmh->format_version);
+// Get/Set Write Cache Reordering
+int ataGetSetSCTWriteCacheReordering(ata_device * device, bool enable, bool persistent, bool set)
+{
+ // Check initial status
+ ata_sct_status_response sts;
+ if (ataReadSCTStatus(device, &sts))
+ return -1;
+
+ // Do nothing if other SCT command is executing
+ if (sts.ext_status_code == 0xffff) {
+ pout("Another SCT command is executing, abort Feature Control\n"
+ "(SCT ext_status_code 0x%04x, action_code=%u, function_code=%u)\n",
+ sts.ext_status_code, sts.action_code, sts.function_code);
return -1;
}
- return 0;
+
+ ata_sct_feature_control_command cmd; memset(&cmd, 0, sizeof(cmd));
+ // CAUTION: DO NOT CHANGE THIS VALUE (SOME ACTION CODES MAY ERASE DISK)
+ cmd.action_code = 4; // Feature Control command
+ cmd.function_code = (set ? 1 : 2); // 1=Set, 2=Get
+ cmd.feature_code = 2; // Enable/Disable Write Cache Reordering
+ cmd.state = (enable ? 1 : 2); // 1 enable, 2 disable
+ cmd.option_flags = (persistent ? 0x01 : 0x00);
+
+ // swap endian order if needed
+ if (isbigendian()) {
+ swapx(&cmd.action_code);
+ swapx(&cmd.function_code);
+ swapx(&cmd.feature_code);
+ swapx(&cmd.state);
+ swapx(&cmd.option_flags);
+ }
+
+ // write command via SMART log page 0xe0
+ // TODO: Debug output
+ ata_cmd_in in;
+ in.in_regs.command = ATA_SMART_CMD;
+ in.in_regs.lba_high = SMART_CYL_HI; in.in_regs.lba_mid = SMART_CYL_LOW;
+ in.in_regs.features = ATA_SMART_WRITE_LOG_SECTOR;
+ in.in_regs.lba_low = 0xe0;
+ in.set_data_out(&cmd, 1);
+
+ if (!set)
+ // Time limit returned in ATA registers
+ in.out_needed.sector_count = in.out_needed.lba_low = true;
+
+ ata_cmd_out out;
+ if (!device->ata_pass_through(in, out)) {
+ pout("Write SCT (%cet) Feature Control Command failed: %s\n",
+ (!set ? 'G' : 'S'), device->get_errmsg());
+ return -1;
+ }
+ int state = out.out_regs.sector_count | (out.out_regs.lba_low << 8);
+
+ // re-read and check SCT status
+ if (ataReadSCTStatus(device, &sts))
+ return -1;
+
+ if (!(sts.ext_status_code == 0 && sts.action_code == 4 && sts.function_code == (set ? 1 : 2))) {
+ pout("Unexpected SCT status 0x%04x (action_code=%u, function_code=%u)\n",
+ sts.ext_status_code, sts.action_code, sts.function_code);
+ return -1;
+ }
+ return state;
}
+
// Set SCT Temperature Logging Interval
int ataSetSCTTempInterval(ata_device * device, unsigned interval, bool persistent)
{
// write command via SMART log page 0xe0
if (smartcommandhandler(device, WRITE_LOG, 0xe0, (char *)&cmd)){
- pout("Error Write SCT Feature Control Command failed: %s\n", device->get_errmsg());
+ pout("Write SCT Feature Control Command failed: %s\n", device->get_errmsg());
return -1;
}
return -1;
if (!(sts.ext_status_code == 0 && sts.action_code == 4 && sts.function_code == 1)) {
- pout("Error unexcepted SCT status 0x%04x (action_code=%u, function_code=%u)\n",
+ pout("Unexpected SCT status 0x%04x (action_code=%u, function_code=%u)\n",
sts.ext_status_code, sts.action_code, sts.function_code);
return -1;
}
ata_cmd_out out;
if (!device->ata_pass_through(in, out)) {
- pout("Error Write SCT (%cet) Error Recovery Control Command failed: %s\n",
+ pout("Write SCT (%cet) Error Recovery Control Command failed: %s\n",
(!set ? 'G' : 'S'), device->get_errmsg());
return -1;
}
return -1;
if (!(sts.ext_status_code == 0 && sts.action_code == 3 && sts.function_code == (set ? 1 : 2))) {
- pout("Error unexcepted SCT status 0x%04x (action_code=%u, function_code=%u)\n",
+ pout("Unexpected SCT status 0x%04x (action_code=%u, function_code=%u)\n",
sts.ext_status_code, sts.action_code, sts.function_code);
return -1;
}
if (!(out.out_regs.sector_count.is_set() && out.out_regs.lba_low.is_set())) {
// TODO: Output register support should be checked within each ata_pass_through()
// implementation before command is issued.
- pout("Error SMART WRITE LOG does not return COUNT and LBA_LOW register\n");
+ pout("SMART WRITE LOG does not return COUNT and LBA_LOW register\n");
+ return -1;
+ }
+ if ( out.out_regs.sector_count == in.in_regs.sector_count
+ && out.out_regs.lba_low == in.in_regs.lba_low ) {
+ // 0xe001 (5734.5s) - this is most likely a broken ATA pass-through implementation
+ pout("SMART WRITE LOG returns COUNT and LBA_LOW register unchanged\n");
return -1;
}
+
// Return value to caller
time_limit = out.out_regs.sector_count | (out.out_regs.lba_low << 8);
}
char msglba[32];
if (retval < 0 && failing_lba < 0xffffffffffffULL)
- snprintf(msglba, sizeof(msglba), "%"PRIu64, failing_lba);
- else
- strcpy(msglba, "-");
+ snprintf(msglba, sizeof(msglba), "%" PRIu64, failing_lba);
+ else {
+ msglba[0] = '-'; msglba[1] = 0;
+ }
pout("#%2u %-19s %-29s %1d0%% %8u %s\n", testnum,
msgtest.c_str(), msgstat.c_str(), test_status & 0x0f, timestamp, msglba);
// bottom 8 bits: number of entries found where self-test showed an error
// remaining bits: if nonzero, power on hours of last self-test where error was found
int ataPrintSmartSelfTestlog(const ata_smart_selftestlog * data, bool allentries,
- unsigned char fix_firmwarebug)
+ firmwarebug_defs firmwarebugs)
{
if (allentries)
pout("SMART Self-test log structure revision number %d\n",(int)data->revnumber);
- if ((data->revnumber!=0x0001) && allentries && fix_firmwarebug != FIX_SAMSUNG)
+ if (data->revnumber != 0x0001 && allentries && !firmwarebugs.is_set(BUG_SAMSUNG))
pout("Warning: ATA Specification requires self-test log structure revision number = 1\n");
if (data->mostrecenttest==0){
if (allentries)
- pout("No self-tests have been logged. [To run self-tests, use: smartctl -t]\n\n");
+ pout("No self-tests have been logged. [To run self-tests, use: smartctl -t]\n");
return 0;
}
projects / mirror_smartmontools-debian.git / blobdiff