serial: mxs-auart: Fix out-of-bounds access through serial port index

BugLink: http://bugs.launchpad.net/bugs/1783418
[ Upstream commit dd345a31bfdec350d2593e6de5964e55c7f19c76 ]

The auart_port[] array is indexed using a value derived from the
"serialN" alias in DT, or from platform data, which may lead to an
out-of-bounds access.

Fix this by adding a range check.

Fixes: 1ea6607d4cdc9179 ("serial: mxs-auart: Allow device tree probing")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>

diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index efb4fd3784ed75c1c86948f2e387b2960a22bf68..4fefec8700b9d3cb8f4eda3c767b98858f3fbf96 100644 (file)
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -1664,6 +1664,10 @@ static int mxs_auart_probe(struct platform_device *pdev)
                s->port.line = pdev->id < 0 ? 0 : pdev->id;
        else if (ret < 0)
                return ret;
+       if (s->port.line >= ARRAY_SIZE(auart_port)) {
+               dev_err(&pdev->dev, "serial%d out of range\n", s->port.line);
+               return -EINVAL;
+       }
 
        if (of_id) {
                pdev->id_entry = of_id->data;