]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
scsi: ips: fix missing break in switch
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 16 Oct 2018 09:12:23 +0000 (11:12 +0200)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:20:48 +0000 (14:20 -0300)
BugLink: https://bugs.launchpad.net/bugs/1854975
[ Upstream commit 5d25ff7a544889bc4b749fda31778d6a18dddbcb ]

Add missing break statement in order to prevent the code from falling
through to case TEST_UNIT_READY.

Addresses-Coverity-ID: 1357338 ("Missing break in switch")
Suggested-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/scsi/ips.c

index 67621308eb9caf3d28b0b47e35749316d30ed416..ea652f1e2071e6014aa14737f50c63b1b1d1127d 100644 (file)
@@ -3497,6 +3497,7 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * scb)
 
                case START_STOP:
                        scb->scsi_cmd->result = DID_OK << 16;
+                       break;
 
                case TEST_UNIT_READY:
                case INQUIRY: