]> git.proxmox.com Git - mirror_zfs.git/commitdiff
ZTS: random_readwrite test doesn't run correctly
authorJohn Wren Kennedy <john.kennedy@delphix.com>
Thu, 10 Nov 2022 22:00:04 +0000 (15:00 -0700)
committerGitHub <noreply@github.com>
Thu, 10 Nov 2022 22:00:04 +0000 (14:00 -0800)
This test uses fio's bssplit mechanism to choose io sizes for the test,
leaving the PERF_IOSIZES variable empty. Because that variable is
empty, the innermost loop in do_fio_run_impl is never executed, and as
a result, this test does the setup but collects no data. Setting the
variable to "bssplit" allows performance data to be gathered.

Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: John Wren Kennedy <john.kennedy@delphix.com>
Closes #14163

tests/zfs-tests/tests/perf/regression/random_readwrite.ksh

index 3a358774f565c401efdf44acdeacc6fc322988c9..e0626c0b42f3ab9fbaf21b271d45ce8bc4c5d8a3 100755 (executable)
@@ -60,7 +60,7 @@ export TOTAL_SIZE=$(($(get_prop avail $PERFPOOL) * 3 / 2))
 # Variables specific to this test for use by fio.
 export PERF_NTHREADS=${PERF_NTHREADS:-'32 64'}
 export PERF_NTHREADS_PER_FS=${PERF_NTHREADS_PER_FS:-'0'}
-export PERF_IOSIZES=''         # bssplit used instead
+export PERF_IOSIZES='bssplit'          # bssplit used instead of fixed sizes
 export PERF_SYNC_TYPES=${PERF_SYNC_TYPES:-'1'}
 
 # Layout the files to be used by the readwrite tests. Create as many files