GitHub Actions is transitioning from Node 16 to Node 20.
So we need to update these:
- actions/checkout@v3 -> v4
- actions/download-artifact@v3 -> v4
- actions/upload-artifact@v3 -> v4 and some minor changes
Update also the documentation of the testings workflow.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Andrew Innes <andrew.c12@gmail.com>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes #15820
```mermaid
flowchart TB
subgraph CleanUp and Summary
- Part1-20.04-->CleanUp+nice+Summary
- Part2-20.04-->CleanUp+nice+Summary
- PartN-20.04-->CleanUp+nice+Summary
- Part1-22.04-->CleanUp+nice+Summary
- Part2-22.04-->CleanUp+nice+Summary
- PartN-22.04-->CleanUp+nice+Summary
+ sanity-checks-20.04-->CleanUp+Summary
+ Part1-20.04-->CleanUp+Summary
+ Part2-20.04-->CleanUp+Summary
+ Part3-20.04-->CleanUp+Summary
+ Part4-20.04-->CleanUp+Summary
+ Part1-22.04-->CleanUp+Summary
+ Part2-22.04-->CleanUp+Summary
+ Part3-22.04-->CleanUp+Summary
+ Part4-22.04-->CleanUp+Summary
+ sanity-checks-22.04-->CleanUp+Summary
end
subgraph Functional Testings
+ sanity-checks-20.04
+ zloop-checks-20.04
functional-testing-20.04-->Part1-20.04
functional-testing-20.04-->Part2-20.04
- functional-testing-20.04-->PartN-20.04
+ functional-testing-20.04-->Part3-20.04
+ functional-testing-20.04-->Part4-20.04
functional-testing-22.04-->Part1-22.04
functional-testing-22.04-->Part2-22.04
- functional-testing-22.04-->PartN-22.04
-end
-
-subgraph Sanity and zloop Testings
- sanity-checks-20.04-->functional-testing-20.04
- sanity-checks-22.04-->functional-testing-22.04
- zloop-checks-20.04-->functional
- zloop-checks-22.04-->functional
+ functional-testing-22.04-->Part3-22.04
+ functional-testing-22.04-->Part4-22.04
+ sanity-checks-22.04
+ zloop-checks-22.04
end
subgraph Code Checking + Building
+ Build-Ubuntu-20.04-->sanity-checks-20.04
+ Build-Ubuntu-20.04-->zloop-checks-20.04
+ Build-Ubuntu-20.04-->functional-testing-20.04
codeql.yml
checkstyle.yml
- Build-Ubuntu-20.04-->sanity-checks-20.04
Build-Ubuntu-22.04-->sanity-checks-22.04
- Build-Ubuntu-20.04-->zloop-checks-20.04
Build-Ubuntu-22.04-->zloop-checks-22.04
+ Build-Ubuntu-22.04-->functional-testing-22.04
end
```
1) build zfs modules for Ubuntu 20.04 and 22.04 (~15m)
2) 2x zloop test (~10m) + 2x sanity test (~25m)
-3) functional testings in parts 1..5 (each ~1h)
+3) 4x functional testings in parts 1..4 (each ~1h)
4) cleanup and create summary
- content of summary depends on the results of the steps
checkstyle:
runs-on: ubuntu-22.04
steps:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Install dependencies
if: failure() && steps.CheckABI.outcome == 'failure'
run: |
find -name *.abi | tar -cf abi_files.tar -T -
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
if: failure() && steps.CheckABI.outcome == 'failure'
with:
name: New ABI files (use only if you're sure about interface changes)
echo "MAKEFLAGS=-j$(nproc)" >> $GITHUB_ENV
- name: Checkout repository
- uses: actions/checkout@v3
+ uses: actions/checkout@v4
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
output "\n## $headline\n"
rm -rf testfiles
for i in $(seq 1 $FUNCTIONAL_PARTS); do
- tarfile="$2/part$i.tar"
+ tarfile="$2-part$i/part$i.tar"
check_tarfile "$tarfile"
check_logfile "testfiles/log"
done
zloop:
runs-on: ubuntu-${{ inputs.os }}
steps:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- - uses: actions/download-artifact@v3
+ - uses: actions/download-artifact@v4
with:
name: modules-${{ inputs.os }}
- name: Install modules
if: failure()
run: |
sudo chmod +r -R /var/tmp/zloop/
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
if: failure()
with:
name: Zpool-logs-${{ inputs.os }}
!/var/tmp/zloop/*/vdev/
retention-days: 14
if-no-files-found: ignore
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
if: failure()
with:
name: Zpool-files-${{ inputs.os }}
sanity:
runs-on: ubuntu-${{ inputs.os }}
steps:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- - uses: actions/download-artifact@v3
+ - uses: actions/download-artifact@v4
with:
name: modules-${{ inputs.os }}
- name: Install modules
RESPATH="/var/tmp/test_results"
mv -f $RESPATH/current $RESPATH/testfiles
tar cf $RESPATH/sanity.tar -h -C $RESPATH testfiles
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
if: success() || failure()
with:
name: Logs-${{ inputs.os }}-sanity
matrix:
tests: [ part1, part2, part3, part4 ]
steps:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- - uses: actions/download-artifact@v3
+ - uses: actions/download-artifact@v4
with:
name: modules-${{ inputs.os }}
- name: Install modules
RESPATH="/var/tmp/test_results"
mv -f $RESPATH/current $RESPATH/testfiles
tar cf $RESPATH/${{ matrix.tests }}.tar -h -C $RESPATH testfiles
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
if: success() || failure()
with:
- name: Logs-${{ inputs.os }}-functional
+ name: Logs-${{ inputs.os }}-functional-${{ matrix.tests }}
path: /var/tmp/test_results/${{ matrix.tests }}.tar
if-no-files-found: ignore
os: [20.04, 22.04]
runs-on: ubuntu-${{ matrix.os }}
steps:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Build modules
run: .github/workflows/scripts/setup-dependencies.sh build
- name: Prepare modules upload
run: tar czf modules-${{ matrix.os }}.tgz *.deb .github tests/test-runner tests/ImageOS.txt
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
with:
name: modules-${{ matrix.os }}
path: modules-${{ matrix.os }}.tgz
runs-on: ubuntu-22.04
needs: testings
steps:
- - uses: actions/download-artifact@v3
+ - uses: actions/download-artifact@v4
- name: Generating summary
run: |
tar xzf modules-22.04/modules-22.04.tgz .github tests
run: .github/workflows/scripts/generate-summary.sh 3
- name: Summary for errors #4
run: .github/workflows/scripts/generate-summary.sh 4
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
with:
name: Summary Files
path: Summary/
projects / mirror_zfs.git / commitdiff