]> git.proxmox.com Git - pmg-gui.git/commitdiff
renderer: s/format_size/render_size/
authorThomas Lamprecht <t.lamprecht@proxmox.com>
Mon, 7 Nov 2022 11:42:05 +0000 (12:42 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Mon, 7 Nov 2022 12:16:51 +0000 (13:16 +0100)
format_size is the "lower" level helper and is not fit (anymore) to
be set as renderer directly, as its parameter signature may clash
with the extra, different ones, that renderers get passed.

For example, the useSI param always gets evaluated as true due to
the metaData "truthy" value that calls to a renderer get passed along
most of the time.

Use the render_size instead, a wrapper which only passes along value
to format_size.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
js/AttachmentGrid.js
js/BackupRestore.js
js/PBSSnapshotView.js
js/PostfixMailQueue.js

index aea526ba5003da01ad3d9ede56e8abb4174234fe..eaac638f7fe9e8af30d7a1a90f4b4f6aa23be20c 100644 (file)
@@ -90,7 +90,7 @@ Ext.define('PMG.grid.AttachmentGrid', {
        },
        {
            text: gettext('Size'),
-           renderer: Proxmox.Utils.format_size,
+           renderer: Proxmox.Utils.render_size,
            dataIndex: 'size',
            flex: 1,
        },
index 21a979f390ebe2230f7574fc574b9adb9aa2ca17..8f1c4f4407052aee40625173c77454fe0ee858af 100644 (file)
@@ -183,7 +183,7 @@ Ext.define('PMG.BackupRestore', {
            header: gettext('Size'),
            width: 100,
            sortable: true,
-           renderer: Proxmox.Utils.format_size,
+           renderer: Proxmox.Utils.render_size,
            dataIndex: 'size',
        },
        {
index c182bfb52b6a999404bab07d72d96a8607a02335..95272204aa8691d12399b5e332a839f76783369c 100644 (file)
@@ -267,7 +267,7 @@ Ext.define('PMG.PBSConfig', {
                {
                    text: 'Size',
                    dataIndex: 'size',
-                   renderer: Proxmox.Utils.format_size,
+                   renderer: Proxmox.Utils.render_size,
                    flex: 1,
                },
                {
index 94ab186192e7c1b2c2e024f4540a5aa43172d74a..8b4ee8cca216b9daa1b059885a39e6179f8d5441 100644 (file)
@@ -147,7 +147,7 @@ Ext.define('PMG.Postfix.MailQueue', {
        },
        {
            header: 'Size',
-           renderer: Proxmox.Utils.format_size,
+           renderer: Proxmox.Utils.render_size,
            flex: 1,
            dataIndex: 'message_size',
        },