8 use PVE
::Tools
qw(run_command lock_file);
14 use NetAddr
::IP
qw(:lower);
15 use POSIX
qw(ECONNREFUSED);
16 use Socket
qw(NI_NUMERICHOST NI_NUMERICSERV);
18 # host network related utility functions
20 our $PHYSICAL_NIC_RE = qr/(?:eth\d+|en[^:.]+|ib[^:.]+)/;
22 our $ipv4_reverse_mask = [
58 our $ipv4_mask_hash_localnet = {
68 '255.255.128.0' => 17,
69 '255.255.192.0' => 18,
70 '255.255.224.0' => 19,
71 '255.255.240.0' => 20,
72 '255.255.248.0' => 21,
73 '255.255.252.0' => 22,
74 '255.255.254.0' => 23,
75 '255.255.255.0' => 24,
76 '255.255.255.128' => 25,
77 '255.255.255.192' => 26,
78 '255.255.255.224' => 27,
79 '255.255.255.240' => 28,
80 '255.255.255.248' => 29,
81 '255.255.255.252' => 30,
82 '255.255.255.254' => 31,
83 '255.255.255.255' => 32,
86 sub setup_tc_rate_limit
{
87 my ($iface, $rate, $burst) = @_;
89 # these are allowed / expected to fail, e.g. when there is no previous rate limit to remove
90 eval { run_command
("/sbin/tc class del dev $iface parent 1: classid 1:1 >/dev/null 2>&1"); };
91 eval { run_command
("/sbin/tc filter del dev $iface parent ffff: protocol all pref 50 u32 >/dev/null 2>&1"); };
92 eval { run_command
("/sbin/tc qdisc del dev $iface ingress >/dev/null 2>&1"); };
93 eval { run_command
("/sbin/tc qdisc del dev $iface root >/dev/null 2>&1"); };
97 # tbf does not work for unknown reason
98 #$TC qdisc add dev $DEV root tbf rate $RATE latency 100ms burst $BURST
99 # so we use htb instead
100 run_command
("/sbin/tc qdisc add dev $iface root handle 1: htb default 1");
101 run_command
("/sbin/tc class add dev $iface parent 1: classid 1:1 " .
102 "htb rate ${rate}bps burst ${burst}b");
104 run_command
("/sbin/tc qdisc add dev $iface handle ffff: ingress");
106 "/sbin/tc filter add dev $iface parent ffff: prio 50 basic police rate ${rate}bps burst ${burst}b mtu 64kb drop");
112 my ($iface, $rate) = @_;
114 $rate = int($rate*1024*1024) if $rate;
115 my $burst = 1024*1024;
117 setup_tc_rate_limit
($iface, $rate, $burst);
122 sub read_bridge_mtu
{
125 my $mtu = PVE
::Tools
::file_read_firstline
("/sys/class/net/$bridge/mtu");
126 die "bridge '$bridge' does not exist\n" if !$mtu;
128 if ($mtu =~ /^(\d+)$/) { # avoid insecure dependency (untaint)
131 die "unexpeted error: unable to parse mtu value '$mtu' as integer\n";
137 my $parse_tap_device_name = sub {
138 my ($iface, $noerr) = @_;
142 if ($iface =~ m/^tap(\d+)i(\d+)$/) {
145 } elsif ($iface =~ m/^veth(\d+)i(\d+)$/) {
150 die "can't create firewall bridge for random interface name '$iface'\n";
153 return ($vmid, $devid);
156 my $compute_fwbr_names = sub {
157 my ($vmid, $devid) = @_;
159 my $fwbr = "fwbr${vmid}i${devid}";
160 # Note: the firewall use 'fwln+' to filter traffic to VMs
161 my $vethfw = "fwln${vmid}i${devid}";
162 my $vethfwpeer = "fwpr${vmid}p${devid}";
163 my $ovsintport = "fwln${vmid}o${devid}";
165 return ($fwbr, $vethfw, $vethfwpeer, $ovsintport);
168 sub iface_delete
:prototype($) {
170 run_command
(['/sbin/ip', 'link', 'delete', 'dev', $iface], noerr
=> 1)
171 == 0 or die "failed to delete interface '$iface'\n";
175 sub iface_create
:prototype($$@) {
176 my ($iface, $type, @args) = @_;
177 run_command
(['/sbin/ip', 'link', 'add', $iface, 'type', $type, @args], noerr
=> 1)
178 == 0 or die "failed to create interface '$iface'\n";
182 sub iface_set
:prototype($@) {
183 my ($iface, @opts) = @_;
184 run_command
(['/sbin/ip', 'link', 'set', $iface, @opts], noerr
=> 1)
185 == 0 or die "failed to set interface options for '$iface' (".join(' ', @opts).")\n";
189 # helper for nicer error messages:
190 sub iface_set_master
:prototype($$) {
191 my ($iface, $master) = @_;
192 if (defined($master)) {
193 eval { iface_set
($iface, 'master', $master) };
194 die "can't enslave '$iface' to '$master'\n" if $@;
196 eval { iface_set
($iface, 'nomaster') };
197 die "can't unenslave '$iface'\n" if $@;
202 my $cond_create_bridge = sub {
205 if (! -d
"/sys/class/net/$bridge") {
206 iface_create
($bridge, 'bridge');
207 disable_ipv6
($bridge);
213 return if !-d
'/proc/sys/net/ipv6'; # ipv6 might be completely disabled
214 my $file = "/proc/sys/net/ipv6/conf/$iface/disable_ipv6";
215 open(my $fh, '>', $file) or die "failed to open $file for writing: $!\n";
216 print {$fh} "1\n" or die "failed to disable link-local ipv6 for $iface\n";
221 my $bridge_disable_interface_learning = sub {
224 PVE
::ProcFSTools
::write_proc_entry
("/sys/class/net/$iface/brport/unicast_flood", "0");
225 PVE
::ProcFSTools
::write_proc_entry
("/sys/class/net/$iface/brport/learning", "0");
229 my $bridge_add_interface = sub {
230 my ($bridge, $iface, $tag, $trunks) = @_;
232 my $bridgemtu = read_bridge_mtu
($bridge);
233 eval { run_command
(['/sbin/ip', 'link', 'set', $iface, 'mtu', $bridgemtu]) };
235 # drop link local address (it can't be used when on a bridge anyway)
236 disable_ipv6
($iface);
237 iface_set_master
($iface, $bridge);
239 my $vlan_aware = PVE
::Tools
::file_read_firstline
("/sys/class/net/$bridge/bridge/vlan_filtering");
243 eval { run_command
(['/sbin/bridge', 'vlan', 'del', 'dev', $iface, 'vid', '1-4094']) };
244 die "failed to remove default vlan tags of $iface - $@\n" if $@;
247 my @trunks_array = split /;/, $trunks;
248 foreach my $trunk (@trunks_array) {
249 eval { run_command
(['/sbin/bridge', 'vlan', 'add', 'dev', $iface, 'vid', $trunk]) };
250 die "unable to add vlan $trunk to interface $iface - $@\n" if $@;
253 eval { run_command
(['/sbin/bridge', 'vlan', 'add', 'dev', $iface, 'vid', '2-4094']) };
254 die "unable to add default vlan tags to interface $iface - $@\n" if $@;
258 eval { run_command
(['/sbin/bridge', 'vlan', 'add', 'dev', $iface, 'vid', $tag, 'pvid', 'untagged']) };
259 die "unable to add vlan $tag to interface $iface - $@\n" if $@;
263 my $ovs_bridge_add_port = sub {
264 my ($bridge, $iface, $tag, $internal, $trunks) = @_;
266 $trunks =~ s/;/,/g if $trunks;
268 my $cmd = ['/usr/bin/ovs-vsctl'];
270 push @$cmd, '--', 'add-port', $bridge, $iface;
271 push @$cmd, "tag=$tag" if $tag;
272 push @$cmd, "trunks=". join(',', $trunks) if $trunks;
273 push @$cmd, "vlan_mode=native-untagged" if $tag && $trunks;
275 my $bridgemtu = read_bridge_mtu
($bridge);
276 push @$cmd, '--', 'set', 'Interface', $iface, "mtu_request=$bridgemtu";
280 push @$cmd, '--', 'set', 'Interface', $iface, 'type=internal';
283 eval { run_command
($cmd) };
284 die "can't add ovs port '$iface' - $@\n" if $@;
286 disable_ipv6
($iface);
289 my $activate_interface = sub {
290 my ($iface, $mtu) = @_;
292 my $cmd = ['/sbin/ip', 'link', 'set', $iface, 'up'];
293 push @$cmd, ('mtu', $mtu) if $mtu;
295 eval { run_command
($cmd) };
296 die "can't activate interface '$iface' - $@\n" if $@;
300 my ($iface, $mac) = @_;
302 my $learning = PVE
::Tools
::file_read_firstline
("/sys/class/net/$iface/brport/learning");
305 my ($vmid, $devid) = &$parse_tap_device_name($iface, 1);
306 return if !defined($vmid);
308 run_command
(['/sbin/bridge', 'fdb', 'append', $mac, 'dev', $iface, 'master', 'static']);
310 my ($fwbr, $vethfw, $vethfwpeer, $ovsintport) = &$compute_fwbr_names($vmid, $devid);
312 if (-d
"/sys/class/net/$vethfwpeer") {
313 run_command
(['/sbin/bridge', 'fdb', 'append', $mac, 'dev', $vethfwpeer, 'master', 'static']);
320 my ($iface, $mac) = @_;
322 my $learning = PVE
::Tools
::file_read_firstline
("/sys/class/net/$iface/brport/learning");
325 my ($vmid, $devid) = &$parse_tap_device_name($iface, 1);
326 return if !defined($vmid);
328 run_command
(['/sbin/bridge', 'fdb', 'del', $mac, 'dev', $iface, 'master', 'static']);
330 my ($fwbr, $vethfw, $vethfwpeer, $ovsintport) = &$compute_fwbr_names($vmid, $devid);
332 if (-d
"/sys/class/net/$vethfwpeer") {
333 run_command
(['/sbin/bridge', 'fdb', 'del', $mac, 'dev', $vethfwpeer, 'master', 'static']);
340 my ($iface, $bridge) = @_;
342 die "unable to get bridge setting\n" if !$bridge;
344 my $bridgemtu = read_bridge_mtu
($bridge);
347 disable_ipv6
($iface);
348 run_command
(['/sbin/ip', 'link', 'set', $iface, 'up', 'promisc', 'on', 'mtu', $bridgemtu]);
350 die "interface activation failed\n" if $@;
355 my ($veth, $vethpeer, $bridge, $mac) = @_;
357 die "unable to get bridge setting\n" if !$bridge;
359 my $bridgemtu = read_bridge_mtu
($bridge);
362 if (! -d
"/sys/class/net/$veth") {
363 my $cmd = ['/sbin/ip', 'link', 'add'];
365 push @$cmd, 'name', $veth;
366 push @$cmd, 'mtu', $bridgemtu;
367 push @$cmd, 'type', 'veth';
369 push @$cmd, 'peer', 'name', $vethpeer, 'mtu', $bridgemtu;
371 push @$cmd, 'addr', $mac if $mac;
373 eval { run_command
($cmd) };
374 die "can't create interface $veth - $@\n" if $@;
379 disable_ipv6
($vethpeer);
380 &$activate_interface($veth, $bridgemtu);
381 &$activate_interface($vethpeer, $bridgemtu);
389 if (-d
"/sys/class/net/$veth") {
392 eval { tap_unplug
($veth) };
396 my $create_firewall_bridge_linux = sub {
397 my ($iface, $bridge, $tag, $trunks, $no_learning) = @_;
399 my ($vmid, $devid) = &$parse_tap_device_name($iface);
400 my ($fwbr, $vethfw, $vethfwpeer) = &$compute_fwbr_names($vmid, $devid);
402 my $bridgemtu = read_bridge_mtu
($bridge);
404 &$cond_create_bridge($fwbr);
405 &$activate_interface($fwbr, $bridgemtu);
407 copy_bridge_config
($bridge, $fwbr);
408 veth_create
($vethfw, $vethfwpeer, $bridge);
410 &$bridge_add_interface($bridge, $vethfwpeer, $tag, $trunks);
411 &$bridge_disable_interface_learning($vethfwpeer) if $no_learning;
412 &$bridge_add_interface($fwbr, $vethfw);
414 &$bridge_add_interface($fwbr, $iface);
417 my $create_firewall_bridge_ovs = sub {
418 my ($iface, $bridge, $tag, $trunks, $no_learning) = @_;
420 my ($vmid, $devid) = &$parse_tap_device_name($iface);
421 my ($fwbr, undef, undef, $ovsintport) = &$compute_fwbr_names($vmid, $devid);
423 my $bridgemtu = read_bridge_mtu
($bridge);
425 &$cond_create_bridge($fwbr);
426 &$activate_interface($fwbr, $bridgemtu);
428 &$bridge_add_interface($fwbr, $iface);
430 &$ovs_bridge_add_port($bridge, $ovsintport, $tag, 1, $trunks);
431 &$activate_interface($ovsintport, $bridgemtu);
433 &$bridge_add_interface($fwbr, $ovsintport);
434 &$bridge_disable_interface_learning($ovsintport) if $no_learning;
437 my $cleanup_firewall_bridge = sub {
440 my ($vmid, $devid) = &$parse_tap_device_name($iface, 1);
441 return if !defined($vmid);
442 my ($fwbr, $vethfw, $vethfwpeer, $ovsintport) = &$compute_fwbr_names($vmid, $devid);
444 # cleanup old port config from any openvswitch bridge
445 if (-d
"/sys/class/net/$ovsintport") {
446 run_command
("/usr/bin/ovs-vsctl del-port $ovsintport", outfunc
=> sub {}, errfunc
=> sub {});
449 # delete old vethfw interface
450 veth_delete
($vethfw);
452 # cleanup fwbr bridge
453 if (-d
"/sys/class/net/$fwbr") {
459 my ($iface, $bridge, $tag, $firewall, $trunks, $rate, $opts) = @_;
461 $opts = {} if !defined($opts);
463 my $no_learning = defined($opts->{learning
}) && !$opts->{learning
}; # default to learning on
465 # cleanup old port config from any openvswitch bridge
467 run_command
("/usr/bin/ovs-vsctl del-port $iface", outfunc
=> sub {}, errfunc
=> sub {});
470 if (-d
"/sys/class/net/$bridge/bridge") {
471 &$cleanup_firewall_bridge($iface); # remove stale devices
473 my $vlan_aware = PVE
::Tools
::file_read_firstline
("/sys/class/net/$bridge/bridge/vlan_filtering");
476 die "vlan aware feature need to be enabled to use trunks" if $trunks;
477 my $newbridge = activate_bridge_vlan
($bridge, $tag);
478 copy_bridge_config
($bridge, $newbridge) if $bridge ne $newbridge;
479 $bridge = $newbridge;
484 &$create_firewall_bridge_linux($iface, $bridge, $tag, $trunks, $no_learning);
486 &$bridge_add_interface($bridge, $iface, $tag, $trunks);
488 $bridge_disable_interface_learning->($iface) if $no_learning;
491 &$cleanup_firewall_bridge($iface); # remove stale devices
494 &$create_firewall_bridge_ovs($iface, $bridge, $tag, $trunks, $no_learning);
496 &$ovs_bridge_add_port($bridge, $iface, $tag, undef, $trunks);
500 tap_rate_limit
($iface, $rate);
508 my $path= "/sys/class/net/$iface/brport/bridge";
510 my $bridge = basename
(readlink($path));
511 #avoid insecure dependency;
512 ($bridge) = $bridge =~ /(\S+)/;
514 iface_set_master
($iface, undef);
517 &$cleanup_firewall_bridge($iface);
518 #cleanup old port config from any openvswitch bridge
519 eval { run_command
("/usr/bin/ovs-vsctl del-port $iface", outfunc
=> sub {}, errfunc
=> sub {}) };
524 sub copy_bridge_config
{
525 my ($br0, $br1) = @_;
527 return if $br0 eq $br1;
530 'ageing_time', 'stp_state', 'priority', 'forward_delay',
531 'hello_time', 'max_age', 'multicast_snooping', 'multicast_querier',
534 foreach my $sysname (@$br_configs) {
536 my $v0 = PVE
::Tools
::file_read_firstline
("/sys/class/net/$br0/bridge/$sysname");
537 my $v1 = PVE
::Tools
::file_read_firstline
("/sys/class/net/$br1/bridge/$sysname");
539 PVE
::ProcFSTools
::write_proc_entry
("/sys/class/net/$br1/bridge/$sysname", $v0);
547 sub activate_bridge_vlan_slave
{
548 my ($bridgevlan, $iface, $tag) = @_;
549 my $ifacevlan = "${iface}.$tag";
551 # create vlan on $iface is not already exist
552 if (! -d
"/sys/class/net/$ifacevlan") {
554 my $cmd = ['/sbin/ip', 'link', 'add'];
555 push @$cmd, 'link', $iface;
556 push @$cmd, 'name', $ifacevlan;
557 push @$cmd, 'type', 'vlan', 'id', $tag;
560 die "can't add vlan tag $tag to interface $iface - $@\n" if $@;
562 # remove ipv6 link-local address before activation
563 disable_ipv6
($ifacevlan);
566 # be sure to have the $ifacevlan up
567 &$activate_interface($ifacevlan);
569 # test if $vlaniface is already enslaved in another bridge
570 my $path= "/sys/class/net/$ifacevlan/brport/bridge";
572 my $tbridge = basename
(readlink($path));
573 if ($tbridge ne $bridgevlan) {
574 die "interface $ifacevlan already exist in bridge $tbridge\n";
576 # Port already attached to bridge: do nothing.
581 # add $ifacevlan to the bridge
582 &$bridge_add_interface($bridgevlan, $ifacevlan);
586 sub activate_bridge_vlan
{
587 my ($bridge, $tag_param) = @_;
589 die "bridge '$bridge' is not active\n" if ! -d
"/sys/class/net/$bridge";
591 return $bridge if !defined($tag_param); # no vlan, simply return
593 my $tag = int($tag_param);
595 die "got strange vlan tag '$tag_param'\n" if $tag < 1 || $tag > 4094;
597 my $bridgevlan = "${bridge}v$tag";
600 my $dir = "/sys/class/net/$bridge/brif";
601 PVE
::Tools
::dir_glob_foreach
($dir, '(((eth|bond)\d+|en[^.]+)(\.\d+)?)', sub {
605 die "no physical interface on bridge '$bridge'\n" if scalar(@ifaces) == 0;
608 # add bridgevlan if it doesn't already exist
609 if (! -d
"/sys/class/net/$bridgevlan") {
610 iface_create
($bridgevlan, 'bridge');
613 # for each physical interface (eth or bridge) bind them to bridge vlan
614 foreach my $iface (@ifaces) {
615 activate_bridge_vlan_slave
($bridgevlan, $iface, $tag);
618 #fixme: set other bridge flags
620 # remove ipv6 link-local address before activation
621 disable_ipv6
($bridgevlan);
622 # be sure to have the bridge up
623 &$activate_interface($bridgevlan);
629 my ($host, $port, $timeout) = @_;
633 $timeout = 3 if !$timeout; # sane default
635 # Net::Ping defaults to the echo port
638 # Net::Ping's port_number() implies service_check(1)
644 $result = PVE
::Tools
::run_with_timeout
($timeout, sub {
645 $sock = IO
::Socket
::IP-
>new(PeerHost
=> $host, PeerPort
=> $port, Type
=> SOCK_STREAM
);
646 $result = $refused if $! == ECONNREFUSED
;
657 my ($cidr, $version) = @_;
659 my ($ip, $prefix) = $cidr =~ m!^(\S+?)/(\S+)$! or return;
661 my $ipobj = Net
::IP-
>new($ip, $version);
664 $version = $ipobj->version();
666 my $binmask = Net
::IP
::ip_get_mask
($prefix, $version);
669 my $masked_binip = $ipobj->binip() & $binmask;
670 my $masked_ip = Net
::IP
::ip_bintoip
($masked_binip, $version);
671 return Net
::IP-
>new("$masked_ip/$prefix");
675 my ($ip, $cidr, $version) = @_;
677 my $cidr_obj = IP_from_cidr
($cidr, $version);
678 return if !$cidr_obj;
680 my $ip_obj = Net
::IP-
>new($ip, $version);
683 my $overlap = $cidr_obj->overlaps($ip_obj);
684 return if !defined($overlap);
686 return $overlap == $Net::IP
::IP_B_IN_A_OVERLAP
|| $overlap == $Net::IP
::IP_IDENTICAL
;
689 # get all currently configured addresses that have a global scope, i.e., are reachable from the
690 # outside of the host and thus are neither loopback nor link-local ones
691 # returns an array ref of: { addr => "IP", cidr => "IP/PREFIXLEN", family => "inet|inet6" }
692 sub get_reachable_networks
{
694 run_command
([qw(ip -j addr show up scope global)], outfunc
=> sub { $raw .= shift });
695 my $decoded = decode_json
($raw);
697 my $addrs = []; # filter/transform first so that we can sort correctly more easily below
698 for my $e ($decoded->@*) {
699 next if !$e->{addr_info
} || grep { $_ eq 'LOOPBACK' } $e->{flags
}->@*;
700 push $addrs->@*, grep { scalar(keys $_->%*) } $e->{addr_info
}->@*
703 for my $info (sort { $a->{family
} cmp $b->{family
} || $a->{local} cmp $b->{local} } $addrs->@*) {
705 addr
=> $info->{local},
706 cidr
=> "$info->{local}/$info->{prefixlen}",
707 family
=> $info->{family
},
714 # get one or all local IPs that are not loopback ones, able to pick up the following ones (in order)
715 # - the hostname primary resolves too, follows gai.conf (admin controlled) and will be prioritised
716 # - all configured in the interfaces configuration
717 # - all currently networks known to the kernel in the current (root) namespace
718 # returns a single address if no parameter is passed, and all found, grouped by type, if `all => 1`
723 my $nodename = PVE
::INotify
::nodename
();
724 my $resolved_host = eval { get_ip_from_hostname
($nodename) };
726 return $resolved_host if defined($resolved_host) && !$param{all
};
728 my $all = { v4
=> {}, v6
=> {} }; # hash to avoid duplicates and group by type
730 my $ifaces = PVE
::INotify
::read_file
('interfaces', 1)->{data
}->{ifaces
};
731 for my $if (values $ifaces->%*) {
732 next if $if->{type
} eq 'loopback' || (!defined($if->{address
}) && !defined($if->{address6
}));
733 my ($v4, $v6) = ($if->{address
}, $if->{address6
});
735 return ($v4 // $v6) if !$param{all
}; # prefer v4, admin can override $resolved_host via hosts/gai.conf
737 $all->{v4
}->{$v4} = 1 if defined($v4);
738 $all->{v6
}->{$v6} = 1 if defined($v6);
741 my $live = eval { get_reachable_networks
() } // [];
742 for my $info ($live->@*) {
743 my $addr = $info->{addr
};
745 return $addr if !$param{all
};
747 if ($info->{family
} eq 'inet') {
748 $all->{v4
}->{$addr} = 1;
750 $all->{v6
}->{$addr} = 1;
754 return if !$param{all
}; # getting here means no early return above triggered -> no IPs
756 my $res = []; # order gai.conf controlled first, then group v4 and v6, simply lexically sorted
757 if ($resolved_host) {
758 push $res->@*, $resolved_host;
759 delete $all->{v4
}->{$resolved_host};
760 delete $all->{v6
}->{$resolved_host};
762 push $res->@*, sort { $a cmp $b } keys $all->{v4
}->%*;
763 push $res->@*, sort { $a cmp $b } keys $all->{v6
}->%*;
768 sub get_local_ip_from_cidr
{
773 run_command
(['/sbin/ip', 'address', 'show', 'to', $cidr, 'up'], outfunc
=> sub {
774 if ($_[0] =~ m!^\s*inet(?:6)?\s+($PVE::Tools::IPRE)(?:/\d+|\s+peer\s+)!) {
775 $IPs->{$1} = $i++ if !exists($IPs->{$1});
779 return [ sort { $IPs->{$a} <=> $IPs->{$b} } keys %{$IPs} ];
784 my ($err, $host, $port) = Socket
::getnameinfo
($addr, NI_NUMERICHOST
| NI_NUMERICSERV
);
785 die "failed to get numerical host address: $err\n" if $err;
786 return ($host, $port) if wantarray;
790 sub get_ip_from_hostname
{
791 my ($hostname, $noerr) = @_;
793 my @res = eval { PVE
::Tools
::getaddrinfo_all
($hostname) };
795 die "hostname lookup '$hostname' failed - $@" if !$noerr;
800 my $ip = addr_to_ip
($ai->{addr
});
801 if ($ip !~ m/^127\.|^::1$/) {
802 return wantarray ?
($ip, $ai->{family
}) : $ip;
805 # NOTE: we only get here if no WAN/LAN IP was found, so this is now the error path!
806 die "address lookup for '$hostname' did not find any IP address\n" if !$noerr;
811 my ($code, @param) = @_;
812 my $res = lock_file
('/var/lock/pve-network.lck', 10, $code, @param);
817 # the canonical form of the given IP, i.e. dotted quad for IPv4 and RFC 5952 for IPv6
821 my $ip_obj = NetAddr
::IP-
>new($ip) or die "invalid IP string '$ip'\n";
823 return $ip_obj->canon();
826 # List of unique, canonical IPs in the provided list.
827 # Keeps the original order, filtering later duplicates.
834 for my $ip (@{$ips}) {
835 $ip = canonical_ip
($ip);
837 next if $seen->{$ip};