8 use PVE
::Tools
qw(run_command lock_file);
14 use NetAddr
::IP
qw(:lower);
15 use POSIX
qw(ECONNREFUSED);
16 use Socket
qw(NI_NUMERICHOST NI_NUMERICSERV);
18 # host network related utility functions
20 our $PHYSICAL_NIC_RE = qr/(?:eth\d+|en[^:.]+|ib[^:.]+)/;
22 our $ipv4_reverse_mask = [
58 our $ipv4_mask_hash_localnet = {
68 '255.255.128.0' => 17,
69 '255.255.192.0' => 18,
70 '255.255.224.0' => 19,
71 '255.255.240.0' => 20,
72 '255.255.248.0' => 21,
73 '255.255.252.0' => 22,
74 '255.255.254.0' => 23,
75 '255.255.255.0' => 24,
76 '255.255.255.128' => 25,
77 '255.255.255.192' => 26,
78 '255.255.255.224' => 27,
79 '255.255.255.240' => 28,
80 '255.255.255.248' => 29,
81 '255.255.255.252' => 30,
82 '255.255.255.254' => 31,
83 '255.255.255.255' => 32,
86 sub setup_tc_rate_limit
{
87 my ($iface, $rate, $burst) = @_;
89 # these are allowed / expected to fail, e.g. when there is no previous rate limit to remove
90 eval { run_command
("/sbin/tc class del dev $iface parent 1: classid 1:1 >/dev/null 2>&1"); };
91 eval { run_command
("/sbin/tc filter del dev $iface parent ffff: protocol all pref 50 u32 >/dev/null 2>&1"); };
92 eval { run_command
("/sbin/tc qdisc del dev $iface ingress >/dev/null 2>&1"); };
93 eval { run_command
("/sbin/tc qdisc del dev $iface root >/dev/null 2>&1"); };
97 # tbf does not work for unknown reason
98 #$TC qdisc add dev $DEV root tbf rate $RATE latency 100ms burst $BURST
99 # so we use htb instead
100 run_command
("/sbin/tc qdisc add dev $iface root handle 1: htb default 1");
101 run_command
("/sbin/tc class add dev $iface parent 1: classid 1:1 " .
102 "htb rate ${rate}bps burst ${burst}b");
104 run_command
("/sbin/tc qdisc add dev $iface handle ffff: ingress");
105 run_command
("/sbin/tc filter add dev $iface parent ffff: " .
107 "police rate ${rate}bps burst ${burst}b mtu 64kb " .
112 my ($iface, $rate) = @_;
114 $rate = int($rate*1024*1024) if $rate;
115 my $burst = 1024*1024;
117 setup_tc_rate_limit
($iface, $rate, $burst);
120 sub read_bridge_mtu
{
123 my $mtu = PVE
::Tools
::file_read_firstline
("/sys/class/net/$bridge/mtu");
124 die "bridge '$bridge' does not exist\n" if !$mtu;
125 # avoid insecure dependency;
126 die "unable to parse mtu value" if $mtu !~ /^(\d+)$/;
132 my $parse_tap_device_name = sub {
133 my ($iface, $noerr) = @_;
137 if ($iface =~ m/^tap(\d+)i(\d+)$/) {
140 } elsif ($iface =~ m/^veth(\d+)i(\d+)$/) {
144 return undef if $noerr;
145 die "can't create firewall bridge for random interface name '$iface'\n";
148 return ($vmid, $devid);
151 my $compute_fwbr_names = sub {
152 my ($vmid, $devid) = @_;
154 my $fwbr = "fwbr${vmid}i${devid}";
155 # Note: the firewall use 'fwln+' to filter traffic to VMs
156 my $vethfw = "fwln${vmid}i${devid}";
157 my $vethfwpeer = "fwpr${vmid}p${devid}";
158 my $ovsintport = "fwln${vmid}o${devid}";
160 return ($fwbr, $vethfw, $vethfwpeer, $ovsintport);
163 sub iface_delete
($) {
165 run_command
(['/sbin/ip', 'link', 'delete', 'dev', $iface], noerr
=> 1)
166 == 0 or die "failed to delete interface '$iface'\n";
169 sub iface_create
($$@) {
170 my ($iface, $type, @args) = @_;
171 run_command
(['/sbin/ip', 'link', 'add', $iface, 'type', $type, @args], noerr
=> 1)
172 == 0 or die "failed to create interface '$iface'\n";
176 my ($iface, @opts) = @_;
177 run_command
(['/sbin/ip', 'link', 'set', $iface, @opts], noerr
=> 1)
178 == 0 or die "failed to set interface options for '$iface' (".join(' ', @opts).")\n";
181 # helper for nicer error messages:
182 sub iface_set_master
($$) {
183 my ($iface, $master) = @_;
184 if (defined($master)) {
185 eval { iface_set
($iface, 'master', $master) };
186 die "can't enslave '$iface' to '$master'\n" if $@;
188 eval { iface_set
($iface, 'nomaster') };
189 die "can't unenslave '$iface'\n" if $@;
193 my $cond_create_bridge = sub {
196 if (! -d
"/sys/class/net/$bridge") {
197 iface_create
($bridge, 'bridge');
198 disable_ipv6
($bridge);
204 return if !-d
'/proc/sys/net/ipv6'; # ipv6 might be completely disabled
205 my $file = "/proc/sys/net/ipv6/conf/$iface/disable_ipv6";
206 open(my $fh, '>', $file) or die "failed to open $file for writing: $!\n";
207 print {$fh} "1\n" or die "failed to disable link-local ipv6 for $iface\n";
211 my $bridge_disable_interface_learning = sub {
214 PVE
::ProcFSTools
::write_proc_entry
("/sys/class/net/$iface/brport/unicast_flood", "0");
215 PVE
::ProcFSTools
::write_proc_entry
("/sys/class/net/$iface/brport/learning", "0");
219 my $bridge_add_interface = sub {
220 my ($bridge, $iface, $tag, $trunks) = @_;
222 # drop link local address (it can't be used when on a bridge anyway)
223 disable_ipv6
($iface);
224 iface_set_master
($iface, $bridge);
226 my $vlan_aware = PVE
::Tools
::file_read_firstline
("/sys/class/net/$bridge/bridge/vlan_filtering");
230 eval { run_command
(['/sbin/bridge', 'vlan', 'del', 'dev', $iface, 'vid', '1-4094']) };
231 die "failed to remove default vlan tags of $iface - $@\n" if $@;
234 my @trunks_array = split /;/, $trunks;
235 foreach my $trunk (@trunks_array) {
236 eval { run_command
(['/sbin/bridge', 'vlan', 'add', 'dev', $iface, 'vid', $trunk]) };
237 die "unable to add vlan $trunk to interface $iface - $@\n" if $@;
240 eval { run_command
(['/sbin/bridge', 'vlan', 'add', 'dev', $iface, 'vid', '2-4094']) };
241 die "unable to add default vlan tags to interface $iface - $@\n" if $@;
245 eval { run_command
(['/sbin/bridge', 'vlan', 'add', 'dev', $iface, 'vid', $tag, 'pvid', 'untagged']) };
246 die "unable to add vlan $tag to interface $iface - $@\n" if $@;
250 my $ovs_bridge_add_port = sub {
251 my ($bridge, $iface, $tag, $internal, $trunks) = @_;
253 $trunks =~ s/;/,/g if $trunks;
255 my $cmd = ['/usr/bin/ovs-vsctl'];
257 push @$cmd, '--', 'add-port', $bridge, $iface;
258 push @$cmd, "tag=$tag" if $tag;
259 push @$cmd, "trunks=". join(',', $trunks) if $trunks;
260 push @$cmd, "vlan_mode=native-untagged" if $tag && $trunks;
264 push @$cmd, '--', 'set', 'Interface', $iface, 'type=internal';
267 eval { run_command
($cmd) };
268 die "can't add ovs port '$iface' - $@\n" if $@;
270 disable_ipv6
($iface);
273 my $activate_interface = sub {
276 eval { run_command
(['/sbin/ip', 'link', 'set', $iface, 'up']) };
277 die "can't activate interface '$iface' - $@\n" if $@;
281 my ($iface, $mac) = @_;
283 my $learning = PVE
::Tools
::file_read_firstline
("/sys/class/net/$iface/brport/learning");
286 my ($vmid, $devid) = &$parse_tap_device_name($iface, 1);
287 return if !defined($vmid);
289 run_command
(['/sbin/bridge', 'fdb', 'append', $mac, 'dev', $iface, 'master', 'static']);
291 my ($fwbr, $vethfw, $vethfwpeer, $ovsintport) = &$compute_fwbr_names($vmid, $devid);
293 if (-d
"/sys/class/net/$vethfwpeer") {
294 run_command
(['/sbin/bridge', 'fdb', 'append', $mac, 'dev', $vethfwpeer, 'master', 'static']);
300 my ($iface, $mac) = @_;
302 my $learning = PVE
::Tools
::file_read_firstline
("/sys/class/net/$iface/brport/learning");
305 my ($vmid, $devid) = &$parse_tap_device_name($iface, 1);
306 return if !defined($vmid);
308 run_command
(['/sbin/bridge', 'fdb', 'del', $mac, 'dev', $iface, 'master', 'static']);
310 my ($fwbr, $vethfw, $vethfwpeer, $ovsintport) = &$compute_fwbr_names($vmid, $devid);
312 if (-d
"/sys/class/net/$vethfwpeer") {
313 run_command
(['/sbin/bridge', 'fdb', 'del', $mac, 'dev', $vethfwpeer, 'master', 'static']);
318 my ($iface, $bridge) = @_;
320 die "unable to get bridge setting\n" if !$bridge;
322 my $bridgemtu = read_bridge_mtu
($bridge);
325 disable_ipv6
($iface);
326 run_command
(['/sbin/ip', 'link', 'set', $iface, 'up', 'promisc', 'on', 'mtu', $bridgemtu]);
328 die "interface activation failed\n" if $@;
332 my ($veth, $vethpeer, $bridge, $mac) = @_;
334 die "unable to get bridge setting\n" if !$bridge;
336 my $bridgemtu = read_bridge_mtu
($bridge);
339 if (! -d
"/sys/class/net/$veth") {
340 my $cmd = ['/sbin/ip', 'link', 'add'];
342 push @$cmd, 'name', $veth;
343 push @$cmd, 'mtu', $bridgemtu;
344 push @$cmd, 'type', 'veth';
346 push @$cmd, 'peer', 'name', $vethpeer, 'mtu', $bridgemtu;
348 push @$cmd, 'addr', $mac if $mac;
350 eval { run_command
($cmd) };
351 die "can't create interface $veth - $@\n" if $@;
356 disable_ipv6
($vethpeer);
357 &$activate_interface($veth);
358 &$activate_interface($vethpeer);
364 if (-d
"/sys/class/net/$veth") {
367 eval { tap_unplug
($veth) };
370 my $create_firewall_bridge_linux = sub {
371 my ($iface, $bridge, $tag, $trunks, $no_learning) = @_;
373 my ($vmid, $devid) = &$parse_tap_device_name($iface);
374 my ($fwbr, $vethfw, $vethfwpeer) = &$compute_fwbr_names($vmid, $devid);
376 &$cond_create_bridge($fwbr);
377 &$activate_interface($fwbr);
379 copy_bridge_config
($bridge, $fwbr);
380 veth_create
($vethfw, $vethfwpeer, $bridge);
382 &$bridge_add_interface($bridge, $vethfwpeer, $tag, $trunks);
383 &$bridge_disable_interface_learning($vethfwpeer) if $no_learning;
384 &$bridge_add_interface($fwbr, $vethfw);
386 &$bridge_add_interface($fwbr, $iface);
389 my $create_firewall_bridge_ovs = sub {
390 my ($iface, $bridge, $tag, $trunks, $no_learning) = @_;
392 my ($vmid, $devid) = &$parse_tap_device_name($iface);
393 my ($fwbr, undef, undef, $ovsintport) = &$compute_fwbr_names($vmid, $devid);
395 my $bridgemtu = read_bridge_mtu
($bridge);
397 &$cond_create_bridge($fwbr);
398 &$activate_interface($fwbr);
400 &$bridge_add_interface($fwbr, $iface);
402 &$ovs_bridge_add_port($bridge, $ovsintport, $tag, 1, $trunks);
403 &$activate_interface($ovsintport);
405 # set the same mtu for ovs int port
406 run_command
(['/sbin/ip', 'link', 'set', $ovsintport, 'mtu', $bridgemtu]);
408 &$bridge_add_interface($fwbr, $ovsintport);
409 &$bridge_disable_interface_learning($ovsintport) if $no_learning;
412 my $cleanup_firewall_bridge = sub {
415 my ($vmid, $devid) = &$parse_tap_device_name($iface, 1);
416 return if !defined($vmid);
417 my ($fwbr, $vethfw, $vethfwpeer, $ovsintport) = &$compute_fwbr_names($vmid, $devid);
419 # cleanup old port config from any openvswitch bridge
420 if (-d
"/sys/class/net/$ovsintport") {
421 run_command
("/usr/bin/ovs-vsctl del-port $ovsintport", outfunc
=> sub {}, errfunc
=> sub {});
424 # delete old vethfw interface
425 veth_delete
($vethfw);
427 # cleanup fwbr bridge
428 if (-d
"/sys/class/net/$fwbr") {
434 my ($iface, $bridge, $tag, $firewall, $trunks, $rate, $opts) = @_;
436 $opts = {} if !defined($opts);
438 my $no_learning = defined($opts->{learning
}) && !$opts->{learning
}; # default to learning on
440 # cleanup old port config from any openvswitch bridge
442 run_command
("/usr/bin/ovs-vsctl del-port $iface", outfunc
=> sub {}, errfunc
=> sub {});
445 if (-d
"/sys/class/net/$bridge/bridge") {
446 &$cleanup_firewall_bridge($iface); # remove stale devices
448 my $vlan_aware = PVE
::Tools
::file_read_firstline
("/sys/class/net/$bridge/bridge/vlan_filtering");
451 die "vlan aware feature need to be enabled to use trunks" if $trunks;
452 my $newbridge = activate_bridge_vlan
($bridge, $tag);
453 copy_bridge_config
($bridge, $newbridge) if $bridge ne $newbridge;
454 $bridge = $newbridge;
459 &$create_firewall_bridge_linux($iface, $bridge, $tag, $trunks, $no_learning);
461 &$bridge_add_interface($bridge, $iface, $tag, $trunks);
463 $bridge_disable_interface_learning->($iface) if $no_learning;
466 &$cleanup_firewall_bridge($iface); # remove stale devices
469 &$create_firewall_bridge_ovs($iface, $bridge, $tag, $trunks, $no_learning);
471 &$ovs_bridge_add_port($bridge, $iface, $tag, undef, $trunks);
475 tap_rate_limit
($iface, $rate);
481 my $path= "/sys/class/net/$iface/brport/bridge";
483 my $bridge = basename
(readlink($path));
484 #avoid insecure dependency;
485 ($bridge) = $bridge =~ /(\S+)/;
487 iface_set_master
($iface, undef);
490 &$cleanup_firewall_bridge($iface);
491 #cleanup old port config from any openvswitch bridge
492 eval {run_command
("/usr/bin/ovs-vsctl del-port $iface", outfunc
=> sub {}, errfunc
=> sub {}) };
495 sub copy_bridge_config
{
496 my ($br0, $br1) = @_;
498 return if $br0 eq $br1;
501 'ageing_time', 'stp_state', 'priority', 'forward_delay',
502 'hello_time', 'max_age', 'multicast_snooping', 'multicast_querier',
505 foreach my $sysname (@$br_configs) {
507 my $v0 = PVE
::Tools
::file_read_firstline
("/sys/class/net/$br0/bridge/$sysname");
508 my $v1 = PVE
::Tools
::file_read_firstline
("/sys/class/net/$br1/bridge/$sysname");
510 PVE
::ProcFSTools
::write_proc_entry
("/sys/class/net/$br1/bridge/$sysname", $v0);
517 sub activate_bridge_vlan_slave
{
518 my ($bridgevlan, $iface, $tag) = @_;
519 my $ifacevlan = "${iface}.$tag";
521 # create vlan on $iface is not already exist
522 if (! -d
"/sys/class/net/$ifacevlan") {
524 my $cmd = ['/sbin/ip', 'link', 'add'];
525 push @$cmd, 'link', $iface;
526 push @$cmd, 'name', $ifacevlan;
527 push @$cmd, 'type', 'vlan', 'id', $tag;
530 die "can't add vlan tag $tag to interface $iface - $@\n" if $@;
532 # remove ipv6 link-local address before activation
533 disable_ipv6
($ifacevlan);
536 # be sure to have the $ifacevlan up
537 &$activate_interface($ifacevlan);
539 # test if $vlaniface is already enslaved in another bridge
540 my $path= "/sys/class/net/$ifacevlan/brport/bridge";
542 my $tbridge = basename
(readlink($path));
543 if ($tbridge ne $bridgevlan) {
544 die "interface $ifacevlan already exist in bridge $tbridge\n";
546 # Port already attached to bridge: do nothing.
551 # add $ifacevlan to the bridge
552 &$bridge_add_interface($bridgevlan, $ifacevlan);
555 sub activate_bridge_vlan
{
556 my ($bridge, $tag_param) = @_;
558 die "bridge '$bridge' is not active\n" if ! -d
"/sys/class/net/$bridge";
560 return $bridge if !defined($tag_param); # no vlan, simply return
562 my $tag = int($tag_param);
564 die "got strange vlan tag '$tag_param'\n" if $tag < 1 || $tag > 4094;
566 my $bridgevlan = "${bridge}v$tag";
569 my $dir = "/sys/class/net/$bridge/brif";
570 PVE
::Tools
::dir_glob_foreach
($dir, '(((eth|bond)\d+|en[^.]+)(\.\d+)?)', sub {
574 die "no physical interface on bridge '$bridge'\n" if scalar(@ifaces) == 0;
577 # add bridgevlan if it doesn't already exist
578 if (! -d
"/sys/class/net/$bridgevlan") {
579 iface_create
($bridgevlan, 'bridge');
582 # for each physical interface (eth or bridge) bind them to bridge vlan
583 foreach my $iface (@ifaces) {
584 activate_bridge_vlan_slave
($bridgevlan, $iface, $tag);
587 #fixme: set other bridge flags
589 # remove ipv6 link-local address before activation
590 disable_ipv6
($bridgevlan);
591 # be sure to have the bridge up
592 &$activate_interface($bridgevlan);
598 my ($host, $port, $timeout) = @_;
602 $timeout = 3 if !$timeout; # sane default
604 # Net::Ping defaults to the echo port
607 # Net::Ping's port_number() implies service_check(1)
613 $result = PVE
::Tools
::run_with_timeout
($timeout, sub {
614 $sock = IO
::Socket
::IP-
>new(PeerHost
=> $host, PeerPort
=> $port, Type
=> SOCK_STREAM
);
615 $result = $refused if $! == ECONNREFUSED
;
626 my ($cidr, $version) = @_;
628 return if $cidr !~ m!^(\S+?)/(\S+)$!;
629 my ($ip, $prefix) = ($1, $2);
631 my $ipobj = Net
::IP-
>new($ip, $version);
634 $version = $ipobj->version();
636 my $binmask = Net
::IP
::ip_get_mask
($prefix, $version);
639 my $masked_binip = $ipobj->binip() & $binmask;
640 my $masked_ip = Net
::IP
::ip_bintoip
($masked_binip, $version);
641 return Net
::IP-
>new("$masked_ip/$prefix");
645 my ($ip, $cidr, $version) = @_;
647 my $cidr_obj = IP_from_cidr
($cidr, $version);
648 return undef if !$cidr_obj;
650 my $ip_obj = Net
::IP-
>new($ip, $version);
651 return undef if !$ip_obj;
653 my $overlap = $cidr_obj->overlaps($ip_obj);
655 return if !defined($overlap);
657 return $overlap == $Net::IP
::IP_B_IN_A_OVERLAP
|| $overlap == $Net::IP
::IP_IDENTICAL
;
660 # get all currently configured addresses that have a global scope, i.e., are reachable from the
661 # outside of the host and thus are neither loopback nor link-local ones
662 # returns an array ref of: { addr => "IP", cidr => "IP/PREFIXLEN", family => "inet|inet6" }
663 sub get_reachable_networks
{
665 run_command
([qw(ip -j addr show up scope global)], outfunc
=> sub { $raw .= shift });
666 my $decoded = decode_json
($raw);
668 my $addrs = []; # filter/transform first so that we can sort correctly more easily below
669 for my $e ($decoded->@*) {
670 next if !$e->{addr_info
} || grep { $_ eq 'LOOPBACK' } $e->{flags
}->@*;
671 push $addrs->@*, grep { scalar(keys $_->%*) } $e->{addr_info
}->@*
674 for my $info (sort { $a->{family
} cmp $b->{family
} || $a->{local} cmp $b->{local} } $addrs->@*) {
676 addr
=> $info->{local},
677 cidr
=> "$info->{local}/$info->{prefixlen}",
678 family
=> $info->{family
},
685 # get one or all local IPs that are not loopback ones, able to pick up the following ones (in order)
686 # - the hostname primary resolves too, follows gai.conf (admin controlled) and will be prioritised
687 # - all configured in the interfaces configuration
688 # - all currently networks known to the kernel in the current (root) namespace
689 # returns a single address if no parameter is passed, and all found, grouped by type, if `all => 1`
694 my $nodename = PVE
::INotify
::nodename
();
695 my $resolved_host = eval { get_ip_from_hostname
($nodename) };
697 return $resolved_host if defined($resolved_host) && !$param{all
};
699 my $all = { v4
=> {}, v6
=> {} }; # hash to avoid duplicates and group by type
701 my $ifaces = PVE
::INotify
::read_file
('interfaces', 1)->{data
}->{ifaces
};
702 for my $if (values $ifaces->%*) {
703 next if $if->{type
} eq 'loopback' || (!defined($if->{address
}) && !defined($if->{address6
}));
704 my ($v4, $v6) = ($if->{address
}, $if->{address6
});
706 return ($v4 // $v6) if !$param{all
}; # prefer v4, admin can override $resolved_host via hosts/gai.conf
708 $all->{v4
}->{$v4} = 1 if defined($v4);
709 $all->{v6
}->{$v6} = 1 if defined($v6);
712 my $live = eval { get_reachable_networks
() } // [];
713 for my $info ($live->@*) {
714 my $addr = $info->{addr
};
716 return $addr if !$param{all
};
718 if ($info->{family
} eq 'inet') {
719 $all->{v4
}->{$addr} = 1;
721 $all->{v6
}->{$addr} = 1;
725 return undef if !$param{all
}; # getting here means no early return above triggered -> no IPs
727 my $res = []; # order gai.conf controlled first, then group v4 and v6, simply lexically sorted
728 if ($resolved_host) {
729 push $res->@*, $resolved_host;
730 delete $all->{v4
}->{$resolved_host};
731 delete $all->{v6
}->{$resolved_host};
733 push $res->@*, sort { $a cmp $b } keys $all->{v4
}->%*;
734 push $res->@*, sort { $a cmp $b } keys $all->{v6
}->%*;
739 sub get_local_ip_from_cidr
{
744 run_command
(['/sbin/ip', 'address', 'show', 'to', $cidr, 'up'], outfunc
=> sub {
745 if ($_[0] =~ m!^\s*inet(?:6)?\s+($PVE::Tools::IPRE)(?:/\d+|\s+peer\s+)!) {
746 $IPs->{$1} = $i++ if !exists($IPs->{$1});
750 return [ sort { $IPs->{$a} <=> $IPs->{$b} } keys %{$IPs} ];
755 my ($err, $host, $port) = Socket
::getnameinfo
($addr, NI_NUMERICHOST
| NI_NUMERICSERV
);
756 die "failed to get numerical host address: $err\n" if $err;
757 return ($host, $port) if wantarray;
761 sub get_ip_from_hostname
{
762 my ($hostname, $noerr) = @_;
764 my @res = eval { PVE
::Tools
::getaddrinfo_all
($hostname) };
766 die "hostname lookup '$hostname' failed - $@" if !$noerr;
771 my $ip = addr_to_ip
($ai->{addr
});
772 if ($ip !~ m/^127\.|^::1$/) {
773 return wantarray ?
($ip, $ai->{family
}) : $ip;
776 # NOTE: we only get here if no WAN/LAN IP was found, so this is now the error path!
777 die "address lookup for '$hostname' did not find any IP address\n" if !$noerr;
782 my ($code, @param) = @_;
783 my $res = lock_file
('/var/lock/pve-network.lck', 10, $code, @param);
788 # the canonical form of the given IP, i.e. dotted quad for IPv4 and RFC 5952 for IPv6
792 my $ip_obj = NetAddr
::IP-
>new($ip) or die "invalid IP string '$ip'\n";
794 return $ip_obj->canon();
797 # List of unique, canonical IPs in the provided list.
798 # Keeps the original order, filtering later duplicates.
805 for my $ip (@{$ips}) {
806 $ip = canonical_ip
($ip);
808 next if $seen->{$ip};