1 From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
2 From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
3 Date: Mon, 6 Apr 2020 12:17:05 +0200
4 Subject: [PATCH] mirror: add check for bitmap-mode without bitmap
6 Content-Type: text/plain; charset=UTF-8
7 Content-Transfer-Encoding: 8bit
9 as one without the other does not make much sense with the current set
12 Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
13 Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
16 1 file changed, 3 insertions(+)
18 diff --git a/blockdev.c b/blockdev.c
19 index 9a1a3118ed..a57b0af2e7 100644
22 @@ -3050,6 +3050,9 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
23 if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_ALLOW_RO, errp)) {
26 + } else if (has_bitmap_mode) {
27 + error_setg(errp, "Cannot specify bitmap sync mode without a bitmap");