1 From 741b9f52069e043e93f0fc47e820ddbfa0bff7a3 Mon Sep 17 00:00:00 2001
2 From: Wolfgang Bumiller <w.bumiller@proxmox.com>
3 Date: Mon, 7 Aug 2017 08:51:16 +0200
4 Subject: [PATCH 28/28] adding old vma files
9 block/backup.c | 128 ++++---
10 block/replication.c | 1 +
11 blockdev.c | 250 +++++++++-----
13 include/block/block_int.h | 4 +
14 vma-reader.c | 857 ++++++++++++++++++++++++++++++++++++++++++++++
15 vma-writer.c | 771 +++++++++++++++++++++++++++++++++++++++++
16 vma.c | 757 ++++++++++++++++++++++++++++++++++++++++
18 11 files changed, 2799 insertions(+), 133 deletions(-)
19 create mode 100644 vma-reader.c
20 create mode 100644 vma-writer.c
21 create mode 100644 vma.c
22 create mode 100644 vma.h
24 diff --git a/Makefile b/Makefile
25 index 6c359b2f86..edbc8b50f0 100644
28 @@ -284,7 +284,7 @@ ifneq ($(wildcard config-host.mak),)
29 include $(SRC_PATH)/tests/Makefile.include
32 -all: $(DOCS) $(TOOLS) $(HELPERS-y) recurse-all modules
33 +all: $(DOCS) $(TOOLS) vma$(EXESUF) $(HELPERS-y) recurse-all modules
36 $(call quiet-command, \
37 @@ -377,6 +377,7 @@ qemu-img.o: qemu-img-cmds.h
38 qemu-img$(EXESUF): qemu-img.o $(block-obj-y) $(crypto-obj-y) $(io-obj-y) $(qom-obj-y) $(COMMON_LDADDS)
39 qemu-nbd$(EXESUF): qemu-nbd.o $(block-obj-y) $(crypto-obj-y) $(io-obj-y) $(qom-obj-y) $(COMMON_LDADDS)
40 qemu-io$(EXESUF): qemu-io.o $(block-obj-y) $(crypto-obj-y) $(io-obj-y) $(qom-obj-y) $(COMMON_LDADDS)
41 +vma$(EXESUF): vma.o vma-reader.o $(block-obj-y) $(crypto-obj-y) $(io-obj-y) $(qom-obj-y) $(COMMON_LDADDS)
43 qemu-bridge-helper$(EXESUF): qemu-bridge-helper.o $(COMMON_LDADDS)
45 diff --git a/Makefile.objs b/Makefile.objs
46 index fbfbbb7f70..f5f8dbab3b 100644
49 @@ -14,6 +14,7 @@ block-obj-y += block.o blockjob.o
51 block-obj-y += qemu-io-cmds.o
52 block-obj-$(CONFIG_REPLICATION) += replication.o
53 +block-obj-y += vma-writer.o
57 diff --git a/block/backup.c b/block/backup.c
58 index 1ede70c061..51b5ba6eda 100644
61 @@ -36,6 +36,7 @@ typedef struct BackupBlockJob {
62 BdrvDirtyBitmap *sync_bitmap;
63 MirrorSyncMode sync_mode;
65 + BackupDumpFunc *dump_cb;
66 BlockdevOnError on_source_error;
67 BlockdevOnError on_target_error;
68 CoRwlock flush_rwlock;
69 @@ -145,13 +146,24 @@ static int coroutine_fn backup_do_cow(BackupBlockJob *job,
73 + int64_t start_sec = start * sectors_per_cluster;
74 if (buffer_is_zero(iov.iov_base, iov.iov_len)) {
75 - ret = blk_co_pwrite_zeroes(job->target, start * job->cluster_size,
76 - bounce_qiov.size, BDRV_REQ_MAY_UNMAP);
78 + ret = job->dump_cb(job->common.opaque, job->target, start_sec, n, NULL);
81 + ret = blk_co_pwrite_zeroes(job->target, start * job->cluster_size,
82 + bounce_qiov.size, BDRV_REQ_MAY_UNMAP);
85 - ret = blk_co_pwritev(job->target, start * job->cluster_size,
86 - bounce_qiov.size, &bounce_qiov,
87 - job->compress ? BDRV_REQ_WRITE_COMPRESSED : 0);
89 + ret = job->dump_cb(job->common.opaque, job->target, start_sec, n, bounce_buffer);
92 + ret = blk_co_pwritev(job->target, start * job->cluster_size,
93 + bounce_qiov.size, &bounce_qiov,
94 + job->compress ? BDRV_REQ_WRITE_COMPRESSED : 0);
98 trace_backup_do_cow_write_fail(job, start, ret);
99 @@ -246,6 +258,8 @@ static void backup_abort(BlockJob *job)
100 static void backup_clean(BlockJob *job)
102 BackupBlockJob *s = container_of(job, BackupBlockJob, common);
106 blk_unref(s->target);
108 @@ -255,7 +269,8 @@ static void backup_attached_aio_context(BlockJob *job, AioContext *aio_context)
110 BackupBlockJob *s = container_of(job, BackupBlockJob, common);
112 - blk_set_aio_context(s->target, aio_context);
114 + blk_set_aio_context(s->target, aio_context);
117 void backup_do_checkpoint(BlockJob *job, Error **errp)
118 @@ -330,9 +345,11 @@ static BlockErrorAction backup_error_action(BackupBlockJob *job,
120 return block_job_error_action(&job->common, job->on_source_error,
123 + } else if (job->target) {
124 return block_job_error_action(&job->common, job->on_target_error,
127 + return BLOCK_ERROR_ACTION_REPORT;
131 @@ -453,6 +469,7 @@ static void coroutine_fn backup_run(void *opaque)
133 job->done_bitmap = bitmap_new(end);
136 job->before_write.notify = backup_before_write_notify;
137 bdrv_add_before_write_notifier(bs, &job->before_write);
139 @@ -557,6 +574,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
140 BlockdevOnError on_source_error,
141 BlockdevOnError on_target_error,
143 + BackupDumpFunc *dump_cb,
144 BlockCompletionFunc *cb, void *opaque,
146 BlockJobTxn *txn, Error **errp)
147 @@ -567,7 +585,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
152 + assert(target || dump_cb);
155 error_setg(errp, "Source and target cannot be the same");
156 @@ -580,13 +598,13 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
160 - if (!bdrv_is_inserted(target)) {
161 + if (target && !bdrv_is_inserted(target)) {
162 error_setg(errp, "Device is not inserted: %s",
163 bdrv_get_device_name(target));
167 - if (compress && target->drv->bdrv_co_pwritev_compressed == NULL) {
168 + if (target && compress && target->drv->bdrv_co_pwritev_compressed == NULL) {
169 error_setg(errp, "Compression is not supported for this drive %s",
170 bdrv_get_device_name(target));
172 @@ -596,7 +614,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
176 - if (bdrv_op_is_blocked(target, BLOCK_OP_TYPE_BACKUP_TARGET, errp)) {
177 + if (target && bdrv_op_is_blocked(target, BLOCK_OP_TYPE_BACKUP_TARGET, errp)) {
181 @@ -636,15 +654,18 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
185 - /* The target must match the source in size, so no resize here either */
186 - job->target = blk_new(BLK_PERM_WRITE,
187 - BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE |
188 - BLK_PERM_WRITE_UNCHANGED | BLK_PERM_GRAPH_MOD);
189 - ret = blk_insert_bs(job->target, target, errp);
193 + /* The target must match the source in size, so no resize here either */
194 + job->target = blk_new(BLK_PERM_WRITE,
195 + BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE |
196 + BLK_PERM_WRITE_UNCHANGED | BLK_PERM_GRAPH_MOD);
197 + ret = blk_insert_bs(job->target, target, errp);
203 + job->dump_cb = dump_cb;
204 job->on_source_error = on_source_error;
205 job->on_target_error = on_target_error;
206 job->sync_mode = sync_mode;
207 @@ -652,38 +673,55 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
209 job->compress = compress;
211 - /* If there is no backing file on the target, we cannot rely on COW if our
212 - * backup cluster size is smaller than the target cluster size. Even for
213 - * targets with a backing file, try to avoid COW if possible. */
214 - ret = bdrv_get_info(target, &bdi);
215 - if (ret == -ENOTSUP && !target->backing) {
216 - /* Cluster size is not defined */
217 - error_report("WARNING: The target block device doesn't provide "
218 - "information about the block size and it doesn't have a "
219 - "backing file. The default block size of %u bytes is "
220 - "used. If the actual block size of the target exceeds "
221 - "this default, the backup may be unusable",
222 - BACKUP_CLUSTER_SIZE_DEFAULT);
223 - job->cluster_size = BACKUP_CLUSTER_SIZE_DEFAULT;
224 - } else if (ret < 0 && !target->backing) {
225 - error_setg_errno(errp, -ret,
226 - "Couldn't determine the cluster size of the target image, "
227 - "which has no backing file");
228 - error_append_hint(errp,
229 - "Aborting, since this may create an unusable destination image\n");
231 - } else if (ret < 0 && target->backing) {
232 - /* Not fatal; just trudge on ahead. */
233 - job->cluster_size = BACKUP_CLUSTER_SIZE_DEFAULT;
235 + /* If there is no backing file on the target, we cannot rely on COW if our
236 + * backup cluster size is smaller than the target cluster size. Even for
237 + * targets with a backing file, try to avoid COW if possible. */
238 + ret = bdrv_get_info(target, &bdi);
239 + if (ret == -ENOTSUP && !target->backing) {
240 + /* Cluster size is not defined */
241 + error_report("WARNING: The target block device doesn't provide "
242 + "information about the block size and it doesn't have a "
243 + "backing file. The default block size of %u bytes is "
244 + "used. If the actual block size of the target exceeds "
245 + "this default, the backup may be unusable",
246 + BACKUP_CLUSTER_SIZE_DEFAULT);
247 + job->cluster_size = BACKUP_CLUSTER_SIZE_DEFAULT;
248 + } else if (ret < 0 && !target->backing) {
249 + error_setg_errno(errp, -ret,
250 + "Couldn't determine the cluster size of the target image, "
251 + "which has no backing file");
252 + error_append_hint(errp,
253 + "Aborting, since this may create an unusable destination image\n");
255 + } else if (ret < 0 && target->backing) {
256 + /* Not fatal; just trudge on ahead. */
257 + job->cluster_size = BACKUP_CLUSTER_SIZE_DEFAULT;
259 + job->cluster_size = MAX(BACKUP_CLUSTER_SIZE_DEFAULT, bdi.cluster_size);
262 - job->cluster_size = MAX(BACKUP_CLUSTER_SIZE_DEFAULT, bdi.cluster_size);
263 + ret = bdrv_get_info(bs, &bdi);
265 + job->cluster_size = BACKUP_CLUSTER_SIZE_DEFAULT;
267 + /* round down to nearest BACKUP_CLUSTER_SIZE_DEFAULT */
268 + job->cluster_size = (bdi.cluster_size / BACKUP_CLUSTER_SIZE_DEFAULT) * BACKUP_CLUSTER_SIZE_DEFAULT;
269 + if (job->cluster_size == 0) {
270 + /* but we can't go below it */
271 + job->cluster_size = BACKUP_CLUSTER_SIZE_DEFAULT;
276 - /* Required permissions are already taken with target's blk_new() */
277 - block_job_add_bdrv(&job->common, "target", target, 0, BLK_PERM_ALL,
280 + /* Required permissions are already taken with target's blk_new() */
281 + block_job_add_bdrv(&job->common, "target", target, 0, BLK_PERM_ALL,
284 + job->common.pause_count = pause_count;
286 job->common.len = len;
287 - job->common.pause_count = pause_count;
288 block_job_txn_add_job(txn, &job->common);
291 diff --git a/block/replication.c b/block/replication.c
292 index 1c41d9e6bf..60c6524417 100644
293 --- a/block/replication.c
294 +++ b/block/replication.c
295 @@ -531,6 +531,7 @@ static void replication_start(ReplicationState *rs, ReplicationMode mode,
296 0, MIRROR_SYNC_MODE_NONE, NULL, false,
297 BLOCKDEV_ON_ERROR_REPORT,
298 BLOCKDEV_ON_ERROR_REPORT, BLOCK_JOB_INTERNAL,
300 backup_job_completed, bs, 0, NULL, &local_err);
302 error_propagate(errp, local_err);
303 diff --git a/blockdev.c b/blockdev.c
304 index 981276692a..76a7103743 100644
310 #include "qemu/osdep.h"
311 -#include "qemu/uuid.h"
312 #include "sysemu/block-backend.h"
313 #include "sysemu/blockdev.h"
314 #include "hw/block/block.h"
316 #include "qemu/cutils.h"
317 #include "qemu/help_option.h"
318 #include "qemu/throttle-options.h"
321 static QTAILQ_HEAD(, BlockDriverState) monitor_bdrv_states =
322 QTAILQ_HEAD_INITIALIZER(monitor_bdrv_states);
323 @@ -2958,20 +2958,44 @@ out:
324 aio_context_release(aio_context);
327 +void block_job_event_cancelled(BlockJob *job);
328 +void block_job_event_completed(BlockJob *job, const char *msg);
329 +static void block_job_cb(void *opaque, int ret)
331 + /* Note that this function may be executed from another AioContext besides
332 + * the QEMU main loop. If you need to access anything that assumes the
333 + * QEMU global mutex, use a BH or introduce a mutex.
336 + BlockDriverState *bs = opaque;
337 + const char *msg = NULL;
342 + msg = strerror(-ret);
345 + if (block_job_is_cancelled(bs->job)) {
346 + block_job_event_cancelled(bs->job);
348 + block_job_event_completed(bs->job, msg);
352 /* PVE backup related function */
354 static struct PVEBackupState {
371 @@ -2981,6 +3005,7 @@ typedef struct PVEBackupDevInfo {
372 BlockDriverState *bs;
377 char targetfile[PATH_MAX];
378 BlockDriverState *target;
379 @@ -2988,13 +3013,79 @@ typedef struct PVEBackupDevInfo {
381 static void pvebackup_run_next_job(void);
383 +static int pvebackup_dump_cb(void *opaque, BlockBackend *target,
384 + int64_t sector_num, int n_sectors,
385 + unsigned char *buf)
387 + PVEBackupDevInfo *di = opaque;
389 + int size = n_sectors * BDRV_SECTOR_SIZE;
390 + if (backup_state.cancel) {
391 + return size; // return success
394 + if (sector_num & 0x7f) {
395 + if (!backup_state.error) {
396 + error_setg(&backup_state.error,
397 + "got unaligned write inside backup dump "
398 + "callback (sector %ld)", sector_num);
400 + return -1; // not aligned to cluster size
403 + int64_t cluster_num = sector_num >> 7;
407 + if (backup_state.vmaw) {
408 + size_t zero_bytes = 0;
409 + int64_t remaining = n_sectors * BDRV_SECTOR_SIZE;
410 + while (remaining > 0) {
411 + ret = vma_writer_write(backup_state.vmaw, di->dev_id, cluster_num,
415 + buf += VMA_CLUSTER_SIZE;
418 + if (!backup_state.error) {
419 + vma_writer_error_propagate(backup_state.vmaw, &backup_state.error);
421 + if (di->bs && di->bs->job) {
422 + block_job_cancel(di->bs->job);
426 + backup_state.zero_bytes += zero_bytes;
427 + if (remaining >= VMA_CLUSTER_SIZE) {
428 + backup_state.transferred += VMA_CLUSTER_SIZE;
430 + backup_state.transferred += remaining;
432 + remaining -= VMA_CLUSTER_SIZE;
437 + backup_state.zero_bytes += size;
439 + backup_state.transferred += size;
442 + // Note: always return success, because we want that writes succeed anyways.
447 static void pvebackup_cleanup(void)
449 backup_state.end_time = time(NULL);
451 - if (backup_state.vmaobj) {
452 - object_unparent(backup_state.vmaobj);
453 - backup_state.vmaobj = NULL;
454 + if (backup_state.vmaw) {
455 + Error *local_err = NULL;
456 + vma_writer_close(backup_state.vmaw, &local_err);
457 + error_propagate(&backup_state.error, local_err);
458 + backup_state.vmaw = NULL;
461 if (backup_state.di_list) {
462 @@ -3009,6 +3100,13 @@ static void pvebackup_cleanup(void)
466 +static void coroutine_fn backup_close_vma_stream(void *opaque)
468 + PVEBackupDevInfo *di = opaque;
470 + vma_writer_close_stream(backup_state.vmaw, di->dev_id);
473 static void pvebackup_complete_cb(void *opaque, int ret)
475 PVEBackupDevInfo *di = opaque;
476 @@ -3020,14 +3118,18 @@ static void pvebackup_complete_cb(void *opaque, int ret)
477 ret, strerror(-ret));
480 + BlockDriverState *bs = di->bs;
485 - if (backup_state.vmaobj) {
486 - object_unparent(backup_state.vmaobj);
487 - backup_state.vmaobj = NULL;
488 + if (backup_state.vmaw) {
489 + Coroutine *co = qemu_coroutine_create(backup_close_vma_stream, di);
490 + qemu_coroutine_enter(co);
493 + block_job_cb(bs, ret);
495 if (!backup_state.cancel) {
496 pvebackup_run_next_job();
498 @@ -3041,14 +3143,9 @@ static void pvebackup_cancel(void *opaque)
499 error_setg(&backup_state.error, "backup cancelled");
502 - if (backup_state.vmaobj) {
504 + if (backup_state.vmaw) {
505 /* make sure vma writer does not block anymore */
506 - if (!object_set_props(backup_state.vmaobj, &err, "blocked", "yes", NULL)) {
508 - error_report_err(err);
511 + vma_writer_set_error(backup_state.vmaw, "backup cancelled");
514 GList *l = backup_state.di_list;
515 @@ -3073,19 +3170,15 @@ void qmp_backup_cancel(Error **errp)
516 Coroutine *co = qemu_coroutine_create(pvebackup_cancel, NULL);
517 qemu_coroutine_enter(co);
519 - while (backup_state.vmaobj) {
520 - /* FIXME: Find something better for this */
521 + while (backup_state.vmaw) {
522 + /* vma writer use main aio context */
523 aio_poll(qemu_get_aio_context(), true);
527 -void vma_object_add_config_file(Object *obj, const char *name,
528 - const char *contents, size_t len,
530 static int config_to_vma(const char *file, BackupFormat format,
532 - const char *backup_dir,
534 + const char *backup_dir, VmaWriter *vmaw,
539 @@ -3098,12 +3191,17 @@ static int config_to_vma(const char *file, BackupFormat format,
540 char *basename = g_path_get_basename(file);
542 if (format == BACKUP_FORMAT_VMA) {
543 - vma_object_add_config_file(vmaobj, basename, cdata, clen, errp);
544 + if (vma_writer_add_config(vmaw, basename, cdata, clen) != 0) {
545 + error_setg(errp, "unable to add %s config data to vma archive", file);
550 } else if (format == BACKUP_FORMAT_DIR) {
551 char config_path[PATH_MAX];
552 snprintf(config_path, PATH_MAX, "%s/%s", backup_dir, basename);
553 if (!g_file_set_contents(config_path, cdata, clen, &err)) {
554 - error_setg(errp, "unable to write config file '%s'", config_path);
555 + error_setg(errp, "unable to write config file '%s'", config_path);
559 @@ -3113,35 +3211,37 @@ static int config_to_vma(const char *file, BackupFormat format,
567 +bool block_job_should_pause(BlockJob *job);
568 static void pvebackup_run_next_job(void)
570 - bool cancel = backup_state.error || backup_state.cancel;
571 -fprintf(stderr, "run next job: %zu\n", backup_state.next_job);
572 - GList *next = g_list_nth(backup_state.di_list, backup_state.next_job);
574 - PVEBackupDevInfo *di = (PVEBackupDevInfo *)next->data;
575 - backup_state.next_job++;
576 + GList *l = backup_state.di_list;
578 + PVEBackupDevInfo *di = (PVEBackupDevInfo *)l->data;
579 + l = g_list_next(l);
580 if (!di->completed && di->bs && di->bs->job) {
581 BlockJob *job = di->bs->job;
583 - block_job_cancel(job);
585 - block_job_resume(job);
586 + if (block_job_should_pause(job)) {
587 + bool cancel = backup_state.error || backup_state.cancel;
589 + block_job_cancel(job);
591 + block_job_resume(job);
596 - next = g_list_next(next);
602 UuidInfo *qmp_backup(const char *backup_file, bool has_format,
604 bool has_config_file, const char *config_file,
605 - bool has_firewall_file, const char *firewall_file,
606 + bool has_firewall_file, const char *firewall_file,
607 bool has_devlist, const char *devlist,
608 bool has_speed, int64_t speed, Error **errp)
610 @@ -3149,14 +3249,15 @@ UuidInfo *qmp_backup(const char *backup_file, bool has_format,
611 BlockDriverState *bs = NULL;
612 const char *backup_dir = NULL;
613 Error *local_err = NULL;
616 + VmaWriter *vmaw = NULL;
618 GList *di_list = NULL;
623 - if (backup_state.di_list || backup_state.vmaobj) {
624 + if (backup_state.di_list) {
625 error_set(errp, ERROR_CLASS_GENERIC_ERROR,
626 "previous backup not finished");
628 @@ -3231,40 +3332,28 @@ UuidInfo *qmp_backup(const char *backup_file, bool has_format,
632 - qemu_uuid_generate(&uuid);
633 + uuid_generate(uuid);
635 if (format == BACKUP_FORMAT_VMA) {
636 - char uuidstr[UUID_FMT_LEN+1];
637 - qemu_uuid_unparse(&uuid, uuidstr);
638 - uuidstr[UUID_FMT_LEN] = 0;
639 - backup_state.vmaobj =
640 - object_new_with_props("vma", object_get_objects_root(),
641 - "vma-backup-obj", &local_err,
642 - "filename", backup_file,
645 - if (!backup_state.vmaobj) {
646 + vmaw = vma_writer_create(backup_file, uuid, &local_err);
649 error_propagate(errp, local_err);
654 + /* register all devices for vma writer */
657 - QDict *options = qdict_new();
659 PVEBackupDevInfo *di = (PVEBackupDevInfo *)l->data;
662 const char *devname = bdrv_get_device_name(di->bs);
663 - snprintf(di->targetfile, PATH_MAX, "vma-backup-obj/%s.raw", devname);
665 - qdict_put(options, "driver", qstring_from_str("vma-drive"));
666 - qdict_put(options, "size", qint_from_int(di->size));
667 - di->target = bdrv_open(di->targetfile, NULL, options, BDRV_O_RDWR, &local_err);
669 - error_propagate(errp, local_err);
670 + di->dev_id = vma_writer_register_stream(vmaw, devname, di->size);
671 + if (di->dev_id <= 0) {
672 + error_set(errp, ERROR_CLASS_GENERIC_ERROR,
673 + "register_stream failed");
677 @@ -3305,15 +3394,15 @@ UuidInfo *qmp_backup(const char *backup_file, bool has_format,
679 /* add configuration file to archive */
680 if (has_config_file) {
681 - if(config_to_vma(config_file, format, backup_state.vmaobj, backup_dir, errp) != 0) {
683 + if(config_to_vma(config_file, format, backup_dir, vmaw, errp) != 0) {
688 /* add firewall file to archive */
689 if (has_firewall_file) {
690 - if(config_to_vma(firewall_file, format, backup_state.vmaobj, backup_dir, errp) != 0) {
692 + if(config_to_vma(firewall_file, format, backup_dir, vmaw, errp) != 0) {
696 /* initialize global backup_state now */
697 @@ -3335,11 +3424,12 @@ UuidInfo *qmp_backup(const char *backup_file, bool has_format,
699 backup_state.backup_file = g_strdup(backup_file);
701 - memcpy(&backup_state.uuid, &uuid, sizeof(uuid));
702 - qemu_uuid_unparse(&uuid, backup_state.uuid_str);
703 + backup_state.vmaw = vmaw;
705 + uuid_copy(backup_state.uuid, uuid);
706 + uuid_unparse_lower(uuid, backup_state.uuid_str);
708 backup_state.di_list = di_list;
709 - backup_state.next_job = 0;
711 backup_state.total = total;
712 backup_state.transferred = 0;
713 @@ -3350,21 +3440,16 @@ UuidInfo *qmp_backup(const char *backup_file, bool has_format,
715 PVEBackupDevInfo *di = (PVEBackupDevInfo *)l->data;
718 job = backup_job_create(NULL, di->bs, di->target, speed, MIRROR_SYNC_MODE_FULL, NULL,
719 false, BLOCKDEV_ON_ERROR_REPORT, BLOCKDEV_ON_ERROR_REPORT,
721 - pvebackup_complete_cb, di, 2, NULL, &local_err);
723 - bdrv_unref(di->target);
726 + pvebackup_dump_cb, pvebackup_complete_cb, di,
727 + 2, NULL, &local_err);
728 if (!job || local_err != NULL) {
729 error_setg(&backup_state.error, "backup_job_create failed");
730 pvebackup_cancel(NULL);
732 - block_job_start(job);
734 + block_job_start(job);
737 if (!backup_state.error) {
738 @@ -3398,9 +3483,10 @@ err:
742 - if (backup_state.vmaobj) {
743 - object_unparent(backup_state.vmaobj);
744 - backup_state.vmaobj = NULL;
747 + vma_writer_close(vmaw, &err);
748 + unlink(backup_file);
752 @@ -3772,7 +3858,7 @@ static BlockJob *do_drive_backup(DriveBackup *backup, BlockJobTxn *txn,
753 job = backup_job_create(backup->job_id, bs, target_bs, backup->speed,
754 backup->sync, bmap, backup->compress,
755 backup->on_source_error, backup->on_target_error,
756 - BLOCK_JOB_DEFAULT, NULL, NULL, 0, txn, &local_err);
757 + BLOCK_JOB_DEFAULT, NULL, NULL, NULL, 0, txn, &local_err);
758 bdrv_unref(target_bs);
759 if (local_err != NULL) {
760 error_propagate(errp, local_err);
761 @@ -3851,7 +3937,7 @@ BlockJob *do_blockdev_backup(BlockdevBackup *backup, BlockJobTxn *txn,
762 job = backup_job_create(backup->job_id, bs, target_bs, backup->speed,
763 backup->sync, NULL, backup->compress,
764 backup->on_source_error, backup->on_target_error,
765 - BLOCK_JOB_DEFAULT, NULL, NULL, 0, txn, &local_err);
766 + BLOCK_JOB_DEFAULT, NULL, NULL, NULL, 0, txn, &local_err);
767 if (local_err != NULL) {
768 error_propagate(errp, local_err);
770 diff --git a/blockjob.c b/blockjob.c
771 index 764d41863e..cb3741f6dd 100644
775 #include "qemu/timer.h"
776 #include "qapi-event.h"
778 -static void block_job_event_cancelled(BlockJob *job);
779 -static void block_job_event_completed(BlockJob *job, const char *msg);
780 +void block_job_event_cancelled(BlockJob *job);
781 +void block_job_event_completed(BlockJob *job, const char *msg);
783 /* Transactional group of block jobs */
785 @@ -473,7 +473,8 @@ void block_job_user_pause(BlockJob *job)
786 block_job_pause(job);
789 -static bool block_job_should_pause(BlockJob *job)
790 +bool block_job_should_pause(BlockJob *job);
791 +bool block_job_should_pause(BlockJob *job)
793 return job->pause_count > 0;
795 @@ -687,7 +688,7 @@ static void block_job_iostatus_set_err(BlockJob *job, int error)
799 -static void block_job_event_cancelled(BlockJob *job)
800 +void block_job_event_cancelled(BlockJob *job)
802 if (block_job_is_internal(job)) {
804 @@ -701,7 +702,7 @@ static void block_job_event_cancelled(BlockJob *job)
808 -static void block_job_event_completed(BlockJob *job, const char *msg)
809 +void block_job_event_completed(BlockJob *job, const char *msg)
811 if (block_job_is_internal(job)) {
813 diff --git a/include/block/block_int.h b/include/block/block_int.h
814 index 2b3ecd0575..278da161fb 100644
815 --- a/include/block/block_int.h
816 +++ b/include/block/block_int.h
819 #define BLOCK_PROBE_BUF_SIZE 512
821 +typedef int BackupDumpFunc(void *opaque, BlockBackend *be,
822 + int64_t sector_num, int n_sectors, unsigned char *buf);
824 enum BdrvTrackedRequestType {
827 @@ -877,6 +880,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
828 BlockdevOnError on_source_error,
829 BlockdevOnError on_target_error,
831 + BackupDumpFunc *dump_cb,
832 BlockCompletionFunc *cb, void *opaque,
834 BlockJobTxn *txn, Error **errp);
835 diff --git a/vma-reader.c b/vma-reader.c
837 index 0000000000..2000889bd3
842 + * VMA: Virtual Machine Archive
844 + * Copyright (C) 2012 Proxmox Server Solutions
847 + * Dietmar Maurer (dietmar@proxmox.com)
849 + * This work is licensed under the terms of the GNU GPL, version 2 or later.
850 + * See the COPYING file in the top-level directory.
854 +#include "qemu/osdep.h"
856 +#include <uuid/uuid.h>
858 +#include "qemu-common.h"
859 +#include "qemu/timer.h"
860 +#include "qemu/ratelimit.h"
862 +#include "block/block.h"
863 +#include "sysemu/block-backend.h"
865 +static unsigned char zero_vma_block[VMA_BLOCK_SIZE];
867 +typedef struct VmaRestoreState {
868 + BlockBackend *target;
870 + unsigned long *bitmap;
876 + GChecksum *md5csum;
877 + GHashTable *blob_hash;
878 + unsigned char *head_data;
879 + VmaDeviceInfo devinfo[256];
880 + VmaRestoreState rstate[256];
882 + guint8 vmstate_stream;
883 + uint32_t vmstate_clusters;
884 + /* to show restore percentage if run with -v */
886 + int64_t cluster_count;
887 + int64_t clusters_read;
888 + int64_t zero_cluster_data;
889 + int64_t partial_zero_cluster_data;
890 + int clusters_read_per;
894 +g_int32_hash(gconstpointer v)
896 + return *(const uint32_t *)v;
900 +g_int32_equal(gconstpointer v1, gconstpointer v2)
902 + return *((const uint32_t *)v1) == *((const uint32_t *)v2);
905 +static int vma_reader_get_bitmap(VmaRestoreState *rstate, int64_t cluster_num)
908 + assert(rstate->bitmap);
910 + unsigned long val, idx, bit;
912 + idx = cluster_num / BITS_PER_LONG;
914 + assert(rstate->bitmap_size > idx);
916 + bit = cluster_num % BITS_PER_LONG;
917 + val = rstate->bitmap[idx];
919 + return !!(val & (1UL << bit));
922 +static void vma_reader_set_bitmap(VmaRestoreState *rstate, int64_t cluster_num,
926 + assert(rstate->bitmap);
928 + unsigned long val, idx, bit;
930 + idx = cluster_num / BITS_PER_LONG;
932 + assert(rstate->bitmap_size > idx);
934 + bit = cluster_num % BITS_PER_LONG;
935 + val = rstate->bitmap[idx];
937 + if (!(val & (1UL << bit))) {
941 + if (val & (1UL << bit)) {
942 + val &= ~(1UL << bit);
945 + rstate->bitmap[idx] = val;
948 +typedef struct VmaBlob {
954 +static const VmaBlob *get_header_blob(VmaReader *vmar, uint32_t pos)
957 + assert(vmar->blob_hash);
959 + return g_hash_table_lookup(vmar->blob_hash, &pos);
962 +static const char *get_header_str(VmaReader *vmar, uint32_t pos)
964 + const VmaBlob *blob = get_header_blob(vmar, pos);
968 + const char *res = (char *)blob->data;
969 + if (res[blob->len-1] != '\0') {
976 +safe_read(int fd, unsigned char *buf, size_t count)
981 + n = read(fd, buf, count);
982 + } while (n < 0 && errno == EINTR);
988 +full_read(int fd, unsigned char *buf, size_t len)
996 + n = safe_read(fd, buf, len);
1018 +void vma_reader_destroy(VmaReader *vmar)
1022 + if (vmar->fd >= 0) {
1026 + if (vmar->cdata_list) {
1027 + g_list_free(vmar->cdata_list);
1031 + for (i = 1; i < 256; i++) {
1032 + if (vmar->rstate[i].bitmap) {
1033 + g_free(vmar->rstate[i].bitmap);
1037 + if (vmar->md5csum) {
1038 + g_checksum_free(vmar->md5csum);
1041 + if (vmar->blob_hash) {
1042 + g_hash_table_destroy(vmar->blob_hash);
1045 + if (vmar->head_data) {
1046 + g_free(vmar->head_data);
1053 +static int vma_reader_read_head(VmaReader *vmar, Error **errp)
1057 + assert(*errp == NULL);
1059 + unsigned char md5sum[16];
1063 + vmar->head_data = g_malloc(sizeof(VmaHeader));
1065 + if (full_read(vmar->fd, vmar->head_data, sizeof(VmaHeader)) !=
1066 + sizeof(VmaHeader)) {
1067 + error_setg(errp, "can't read vma header - %s",
1068 + errno ? g_strerror(errno) : "got EOF");
1072 + VmaHeader *h = (VmaHeader *)vmar->head_data;
1074 + if (h->magic != VMA_MAGIC) {
1075 + error_setg(errp, "not a vma file - wrong magic number");
1079 + uint32_t header_size = GUINT32_FROM_BE(h->header_size);
1080 + int need = header_size - sizeof(VmaHeader);
1082 + error_setg(errp, "wrong vma header size %d", header_size);
1086 + vmar->head_data = g_realloc(vmar->head_data, header_size);
1087 + h = (VmaHeader *)vmar->head_data;
1089 + if (full_read(vmar->fd, vmar->head_data + sizeof(VmaHeader), need) !=
1091 + error_setg(errp, "can't read vma header data - %s",
1092 + errno ? g_strerror(errno) : "got EOF");
1096 + memcpy(md5sum, h->md5sum, 16);
1097 + memset(h->md5sum, 0, 16);
1099 + g_checksum_reset(vmar->md5csum);
1100 + g_checksum_update(vmar->md5csum, vmar->head_data, header_size);
1102 + g_checksum_get_digest(vmar->md5csum, (guint8 *)(h->md5sum), &csize);
1104 + if (memcmp(md5sum, h->md5sum, 16) != 0) {
1105 + error_setg(errp, "wrong vma header chechsum");
1109 + /* we can modify header data after checksum verify */
1110 + h->header_size = header_size;
1112 + h->version = GUINT32_FROM_BE(h->version);
1113 + if (h->version != 1) {
1114 + error_setg(errp, "wrong vma version %d", h->version);
1118 + h->ctime = GUINT64_FROM_BE(h->ctime);
1119 + h->blob_buffer_offset = GUINT32_FROM_BE(h->blob_buffer_offset);
1120 + h->blob_buffer_size = GUINT32_FROM_BE(h->blob_buffer_size);
1122 + uint32_t bstart = h->blob_buffer_offset + 1;
1123 + uint32_t bend = h->blob_buffer_offset + h->blob_buffer_size;
1125 + if (bstart <= sizeof(VmaHeader)) {
1126 + error_setg(errp, "wrong vma blob buffer offset %d",
1127 + h->blob_buffer_offset);
1131 + if (bend > header_size) {
1132 + error_setg(errp, "wrong vma blob buffer size %d/%d",
1133 + h->blob_buffer_offset, h->blob_buffer_size);
1137 + while ((bstart + 2) <= bend) {
1138 + uint32_t size = vmar->head_data[bstart] +
1139 + (vmar->head_data[bstart+1] << 8);
1140 + if ((bstart + size + 2) <= bend) {
1141 + VmaBlob *blob = g_new0(VmaBlob, 1);
1142 + blob->start = bstart - h->blob_buffer_offset;
1144 + blob->data = vmar->head_data + bstart + 2;
1145 + g_hash_table_insert(vmar->blob_hash, &blob->start, blob);
1147 + bstart += size + 2;
1152 + for (i = 1; i < 256; i++) {
1153 + VmaDeviceInfoHeader *dih = &h->dev_info[i];
1154 + uint32_t devname_ptr = GUINT32_FROM_BE(dih->devname_ptr);
1155 + uint64_t size = GUINT64_FROM_BE(dih->size);
1156 + const char *devname = get_header_str(vmar, devname_ptr);
1158 + if (size && devname) {
1160 + vmar->devinfo[i].size = size;
1161 + vmar->devinfo[i].devname = devname;
1163 + if (strcmp(devname, "vmstate") == 0) {
1164 + vmar->vmstate_stream = i;
1169 + for (i = 0; i < VMA_MAX_CONFIGS; i++) {
1170 + uint32_t name_ptr = GUINT32_FROM_BE(h->config_names[i]);
1171 + uint32_t data_ptr = GUINT32_FROM_BE(h->config_data[i]);
1173 + if (!(name_ptr && data_ptr)) {
1176 + const char *name = get_header_str(vmar, name_ptr);
1177 + const VmaBlob *blob = get_header_blob(vmar, data_ptr);
1179 + if (!(name && blob)) {
1180 + error_setg(errp, "vma contains invalid data pointers");
1184 + VmaConfigData *cdata = g_new0(VmaConfigData, 1);
1185 + cdata->name = name;
1186 + cdata->data = blob->data;
1187 + cdata->len = blob->len;
1189 + vmar->cdata_list = g_list_append(vmar->cdata_list, cdata);
1195 +VmaReader *vma_reader_create(const char *filename, Error **errp)
1200 + VmaReader *vmar = g_new0(VmaReader, 1);
1202 + if (strcmp(filename, "-") == 0) {
1203 + vmar->fd = dup(0);
1205 + vmar->fd = open(filename, O_RDONLY);
1208 + if (vmar->fd < 0) {
1209 + error_setg(errp, "can't open file %s - %s\n", filename,
1210 + g_strerror(errno));
1214 + vmar->md5csum = g_checksum_new(G_CHECKSUM_MD5);
1215 + if (!vmar->md5csum) {
1216 + error_setg(errp, "can't allocate cmsum\n");
1220 + vmar->blob_hash = g_hash_table_new_full(g_int32_hash, g_int32_equal,
1223 + if (vma_reader_read_head(vmar, errp) < 0) {
1231 + vma_reader_destroy(vmar);
1237 +VmaHeader *vma_reader_get_header(VmaReader *vmar)
1240 + assert(vmar->head_data);
1242 + return (VmaHeader *)(vmar->head_data);
1245 +GList *vma_reader_get_config_data(VmaReader *vmar)
1248 + assert(vmar->head_data);
1250 + return vmar->cdata_list;
1253 +VmaDeviceInfo *vma_reader_get_device_info(VmaReader *vmar, guint8 dev_id)
1258 + if (vmar->devinfo[dev_id].size && vmar->devinfo[dev_id].devname) {
1259 + return &vmar->devinfo[dev_id];
1265 +static void allocate_rstate(VmaReader *vmar, guint8 dev_id,
1266 + BlockBackend *target, bool write_zeroes)
1271 + vmar->rstate[dev_id].target = target;
1272 + vmar->rstate[dev_id].write_zeroes = write_zeroes;
1274 + int64_t size = vmar->devinfo[dev_id].size;
1276 + int64_t bitmap_size = (size/BDRV_SECTOR_SIZE) +
1277 + (VMA_CLUSTER_SIZE/BDRV_SECTOR_SIZE) * BITS_PER_LONG - 1;
1278 + bitmap_size /= (VMA_CLUSTER_SIZE/BDRV_SECTOR_SIZE) * BITS_PER_LONG;
1280 + vmar->rstate[dev_id].bitmap_size = bitmap_size;
1281 + vmar->rstate[dev_id].bitmap = g_new0(unsigned long, bitmap_size);
1283 + vmar->cluster_count += size/VMA_CLUSTER_SIZE;
1286 +int vma_reader_register_bs(VmaReader *vmar, guint8 dev_id, BlockBackend *target,
1287 + bool write_zeroes, Error **errp)
1290 + assert(target != NULL);
1292 + assert(vmar->rstate[dev_id].target == NULL);
1294 + int64_t size = blk_getlength(target);
1295 + int64_t size_diff = size - vmar->devinfo[dev_id].size;
1297 + /* storage types can have different size restrictions, so it
1298 + * is not always possible to create an image with exact size.
1299 + * So we tolerate a size difference up to 4MB.
1301 + if ((size_diff < 0) || (size_diff > 4*1024*1024)) {
1302 + error_setg(errp, "vma_reader_register_bs for stream %s failed - "
1303 + "unexpected size %zd != %zd", vmar->devinfo[dev_id].devname,
1304 + size, vmar->devinfo[dev_id].size);
1308 + allocate_rstate(vmar, dev_id, target, write_zeroes);
1313 +static ssize_t safe_write(int fd, void *buf, size_t count)
1318 + n = write(fd, buf, count);
1319 + } while (n < 0 && errno == EINTR);
1324 +static size_t full_write(int fd, void *buf, size_t len)
1332 + n = safe_write(fd, buf, len);
1342 + /* incomplete write ? */
1349 +static int restore_write_data(VmaReader *vmar, guint8 dev_id,
1350 + BlockBackend *target, int vmstate_fd,
1351 + unsigned char *buf, int64_t sector_num,
1352 + int nb_sectors, Error **errp)
1356 + if (dev_id == vmar->vmstate_stream) {
1357 + if (vmstate_fd >= 0) {
1358 + int len = nb_sectors * BDRV_SECTOR_SIZE;
1359 + int res = full_write(vmstate_fd, buf, len);
1361 + error_setg(errp, "write vmstate failed %d", res);
1366 + int res = blk_pwrite(target, sector_num * BDRV_SECTOR_SIZE, buf, nb_sectors * BDRV_SECTOR_SIZE, 0);
1368 + error_setg(errp, "blk_pwrite to %s failed (%d)",
1369 + bdrv_get_device_name(blk_bs(target)), res);
1376 +static int restore_extent(VmaReader *vmar, unsigned char *buf,
1377 + int extent_size, int vmstate_fd,
1378 + bool verbose, bool verify, Error **errp)
1383 + VmaExtentHeader *ehead = (VmaExtentHeader *)buf;
1384 + int start = VMA_EXTENT_HEADER_SIZE;
1387 + for (i = 0; i < VMA_BLOCKS_PER_EXTENT; i++) {
1388 + uint64_t block_info = GUINT64_FROM_BE(ehead->blockinfo[i]);
1389 + uint64_t cluster_num = block_info & 0xffffffff;
1390 + uint8_t dev_id = (block_info >> 32) & 0xff;
1391 + uint16_t mask = block_info >> (32+16);
1392 + int64_t max_sector;
1398 + VmaRestoreState *rstate = &vmar->rstate[dev_id];
1399 + BlockBackend *target = NULL;
1401 + if (dev_id != vmar->vmstate_stream) {
1402 + target = rstate->target;
1403 + if (!verify && !target) {
1404 + error_setg(errp, "got wrong dev id %d", dev_id);
1408 + if (vma_reader_get_bitmap(rstate, cluster_num)) {
1409 + error_setg(errp, "found duplicated cluster %zd for stream %s",
1410 + cluster_num, vmar->devinfo[dev_id].devname);
1413 + vma_reader_set_bitmap(rstate, cluster_num, 1);
1415 + max_sector = vmar->devinfo[dev_id].size/BDRV_SECTOR_SIZE;
1417 + max_sector = G_MAXINT64;
1418 + if (cluster_num != vmar->vmstate_clusters) {
1419 + error_setg(errp, "found out of order vmstate data");
1422 + vmar->vmstate_clusters++;
1425 + vmar->clusters_read++;
1428 + time_t duration = time(NULL) - vmar->start_time;
1429 + int percent = (vmar->clusters_read*100)/vmar->cluster_count;
1430 + if (percent != vmar->clusters_read_per) {
1431 + printf("progress %d%% (read %zd bytes, duration %zd sec)\n",
1432 + percent, vmar->clusters_read*VMA_CLUSTER_SIZE,
1435 + vmar->clusters_read_per = percent;
1439 + /* try to write whole clusters to speedup restore */
1440 + if (mask == 0xffff) {
1441 + if ((start + VMA_CLUSTER_SIZE) > extent_size) {
1442 + error_setg(errp, "short vma extent - too many blocks");
1445 + int64_t sector_num = (cluster_num * VMA_CLUSTER_SIZE) /
1447 + int64_t end_sector = sector_num +
1448 + VMA_CLUSTER_SIZE/BDRV_SECTOR_SIZE;
1450 + if (end_sector > max_sector) {
1451 + end_sector = max_sector;
1454 + if (end_sector <= sector_num) {
1455 + error_setg(errp, "got wrong block address - write bejond end");
1460 + int nb_sectors = end_sector - sector_num;
1461 + if (restore_write_data(vmar, dev_id, target, vmstate_fd,
1462 + buf + start, sector_num, nb_sectors,
1468 + start += VMA_CLUSTER_SIZE;
1473 + for (j = 0; j < 16; j++) {
1474 + int64_t sector_num = (cluster_num*VMA_CLUSTER_SIZE +
1475 + j*VMA_BLOCK_SIZE)/BDRV_SECTOR_SIZE;
1477 + int64_t end_sector = sector_num +
1478 + VMA_BLOCK_SIZE/BDRV_SECTOR_SIZE;
1479 + if (end_sector > max_sector) {
1480 + end_sector = max_sector;
1484 + if ((start + VMA_BLOCK_SIZE) > extent_size) {
1485 + error_setg(errp, "short vma extent - too many blocks");
1489 + if (end_sector <= sector_num) {
1490 + error_setg(errp, "got wrong block address - "
1491 + "write bejond end");
1496 + int nb_sectors = end_sector - sector_num;
1497 + if (restore_write_data(vmar, dev_id, target, vmstate_fd,
1498 + buf + start, sector_num,
1499 + nb_sectors, errp) < 0) {
1504 + start += VMA_BLOCK_SIZE;
1509 + if (end_sector > sector_num) {
1510 + /* Todo: use bdrv_co_write_zeroes (but that need to
1511 + * be run inside coroutine?)
1513 + int nb_sectors = end_sector - sector_num;
1514 + int zero_size = BDRV_SECTOR_SIZE*nb_sectors;
1515 + vmar->zero_cluster_data += zero_size;
1517 + vmar->partial_zero_cluster_data += zero_size;
1520 + if (rstate->write_zeroes && !verify) {
1521 + if (restore_write_data(vmar, dev_id, target, vmstate_fd,
1522 + zero_vma_block, sector_num,
1523 + nb_sectors, errp) < 0) {
1535 + if (start != extent_size) {
1536 + error_setg(errp, "vma extent error - missing blocks");
1543 +static int vma_reader_restore_full(VmaReader *vmar, int vmstate_fd,
1544 + bool verbose, bool verify,
1548 + assert(vmar->head_data);
1551 + unsigned char buf[VMA_MAX_EXTENT_SIZE];
1553 + unsigned char md5sum[16];
1554 + VmaHeader *h = (VmaHeader *)vmar->head_data;
1556 + vmar->start_time = time(NULL);
1559 + int bytes = full_read(vmar->fd, buf + buf_pos, sizeof(buf) - buf_pos);
1561 + error_setg(errp, "read failed - %s", g_strerror(errno));
1571 + if (buf_pos < VMA_EXTENT_HEADER_SIZE) {
1572 + error_setg(errp, "read short extent (%d bytes)", buf_pos);
1576 + VmaExtentHeader *ehead = (VmaExtentHeader *)buf;
1578 + /* extract md5sum */
1579 + memcpy(md5sum, ehead->md5sum, sizeof(ehead->md5sum));
1580 + memset(ehead->md5sum, 0, sizeof(ehead->md5sum));
1582 + g_checksum_reset(vmar->md5csum);
1583 + g_checksum_update(vmar->md5csum, buf, VMA_EXTENT_HEADER_SIZE);
1585 + g_checksum_get_digest(vmar->md5csum, ehead->md5sum, &csize);
1587 + if (memcmp(md5sum, ehead->md5sum, 16) != 0) {
1588 + error_setg(errp, "wrong vma extent header chechsum");
1592 + if (memcmp(h->uuid, ehead->uuid, sizeof(ehead->uuid)) != 0) {
1593 + error_setg(errp, "wrong vma extent uuid");
1597 + if (ehead->magic != VMA_EXTENT_MAGIC || ehead->reserved1 != 0) {
1598 + error_setg(errp, "wrong vma extent header magic");
1602 + int block_count = GUINT16_FROM_BE(ehead->block_count);
1603 + int extent_size = VMA_EXTENT_HEADER_SIZE + block_count*VMA_BLOCK_SIZE;
1605 + if (buf_pos < extent_size) {
1606 + error_setg(errp, "short vma extent (%d < %d)", buf_pos,
1611 + if (restore_extent(vmar, buf, extent_size, vmstate_fd, verbose,
1612 + verify, errp) < 0) {
1616 + if (buf_pos > extent_size) {
1617 + memmove(buf, buf + extent_size, buf_pos - extent_size);
1618 + buf_pos = buf_pos - extent_size;
1627 + for (i = 1; i < 256; i++) {
1628 + VmaRestoreState *rstate = &vmar->rstate[i];
1629 + if (!rstate->target) {
1633 + if (blk_flush(rstate->target) < 0) {
1634 + error_setg(errp, "vma blk_flush %s failed",
1635 + vmar->devinfo[i].devname);
1639 + if (vmar->devinfo[i].size &&
1640 + (strcmp(vmar->devinfo[i].devname, "vmstate") != 0)) {
1641 + assert(rstate->bitmap);
1643 + int64_t cluster_num, end;
1645 + end = (vmar->devinfo[i].size + VMA_CLUSTER_SIZE - 1) /
1648 + for (cluster_num = 0; cluster_num < end; cluster_num++) {
1649 + if (!vma_reader_get_bitmap(rstate, cluster_num)) {
1650 + error_setg(errp, "detected missing cluster %zd "
1651 + "for stream %s", cluster_num,
1652 + vmar->devinfo[i].devname);
1660 + if (vmar->clusters_read) {
1661 + printf("total bytes read %zd, sparse bytes %zd (%.3g%%)\n",
1662 + vmar->clusters_read*VMA_CLUSTER_SIZE,
1663 + vmar->zero_cluster_data,
1664 + (double)(100.0*vmar->zero_cluster_data)/
1665 + (vmar->clusters_read*VMA_CLUSTER_SIZE));
1667 + int64_t datasize = vmar->clusters_read*VMA_CLUSTER_SIZE-vmar->zero_cluster_data;
1668 + if (datasize) { // this does not make sense for empty files
1669 + printf("space reduction due to 4K zero blocks %.3g%%\n",
1670 + (double)(100.0*vmar->partial_zero_cluster_data) / datasize);
1673 + printf("vma archive contains no image data\n");
1679 +int vma_reader_restore(VmaReader *vmar, int vmstate_fd, bool verbose,
1682 + return vma_reader_restore_full(vmar, vmstate_fd, verbose, false, errp);
1685 +int vma_reader_verify(VmaReader *vmar, bool verbose, Error **errp)
1689 + for (dev_id = 1; dev_id < 255; dev_id++) {
1690 + if (vma_reader_get_device_info(vmar, dev_id)) {
1691 + allocate_rstate(vmar, dev_id, NULL, false);
1695 + return vma_reader_restore_full(vmar, -1, verbose, true, errp);
1698 diff --git a/vma-writer.c b/vma-writer.c
1699 new file mode 100644
1700 index 0000000000..9001cbdd2b
1705 + * VMA: Virtual Machine Archive
1707 + * Copyright (C) 2012 Proxmox Server Solutions
1710 + * Dietmar Maurer (dietmar@proxmox.com)
1712 + * This work is licensed under the terms of the GNU GPL, version 2 or later.
1713 + * See the COPYING file in the top-level directory.
1717 +#include "qemu/osdep.h"
1719 +#include <uuid/uuid.h>
1722 +#include "block/block.h"
1723 +#include "monitor/monitor.h"
1724 +#include "qemu/main-loop.h"
1725 +#include "qemu/coroutine.h"
1726 +#include "qemu/cutils.h"
1728 +#define DEBUG_VMA 0
1730 +#define DPRINTF(fmt, ...)\
1731 + do { if (DEBUG_VMA) { printf("vma: " fmt, ## __VA_ARGS__); } } while (0)
1733 +#define WRITE_BUFFERS 5
1734 +#define HEADER_CLUSTERS 8
1735 +#define HEADERBUF_SIZE (VMA_CLUSTER_SIZE*HEADER_CLUSTERS)
1741 + char errmsg[8192];
1743 + bool header_written;
1746 + /* we always write extents */
1747 + unsigned char *outbuf;
1748 + int outbuf_pos; /* in bytes */
1749 + int outbuf_count; /* in VMA_BLOCKS */
1750 + uint64_t outbuf_block_info[VMA_BLOCKS_PER_EXTENT];
1752 + unsigned char *headerbuf;
1754 + GChecksum *md5csum;
1755 + CoMutex flush_lock;
1756 + Coroutine *co_writer;
1758 + /* drive informations */
1759 + VmaStreamInfo stream_info[256];
1760 + guint stream_count;
1762 + guint8 vmstate_stream;
1763 + uint32_t vmstate_clusters;
1765 + /* header blob table */
1766 + char *header_blob_table;
1767 + uint32_t header_blob_table_size;
1768 + uint32_t header_blob_table_pos;
1770 + /* store for config blobs */
1771 + uint32_t config_names[VMA_MAX_CONFIGS]; /* offset into blob_buffer table */
1772 + uint32_t config_data[VMA_MAX_CONFIGS]; /* offset into blob_buffer table */
1773 + uint32_t config_count;
1776 +void vma_writer_set_error(VmaWriter *vmaw, const char *fmt, ...)
1780 + if (vmaw->status < 0) {
1784 + vmaw->status = -1;
1786 + va_start(ap, fmt);
1787 + g_vsnprintf(vmaw->errmsg, sizeof(vmaw->errmsg), fmt, ap);
1790 + DPRINTF("vma_writer_set_error: %s\n", vmaw->errmsg);
1793 +static uint32_t allocate_header_blob(VmaWriter *vmaw, const char *data,
1796 + if (len > 65535) {
1800 + if (!vmaw->header_blob_table ||
1801 + (vmaw->header_blob_table_size <
1802 + (vmaw->header_blob_table_pos + len + 2))) {
1803 + int newsize = vmaw->header_blob_table_size + ((len + 2 + 511)/512)*512;
1805 + vmaw->header_blob_table = g_realloc(vmaw->header_blob_table, newsize);
1806 + memset(vmaw->header_blob_table + vmaw->header_blob_table_size,
1807 + 0, newsize - vmaw->header_blob_table_size);
1808 + vmaw->header_blob_table_size = newsize;
1811 + uint32_t cpos = vmaw->header_blob_table_pos;
1812 + vmaw->header_blob_table[cpos] = len & 255;
1813 + vmaw->header_blob_table[cpos+1] = (len >> 8) & 255;
1814 + memcpy(vmaw->header_blob_table + cpos + 2, data, len);
1815 + vmaw->header_blob_table_pos += len + 2;
1819 +static uint32_t allocate_header_string(VmaWriter *vmaw, const char *str)
1823 + size_t len = strlen(str) + 1;
1825 + return allocate_header_blob(vmaw, str, len);
1828 +int vma_writer_add_config(VmaWriter *vmaw, const char *name, gpointer data,
1832 + assert(!vmaw->header_written);
1833 + assert(vmaw->config_count < VMA_MAX_CONFIGS);
1837 + gchar *basename = g_path_get_basename(name);
1838 + uint32_t name_ptr = allocate_header_string(vmaw, basename);
1845 + uint32_t data_ptr = allocate_header_blob(vmaw, data, len);
1850 + vmaw->config_names[vmaw->config_count] = name_ptr;
1851 + vmaw->config_data[vmaw->config_count] = data_ptr;
1853 + vmaw->config_count++;
1858 +int vma_writer_register_stream(VmaWriter *vmaw, const char *devname,
1863 + assert(!vmaw->status);
1865 + if (vmaw->header_written) {
1866 + vma_writer_set_error(vmaw, "vma_writer_register_stream: header "
1867 + "already written");
1871 + guint n = vmaw->stream_count + 1;
1873 + /* we can have dev_ids form 1 to 255 (0 reserved)
1874 + * 255(-1) reseverd for safety
1877 + vma_writer_set_error(vmaw, "vma_writer_register_stream: "
1878 + "too many drives");
1883 + vma_writer_set_error(vmaw, "vma_writer_register_stream: "
1884 + "got strange size %zd", size);
1888 + DPRINTF("vma_writer_register_stream %s %zu %d\n", devname, size, n);
1890 + vmaw->stream_info[n].devname = g_strdup(devname);
1891 + vmaw->stream_info[n].size = size;
1893 + vmaw->stream_info[n].cluster_count = (size + VMA_CLUSTER_SIZE - 1) /
1896 + vmaw->stream_count = n;
1898 + if (strcmp(devname, "vmstate") == 0) {
1899 + vmaw->vmstate_stream = n;
1905 +static void vma_co_continue_write(void *opaque)
1907 + VmaWriter *vmaw = opaque;
1909 + DPRINTF("vma_co_continue_write\n");
1910 + qemu_coroutine_enter(vmaw->co_writer);
1913 +static ssize_t coroutine_fn
1914 +vma_queue_write(VmaWriter *vmaw, const void *buf, size_t bytes)
1916 + DPRINTF("vma_queue_write enter %zd\n", bytes);
1920 + assert(bytes <= VMA_MAX_EXTENT_SIZE);
1925 + assert(vmaw->co_writer == NULL);
1927 + vmaw->co_writer = qemu_coroutine_self();
1929 + while (done < bytes) {
1930 + aio_set_fd_handler(qemu_get_aio_context(), vmaw->fd, false, NULL, vma_co_continue_write, NULL, vmaw);
1931 + qemu_coroutine_yield();
1932 + aio_set_fd_handler(qemu_get_aio_context(), vmaw->fd, false, NULL, NULL, NULL, NULL);
1933 + if (vmaw->status < 0) {
1934 + DPRINTF("vma_queue_write detected canceled backup\n");
1938 + ret = write(vmaw->fd, buf + done, bytes - done);
1941 + DPRINTF("vma_queue_write written %zd %zd\n", done, ret);
1942 + } else if (ret < 0) {
1943 + if (errno == EAGAIN || errno == EWOULDBLOCK) {
1946 + vma_writer_set_error(vmaw, "vma_queue_write: write error - %s",
1947 + g_strerror(errno));
1948 + done = -1; /* always return failure for partial writes */
1951 + } else if (ret == 0) {
1952 + /* should not happen - simply try again */
1956 + vmaw->co_writer = NULL;
1958 + return (done == bytes) ? bytes : -1;
1961 +VmaWriter *vma_writer_create(const char *filename, uuid_t uuid, Error **errp)
1965 + assert(sizeof(VmaHeader) == (4096 + 8192));
1966 + assert(G_STRUCT_OFFSET(VmaHeader, config_names) == 2044);
1967 + assert(G_STRUCT_OFFSET(VmaHeader, config_data) == 3068);
1968 + assert(G_STRUCT_OFFSET(VmaHeader, dev_info) == 4096);
1969 + assert(sizeof(VmaExtentHeader) == 512);
1971 + VmaWriter *vmaw = g_new0(VmaWriter, 1);
1974 + vmaw->md5csum = g_checksum_new(G_CHECKSUM_MD5);
1975 + if (!vmaw->md5csum) {
1976 + error_setg(errp, "can't allocate cmsum\n");
1980 + if (strstart(filename, "exec:", &p)) {
1981 + vmaw->cmd = popen(p, "w");
1982 + if (vmaw->cmd == NULL) {
1983 + error_setg(errp, "can't popen command '%s' - %s\n", p,
1984 + g_strerror(errno));
1987 + vmaw->fd = fileno(vmaw->cmd);
1989 + /* try to use O_NONBLOCK */
1990 + fcntl(vmaw->fd, F_SETFL, fcntl(vmaw->fd, F_GETFL)|O_NONBLOCK);
1995 + const char *tmp_id_str;
1997 + if ((stat(filename, &st) == 0) && S_ISFIFO(st.st_mode)) {
1998 + oflags = O_NONBLOCK|O_WRONLY;
1999 + vmaw->fd = qemu_open(filename, oflags, 0644);
2000 + } else if (strstart(filename, "/dev/fdset/", &tmp_id_str)) {
2001 + oflags = O_NONBLOCK|O_WRONLY;
2002 + vmaw->fd = qemu_open(filename, oflags, 0644);
2003 + } else if (strstart(filename, "/dev/fdname/", &tmp_id_str)) {
2004 + vmaw->fd = monitor_get_fd(cur_mon, tmp_id_str, errp);
2005 + if (vmaw->fd < 0) {
2008 + /* try to use O_NONBLOCK */
2009 + fcntl(vmaw->fd, F_SETFL, fcntl(vmaw->fd, F_GETFL)|O_NONBLOCK);
2011 + oflags = O_NONBLOCK|O_DIRECT|O_WRONLY|O_CREAT|O_EXCL;
2012 + vmaw->fd = qemu_open(filename, oflags, 0644);
2015 + if (vmaw->fd < 0) {
2016 + error_setg(errp, "can't open file %s - %s\n", filename,
2017 + g_strerror(errno));
2022 + /* we use O_DIRECT, so we need to align IO buffers */
2024 + vmaw->outbuf = qemu_memalign(512, VMA_MAX_EXTENT_SIZE);
2025 + vmaw->headerbuf = qemu_memalign(512, HEADERBUF_SIZE);
2027 + vmaw->outbuf_count = 0;
2028 + vmaw->outbuf_pos = VMA_EXTENT_HEADER_SIZE;
2030 + vmaw->header_blob_table_pos = 1; /* start at pos 1 */
2032 + qemu_co_mutex_init(&vmaw->flush_lock);
2034 + uuid_copy(vmaw->uuid, uuid);
2041 + pclose(vmaw->cmd);
2042 + } else if (vmaw->fd >= 0) {
2046 + if (vmaw->md5csum) {
2047 + g_checksum_free(vmaw->md5csum);
2056 +static int coroutine_fn vma_write_header(VmaWriter *vmaw)
2059 + unsigned char *buf = vmaw->headerbuf;
2060 + VmaHeader *head = (VmaHeader *)buf;
2064 + DPRINTF("VMA WRITE HEADER\n");
2066 + if (vmaw->status < 0) {
2067 + return vmaw->status;
2070 + memset(buf, 0, HEADERBUF_SIZE);
2072 + head->magic = VMA_MAGIC;
2073 + head->version = GUINT32_TO_BE(1); /* v1 */
2074 + memcpy(head->uuid, vmaw->uuid, 16);
2076 + time_t ctime = time(NULL);
2077 + head->ctime = GUINT64_TO_BE(ctime);
2079 + for (i = 0; i < VMA_MAX_CONFIGS; i++) {
2080 + head->config_names[i] = GUINT32_TO_BE(vmaw->config_names[i]);
2081 + head->config_data[i] = GUINT32_TO_BE(vmaw->config_data[i]);
2084 + /* 32 bytes per device (12 used currently) = 8192 bytes max */
2085 + for (i = 1; i <= 254; i++) {
2086 + VmaStreamInfo *si = &vmaw->stream_info[i];
2088 + assert(si->devname);
2089 + uint32_t devname_ptr = allocate_header_string(vmaw, si->devname);
2090 + if (!devname_ptr) {
2093 + head->dev_info[i].devname_ptr = GUINT32_TO_BE(devname_ptr);
2094 + head->dev_info[i].size = GUINT64_TO_BE(si->size);
2098 + uint32_t header_size = sizeof(VmaHeader) + vmaw->header_blob_table_size;
2099 + head->header_size = GUINT32_TO_BE(header_size);
2101 + if (header_size > HEADERBUF_SIZE) {
2102 + return -1; /* just to be sure */
2105 + uint32_t blob_buffer_offset = sizeof(VmaHeader);
2106 + memcpy(buf + blob_buffer_offset, vmaw->header_blob_table,
2107 + vmaw->header_blob_table_size);
2108 + head->blob_buffer_offset = GUINT32_TO_BE(blob_buffer_offset);
2109 + head->blob_buffer_size = GUINT32_TO_BE(vmaw->header_blob_table_pos);
2111 + g_checksum_reset(vmaw->md5csum);
2112 + g_checksum_update(vmaw->md5csum, (const guchar *)buf, header_size);
2114 + g_checksum_get_digest(vmaw->md5csum, (guint8 *)(head->md5sum), &csize);
2116 + return vma_queue_write(vmaw, buf, header_size);
2119 +static int coroutine_fn vma_writer_flush(VmaWriter *vmaw)
2126 + if (vmaw->status < 0) {
2127 + return vmaw->status;
2130 + if (!vmaw->header_written) {
2131 + vmaw->header_written = true;
2132 + ret = vma_write_header(vmaw);
2134 + vma_writer_set_error(vmaw, "vma_writer_flush: write header failed");
2139 + DPRINTF("VMA WRITE FLUSH %d %d\n", vmaw->outbuf_count, vmaw->outbuf_pos);
2142 + VmaExtentHeader *ehead = (VmaExtentHeader *)vmaw->outbuf;
2144 + ehead->magic = VMA_EXTENT_MAGIC;
2145 + ehead->reserved1 = 0;
2147 + for (i = 0; i < VMA_BLOCKS_PER_EXTENT; i++) {
2148 + ehead->blockinfo[i] = GUINT64_TO_BE(vmaw->outbuf_block_info[i]);
2151 + guint16 block_count = (vmaw->outbuf_pos - VMA_EXTENT_HEADER_SIZE) /
2154 + ehead->block_count = GUINT16_TO_BE(block_count);
2156 + memcpy(ehead->uuid, vmaw->uuid, sizeof(ehead->uuid));
2157 + memset(ehead->md5sum, 0, sizeof(ehead->md5sum));
2159 + g_checksum_reset(vmaw->md5csum);
2160 + g_checksum_update(vmaw->md5csum, vmaw->outbuf, VMA_EXTENT_HEADER_SIZE);
2162 + g_checksum_get_digest(vmaw->md5csum, ehead->md5sum, &csize);
2164 + int bytes = vmaw->outbuf_pos;
2165 + ret = vma_queue_write(vmaw, vmaw->outbuf, bytes);
2166 + if (ret != bytes) {
2167 + vma_writer_set_error(vmaw, "vma_writer_flush: failed write");
2170 + vmaw->outbuf_count = 0;
2171 + vmaw->outbuf_pos = VMA_EXTENT_HEADER_SIZE;
2173 + for (i = 0; i < VMA_BLOCKS_PER_EXTENT; i++) {
2174 + vmaw->outbuf_block_info[i] = 0;
2177 + return vmaw->status;
2180 +static int vma_count_open_streams(VmaWriter *vmaw)
2182 + g_assert(vmaw != NULL);
2185 + int open_drives = 0;
2186 + for (i = 0; i <= 255; i++) {
2187 + if (vmaw->stream_info[i].size && !vmaw->stream_info[i].finished) {
2192 + return open_drives;
2197 + * You need to call this if the vma archive does not contain
2198 + * any data stream.
2201 +vma_writer_flush_output(VmaWriter *vmaw)
2203 + qemu_co_mutex_lock(&vmaw->flush_lock);
2204 + int ret = vma_writer_flush(vmaw);
2205 + qemu_co_mutex_unlock(&vmaw->flush_lock);
2207 + vma_writer_set_error(vmaw, "vma_writer_flush_header failed");
2213 + * all jobs should call this when there is no more data
2214 + * Returns: number of remaining stream (0 ==> finished)
2217 +vma_writer_close_stream(VmaWriter *vmaw, uint8_t dev_id)
2219 + g_assert(vmaw != NULL);
2221 + DPRINTF("vma_writer_set_status %d\n", dev_id);
2222 + if (!vmaw->stream_info[dev_id].size) {
2223 + vma_writer_set_error(vmaw, "vma_writer_close_stream: "
2224 + "no such stream %d", dev_id);
2227 + if (vmaw->stream_info[dev_id].finished) {
2228 + vma_writer_set_error(vmaw, "vma_writer_close_stream: "
2229 + "stream already closed %d", dev_id);
2233 + vmaw->stream_info[dev_id].finished = true;
2235 + int open_drives = vma_count_open_streams(vmaw);
2237 + if (open_drives <= 0) {
2238 + DPRINTF("vma_writer_set_status all drives completed\n");
2239 + vma_writer_flush_output(vmaw);
2242 + return open_drives;
2245 +int vma_writer_get_status(VmaWriter *vmaw, VmaStatus *status)
2249 + g_assert(vmaw != NULL);
2252 + status->status = vmaw->status;
2253 + g_strlcpy(status->errmsg, vmaw->errmsg, sizeof(status->errmsg));
2254 + for (i = 0; i <= 255; i++) {
2255 + status->stream_info[i] = vmaw->stream_info[i];
2258 + uuid_unparse_lower(vmaw->uuid, status->uuid_str);
2261 + status->closed = vmaw->closed;
2263 + return vmaw->status;
2266 +static int vma_writer_get_buffer(VmaWriter *vmaw)
2270 + qemu_co_mutex_lock(&vmaw->flush_lock);
2272 + /* wait until buffer is available */
2273 + while (vmaw->outbuf_count >= (VMA_BLOCKS_PER_EXTENT - 1)) {
2274 + ret = vma_writer_flush(vmaw);
2276 + vma_writer_set_error(vmaw, "vma_writer_get_buffer: flush failed");
2281 + qemu_co_mutex_unlock(&vmaw->flush_lock);
2287 +int64_t coroutine_fn
2288 +vma_writer_write(VmaWriter *vmaw, uint8_t dev_id, int64_t cluster_num,
2289 + unsigned char *buf, size_t *zero_bytes)
2291 + g_assert(vmaw != NULL);
2292 + g_assert(zero_bytes != NULL);
2296 + if (vmaw->status < 0) {
2297 + return vmaw->status;
2300 + if (!dev_id || !vmaw->stream_info[dev_id].size) {
2301 + vma_writer_set_error(vmaw, "vma_writer_write: "
2302 + "no such stream %d", dev_id);
2306 + if (vmaw->stream_info[dev_id].finished) {
2307 + vma_writer_set_error(vmaw, "vma_writer_write: "
2308 + "stream already closed %d", dev_id);
2313 + if (cluster_num >= (((uint64_t)1)<<32)) {
2314 + vma_writer_set_error(vmaw, "vma_writer_write: "
2315 + "cluster number out of range");
2319 + if (dev_id == vmaw->vmstate_stream) {
2320 + if (cluster_num != vmaw->vmstate_clusters) {
2321 + vma_writer_set_error(vmaw, "vma_writer_write: "
2322 + "non sequential vmstate write");
2324 + vmaw->vmstate_clusters++;
2325 + } else if (cluster_num >= vmaw->stream_info[dev_id].cluster_count) {
2326 + vma_writer_set_error(vmaw, "vma_writer_write: cluster number too big");
2330 + /* wait until buffer is available */
2331 + if (vma_writer_get_buffer(vmaw) < 0) {
2332 + vma_writer_set_error(vmaw, "vma_writer_write: "
2333 + "vma_writer_get_buffer failed");
2337 + DPRINTF("VMA WRITE %d %zd\n", dev_id, cluster_num);
2339 + uint16_t mask = 0;
2344 + for (i = 0; i < 16; i++) {
2345 + unsigned char *vmablock = buf + (i*VMA_BLOCK_SIZE);
2346 + if (!buffer_is_zero(vmablock, VMA_BLOCK_SIZE)) {
2348 + memcpy(vmaw->outbuf + vmaw->outbuf_pos, vmablock,
2350 + vmaw->outbuf_pos += VMA_BLOCK_SIZE;
2352 + DPRINTF("VMA WRITE %zd ZERO BLOCK %d\n", cluster_num, i);
2353 + vmaw->stream_info[dev_id].zero_bytes += VMA_BLOCK_SIZE;
2354 + *zero_bytes += VMA_BLOCK_SIZE;
2360 + DPRINTF("VMA WRITE %zd ZERO CLUSTER\n", cluster_num);
2361 + vmaw->stream_info[dev_id].zero_bytes += VMA_CLUSTER_SIZE;
2362 + *zero_bytes += VMA_CLUSTER_SIZE;
2365 + uint64_t block_info = ((uint64_t)mask) << (32+16);
2366 + block_info |= ((uint64_t)dev_id) << 32;
2367 + block_info |= (cluster_num & 0xffffffff);
2368 + vmaw->outbuf_block_info[vmaw->outbuf_count] = block_info;
2370 + DPRINTF("VMA WRITE MASK %zd %zx\n", cluster_num, block_info);
2372 + vmaw->outbuf_count++;
2374 + /** NOTE: We allways write whole clusters, but we correctly set
2375 + * transferred bytes. So transferred == size when when everything
2378 + size_t transferred = VMA_CLUSTER_SIZE;
2380 + if (dev_id != vmaw->vmstate_stream) {
2381 + uint64_t last = (cluster_num + 1) * VMA_CLUSTER_SIZE;
2382 + if (last > vmaw->stream_info[dev_id].size) {
2383 + uint64_t diff = last - vmaw->stream_info[dev_id].size;
2384 + if (diff >= VMA_CLUSTER_SIZE) {
2385 + vma_writer_set_error(vmaw, "vma_writer_write: "
2386 + "read after last cluster");
2389 + transferred -= diff;
2393 + vmaw->stream_info[dev_id].transferred += transferred;
2395 + return transferred;
2398 +void vma_writer_error_propagate(VmaWriter *vmaw, Error **errp)
2400 + if (vmaw->status < 0 && *errp == NULL) {
2401 + error_setg(errp, "%s", vmaw->errmsg);
2405 +int vma_writer_close(VmaWriter *vmaw, Error **errp)
2407 + g_assert(vmaw != NULL);
2411 + while (vmaw->co_writer) {
2412 + aio_poll(qemu_get_aio_context(), true);
2415 + assert(vmaw->co_writer == NULL);
2418 + if (pclose(vmaw->cmd) < 0) {
2419 + vma_writer_set_error(vmaw, "vma_writer_close: "
2420 + "pclose failed - %s", g_strerror(errno));
2423 + if (close(vmaw->fd) < 0) {
2424 + vma_writer_set_error(vmaw, "vma_writer_close: "
2425 + "close failed - %s", g_strerror(errno));
2429 + for (i = 0; i <= 255; i++) {
2430 + VmaStreamInfo *si = &vmaw->stream_info[i];
2432 + if (!si->finished) {
2433 + vma_writer_set_error(vmaw, "vma_writer_close: "
2434 + "detected open stream '%s'", si->devname);
2435 + } else if ((si->transferred != si->size) &&
2436 + (i != vmaw->vmstate_stream)) {
2437 + vma_writer_set_error(vmaw, "vma_writer_close: "
2438 + "incomplete stream '%s' (%zd != %zd)",
2439 + si->devname, si->transferred, si->size);
2444 + for (i = 0; i <= 255; i++) {
2445 + vmaw->stream_info[i].finished = 1; /* mark as closed */
2450 + if (vmaw->status < 0 && *errp == NULL) {
2451 + error_setg(errp, "%s", vmaw->errmsg);
2454 + return vmaw->status;
2457 +void vma_writer_destroy(VmaWriter *vmaw)
2463 + for (i = 0; i <= 255; i++) {
2464 + if (vmaw->stream_info[i].devname) {
2465 + g_free(vmaw->stream_info[i].devname);
2469 + if (vmaw->md5csum) {
2470 + g_checksum_free(vmaw->md5csum);
2475 diff --git a/vma.c b/vma.c
2476 new file mode 100644
2477 index 0000000000..04915427c8
2482 + * VMA: Virtual Machine Archive
2484 + * Copyright (C) 2012-2013 Proxmox Server Solutions
2487 + * Dietmar Maurer (dietmar@proxmox.com)
2489 + * This work is licensed under the terms of the GNU GPL, version 2 or later.
2490 + * See the COPYING file in the top-level directory.
2494 +#include "qemu/osdep.h"
2498 +#include "qemu-common.h"
2499 +#include "qemu/error-report.h"
2500 +#include "qemu/main-loop.h"
2501 +#include "qapi/qmp/qstring.h"
2502 +#include "sysemu/char.h" /* qstring_from_str */
2503 +#include "sysemu/block-backend.h"
2505 +static void help(void)
2507 + const char *help_msg =
2508 + "usage: vma command [command options]\n"
2510 + "vma list <filename>\n"
2511 + "vma config <filename> [-c config]\n"
2512 + "vma create <filename> [-c config] pathname ...\n"
2513 + "vma extract <filename> [-r <fifo>] <targetdir>\n"
2514 + "vma verify <filename> [-v]\n"
2517 + printf("%s", help_msg);
2521 +static const char *extract_devname(const char *path, char **devname, int index)
2525 + const char *sep = strchr(path, '=');
2528 + *devname = g_strndup(path, sep - path);
2532 + *devname = g_strdup_printf("disk%d", index);
2541 +static void print_content(VmaReader *vmar)
2545 + VmaHeader *head = vma_reader_get_header(vmar);
2547 + GList *l = vma_reader_get_config_data(vmar);
2548 + while (l && l->data) {
2549 + VmaConfigData *cdata = (VmaConfigData *)l->data;
2550 + l = g_list_next(l);
2551 + printf("CFG: size: %d name: %s\n", cdata->len, cdata->name);
2555 + VmaDeviceInfo *di;
2556 + for (i = 1; i < 255; i++) {
2557 + di = vma_reader_get_device_info(vmar, i);
2559 + if (strcmp(di->devname, "vmstate") == 0) {
2560 + printf("VMSTATE: dev_id=%d memory: %zd\n", i, di->size);
2562 + printf("DEV: dev_id=%d size: %zd devname: %s\n",
2563 + i, di->size, di->devname);
2567 + /* ctime is the last entry we print */
2568 + printf("CTIME: %s", ctime(&head->ctime));
2572 +static int list_content(int argc, char **argv)
2575 + const char *filename;
2578 + c = getopt(argc, argv, "h");
2588 + g_assert_not_reached();
2592 + /* Get the filename */
2593 + if ((optind + 1) != argc) {
2596 + filename = argv[optind++];
2598 + Error *errp = NULL;
2599 + VmaReader *vmar = vma_reader_create(filename, &errp);
2602 + g_error("%s", error_get_pretty(errp));
2605 + print_content(vmar);
2607 + vma_reader_destroy(vmar);
2612 +typedef struct RestoreMap {
2619 +static int extract_content(int argc, char **argv)
2623 + const char *filename;
2624 + const char *dirname;
2625 + const char *readmap = NULL;
2628 + c = getopt(argc, argv, "hvr:");
2648 + /* Get the filename */
2649 + if ((optind + 2) != argc) {
2652 + filename = argv[optind++];
2653 + dirname = argv[optind++];
2655 + Error *errp = NULL;
2656 + VmaReader *vmar = vma_reader_create(filename, &errp);
2659 + g_error("%s", error_get_pretty(errp));
2662 + if (mkdir(dirname, 0777) < 0) {
2663 + g_error("unable to create target directory %s - %s",
2664 + dirname, g_strerror(errno));
2667 + GList *l = vma_reader_get_config_data(vmar);
2668 + while (l && l->data) {
2669 + VmaConfigData *cdata = (VmaConfigData *)l->data;
2670 + l = g_list_next(l);
2671 + char *cfgfn = g_strdup_printf("%s/%s", dirname, cdata->name);
2672 + GError *err = NULL;
2673 + if (!g_file_set_contents(cfgfn, (gchar *)cdata->data, cdata->len,
2675 + g_error("unable to write file: %s", err->message);
2679 + GHashTable *devmap = g_hash_table_new(g_str_hash, g_str_equal);
2682 + print_content(vmar);
2684 + FILE *map = fopen(readmap, "r");
2686 + g_error("unable to open fifo %s - %s", readmap, g_strerror(errno));
2691 + char *line = fgets(inbuf, sizeof(inbuf), map);
2692 + if (!line || line[0] == '\0' || !strcmp(line, "done\n")) {
2695 + int len = strlen(line);
2696 + if (line[len - 1] == '\n') {
2697 + line[len - 1] = '\0';
2703 + char *format = NULL;
2704 + if (strncmp(line, "format=", sizeof("format=")-1) == 0) {
2705 + format = line + sizeof("format=")-1;
2706 + char *colon = strchr(format, ':');
2708 + g_error("read map failed - found only a format ('%s')", inbuf);
2710 + format = g_strndup(format, colon - format);
2716 + if (line[0] == '0' && line[1] == ':') {
2718 + write_zero = false;
2719 + } else if (line[0] == '1' && line[1] == ':') {
2721 + write_zero = true;
2723 + g_error("read map failed - parse error ('%s')", inbuf);
2726 + char *devname = NULL;
2727 + path = extract_devname(path, &devname, -1);
2729 + g_error("read map failed - no dev name specified ('%s')",
2733 + RestoreMap *map = g_new0(RestoreMap, 1);
2734 + map->devname = g_strdup(devname);
2735 + map->path = g_strdup(path);
2736 + map->format = format;
2737 + map->write_zero = write_zero;
2739 + g_hash_table_insert(devmap, map->devname, map);
2745 + int vmstate_fd = -1;
2746 + guint8 vmstate_stream = 0;
2748 + BlockBackend *blk = NULL;
2750 + for (i = 1; i < 255; i++) {
2751 + VmaDeviceInfo *di = vma_reader_get_device_info(vmar, i);
2752 + if (di && (strcmp(di->devname, "vmstate") == 0)) {
2753 + vmstate_stream = i;
2754 + char *statefn = g_strdup_printf("%s/vmstate.bin", dirname);
2755 + vmstate_fd = open(statefn, O_WRONLY|O_CREAT|O_EXCL, 0644);
2756 + if (vmstate_fd < 0) {
2757 + g_error("create vmstate file '%s' failed - %s", statefn,
2758 + g_strerror(errno));
2762 + char *devfn = NULL;
2763 + const char *format = NULL;
2764 + int flags = BDRV_O_RDWR | BDRV_O_NO_FLUSH;
2765 + bool write_zero = true;
2769 + map = (RestoreMap *)g_hash_table_lookup(devmap, di->devname);
2770 + if (map == NULL) {
2771 + g_error("no device name mapping for %s", di->devname);
2773 + devfn = map->path;
2774 + format = map->format;
2775 + write_zero = map->write_zero;
2777 + devfn = g_strdup_printf("%s/tmp-disk-%s.raw",
2778 + dirname, di->devname);
2779 + printf("DEVINFO %s %zd\n", devfn, di->size);
2781 + bdrv_img_create(devfn, "raw", NULL, NULL, NULL, di->size,
2784 + g_error("can't create file %s: %s", devfn,
2785 + error_get_pretty(errp));
2788 + /* Note: we created an empty file above, so there is no
2789 + * need to write zeroes (so we generate a sparse file)
2791 + write_zero = false;
2794 + size_t devlen = strlen(devfn);
2795 + QDict *options = NULL;
2797 + /* explicit format from commandline */
2798 + options = qdict_new();
2799 + qdict_put(options, "driver", qstring_from_str(format));
2800 + } else if ((devlen > 4 && strcmp(devfn+devlen-4, ".raw") == 0) ||
2801 + strncmp(devfn, "/dev/", 5) == 0)
2803 + /* This part is now deprecated for PVE as well (just as qemu
2804 + * deprecated not specifying an explicit raw format, too.
2806 + /* explicit raw format */
2807 + options = qdict_new();
2808 + qdict_put(options, "driver", qstring_from_str("raw"));
2812 + if (errp || !(blk = blk_new_open(devfn, NULL, options, flags, &errp))) {
2813 + g_error("can't open file %s - %s", devfn,
2814 + error_get_pretty(errp));
2817 + if (vma_reader_register_bs(vmar, i, blk, write_zero, &errp) < 0) {
2818 + g_error("%s", error_get_pretty(errp));
2827 + if (vma_reader_restore(vmar, vmstate_fd, verbose, &errp) < 0) {
2828 + g_error("restore failed - %s", error_get_pretty(errp));
2832 + for (i = 1; i < 255; i++) {
2833 + VmaDeviceInfo *di = vma_reader_get_device_info(vmar, i);
2834 + if (di && (i != vmstate_stream)) {
2835 + char *tmpfn = g_strdup_printf("%s/tmp-disk-%s.raw",
2836 + dirname, di->devname);
2837 + char *fn = g_strdup_printf("%s/disk-%s.raw",
2838 + dirname, di->devname);
2839 + if (rename(tmpfn, fn) != 0) {
2840 + g_error("rename %s to %s failed - %s",
2841 + tmpfn, fn, g_strerror(errno));
2847 + vma_reader_destroy(vmar);
2856 +static int verify_content(int argc, char **argv)
2860 + const char *filename;
2863 + c = getopt(argc, argv, "hv");
2880 + /* Get the filename */
2881 + if ((optind + 1) != argc) {
2884 + filename = argv[optind++];
2886 + Error *errp = NULL;
2887 + VmaReader *vmar = vma_reader_create(filename, &errp);
2890 + g_error("%s", error_get_pretty(errp));
2894 + print_content(vmar);
2897 + if (vma_reader_verify(vmar, verbose, &errp) < 0) {
2898 + g_error("verify failed - %s", error_get_pretty(errp));
2901 + vma_reader_destroy(vmar);
2908 +typedef struct BackupJob {
2909 + BlockBackend *target;
2915 +#define BACKUP_SECTORS_PER_CLUSTER (VMA_CLUSTER_SIZE / BDRV_SECTOR_SIZE)
2917 +static void coroutine_fn backup_run_empty(void *opaque)
2919 + VmaWriter *vmaw = (VmaWriter *)opaque;
2921 + vma_writer_flush_output(vmaw);
2923 + Error *err = NULL;
2924 + if (vma_writer_close(vmaw, &err) != 0) {
2925 + g_warning("vma_writer_close failed %s", error_get_pretty(err));
2929 +static void coroutine_fn backup_run(void *opaque)
2931 + BackupJob *job = (BackupJob *)opaque;
2933 + QEMUIOVector qiov;
2935 + int64_t start, end;
2938 + unsigned char *buf = blk_blockalign(job->target, VMA_CLUSTER_SIZE);
2941 + end = DIV_ROUND_UP(job->len / BDRV_SECTOR_SIZE,
2942 + BACKUP_SECTORS_PER_CLUSTER);
2944 + for (; start < end; start++) {
2945 + iov.iov_base = buf;
2946 + iov.iov_len = VMA_CLUSTER_SIZE;
2947 + qemu_iovec_init_external(&qiov, &iov, 1);
2949 + ret = blk_co_preadv(job->target, start * VMA_CLUSTER_SIZE,
2950 + VMA_CLUSTER_SIZE, &qiov, 0);
2952 + vma_writer_set_error(job->vmaw, "read error", -1);
2957 + if (vma_writer_write(job->vmaw, job->dev_id, start, buf, &zb) < 0) {
2958 + vma_writer_set_error(job->vmaw, "backup_dump_cb vma_writer_write failed", -1);
2965 + if (vma_writer_close_stream(job->vmaw, job->dev_id) <= 0) {
2966 + Error *err = NULL;
2967 + if (vma_writer_close(job->vmaw, &err) != 0) {
2968 + g_warning("vma_writer_close failed %s", error_get_pretty(err));
2973 +static int create_archive(int argc, char **argv)
2977 + const char *archivename;
2978 + GList *config_files = NULL;
2981 + c = getopt(argc, argv, "hvc:");
2991 + config_files = g_list_append(config_files, optarg);
2997 + g_assert_not_reached();
3002 + /* make sure we an archive name */
3003 + if ((optind + 1) > argc) {
3007 + archivename = argv[optind++];
3010 + uuid_generate(uuid);
3012 + Error *local_err = NULL;
3013 + VmaWriter *vmaw = vma_writer_create(archivename, uuid, &local_err);
3015 + if (vmaw == NULL) {
3016 + g_error("%s", error_get_pretty(local_err));
3019 + GList *l = config_files;
3020 + while (l && l->data) {
3021 + char *name = l->data;
3022 + char *cdata = NULL;
3024 + GError *err = NULL;
3025 + if (!g_file_get_contents(name, &cdata, &clen, &err)) {
3026 + unlink(archivename);
3027 + g_error("Unable to read file: %s", err->message);
3030 + if (vma_writer_add_config(vmaw, name, cdata, clen) != 0) {
3031 + unlink(archivename);
3032 + g_error("Unable to append config data %s (len = %zd)",
3035 + l = g_list_next(l);
3039 + while (optind < argc) {
3040 + const char *path = argv[optind++];
3041 + char *devname = NULL;
3042 + path = extract_devname(path, &devname, devcount++);
3044 + Error *errp = NULL;
3045 + BlockBackend *target;
3047 + target = blk_new_open(path, NULL, NULL, 0, &errp);
3049 + unlink(archivename);
3050 + g_error("bdrv_open '%s' failed - %s", path, error_get_pretty(errp));
3052 + int64_t size = blk_getlength(target);
3053 + int dev_id = vma_writer_register_stream(vmaw, devname, size);
3054 + if (dev_id <= 0) {
3055 + unlink(archivename);
3056 + g_error("vma_writer_register_stream '%s' failed", devname);
3059 + BackupJob *job = g_new0(BackupJob, 1);
3061 + job->target = target;
3063 + job->dev_id = dev_id;
3065 + Coroutine *co = qemu_coroutine_create(backup_run, job);
3066 + qemu_coroutine_enter(co);
3069 + VmaStatus vmastat;
3071 + int last_percent = -1;
3075 + main_loop_wait(false);
3076 + vma_writer_get_status(vmaw, &vmastat);
3080 + uint64_t total = 0;
3081 + uint64_t transferred = 0;
3082 + uint64_t zero_bytes = 0;
3085 + for (i = 0; i < 256; i++) {
3086 + if (vmastat.stream_info[i].size) {
3087 + total += vmastat.stream_info[i].size;
3088 + transferred += vmastat.stream_info[i].transferred;
3089 + zero_bytes += vmastat.stream_info[i].zero_bytes;
3092 + percent = (transferred*100)/total;
3093 + if (percent != last_percent) {
3094 + fprintf(stderr, "progress %d%% %zd/%zd %zd\n", percent,
3095 + transferred, total, zero_bytes);
3098 + last_percent = percent;
3102 + if (vmastat.closed) {
3107 + Coroutine *co = qemu_coroutine_create(backup_run_empty, vmaw);
3108 + qemu_coroutine_enter(co);
3110 + main_loop_wait(false);
3111 + vma_writer_get_status(vmaw, &vmastat);
3112 + if (vmastat.closed) {
3120 + vma_writer_get_status(vmaw, &vmastat);
3123 + for (i = 0; i < 256; i++) {
3124 + VmaStreamInfo *si = &vmastat.stream_info[i];
3126 + fprintf(stderr, "image %s: size=%zd zeros=%zd saved=%zd\n",
3127 + si->devname, si->size, si->zero_bytes,
3128 + si->size - si->zero_bytes);
3133 + if (vmastat.status < 0) {
3134 + unlink(archivename);
3135 + g_error("creating vma archive failed");
3141 +static int dump_config(int argc, char **argv)
3144 + const char *filename;
3145 + const char *config_name = "qemu-server.conf";
3148 + c = getopt(argc, argv, "hc:");
3158 + config_name = optarg;
3165 + /* Get the filename */
3166 + if ((optind + 1) != argc) {
3169 + filename = argv[optind++];
3171 + Error *errp = NULL;
3172 + VmaReader *vmar = vma_reader_create(filename, &errp);
3175 + g_error("%s", error_get_pretty(errp));
3179 + GList *l = vma_reader_get_config_data(vmar);
3180 + while (l && l->data) {
3181 + VmaConfigData *cdata = (VmaConfigData *)l->data;
3182 + l = g_list_next(l);
3183 + if (strcmp(cdata->name, config_name) == 0) {
3185 + fwrite(cdata->data, cdata->len, 1, stdout);
3190 + vma_reader_destroy(vmar);
3195 + fprintf(stderr, "unable to find configuration data '%s'\n", config_name);
3202 +int main(int argc, char **argv)
3204 + const char *cmdname;
3205 + Error *main_loop_err = NULL;
3207 + error_set_progname(argv[0]);
3209 + if (qemu_init_main_loop(&main_loop_err)) {
3210 + g_error("%s", error_get_pretty(main_loop_err));
3219 + cmdname = argv[1];
3223 + if (!strcmp(cmdname, "list")) {
3224 + return list_content(argc, argv);
3225 + } else if (!strcmp(cmdname, "create")) {
3226 + return create_archive(argc, argv);
3227 + } else if (!strcmp(cmdname, "extract")) {
3228 + return extract_content(argc, argv);
3229 + } else if (!strcmp(cmdname, "verify")) {
3230 + return verify_content(argc, argv);
3231 + } else if (!strcmp(cmdname, "config")) {
3232 + return dump_config(argc, argv);
3238 diff --git a/vma.h b/vma.h
3239 new file mode 100644
3240 index 0000000000..fa6f4df7e7
3245 + * VMA: Virtual Machine Archive
3247 + * Copyright (C) Proxmox Server Solutions
3250 + * Dietmar Maurer (dietmar@proxmox.com)
3252 + * This work is licensed under the terms of the GNU GPL, version 2 or later.
3253 + * See the COPYING file in the top-level directory.
3257 +#ifndef BACKUP_VMA_H
3258 +#define BACKUP_VMA_H
3260 +#include <uuid/uuid.h>
3261 +#include "qapi/error.h"
3262 +#include "block/block.h"
3264 +#define VMA_BLOCK_BITS 12
3265 +#define VMA_BLOCK_SIZE (1<<VMA_BLOCK_BITS)
3266 +#define VMA_CLUSTER_BITS (VMA_BLOCK_BITS+4)
3267 +#define VMA_CLUSTER_SIZE (1<<VMA_CLUSTER_BITS)
3269 +#if VMA_CLUSTER_SIZE != 65536
3270 +#error unexpected cluster size
3273 +#define VMA_EXTENT_HEADER_SIZE 512
3274 +#define VMA_BLOCKS_PER_EXTENT 59
3275 +#define VMA_MAX_CONFIGS 256
3277 +#define VMA_MAX_EXTENT_SIZE \
3278 + (VMA_EXTENT_HEADER_SIZE+VMA_CLUSTER_SIZE*VMA_BLOCKS_PER_EXTENT)
3279 +#if VMA_MAX_EXTENT_SIZE != 3867136
3280 +#error unexpected VMA_EXTENT_SIZE
3283 +/* File Format Definitions */
3285 +#define VMA_MAGIC (GUINT32_TO_BE(('V'<<24)|('M'<<16)|('A'<<8)|0x00))
3286 +#define VMA_EXTENT_MAGIC (GUINT32_TO_BE(('V'<<24)|('M'<<16)|('A'<<8)|'E'))
3288 +typedef struct VmaDeviceInfoHeader {
3289 + uint32_t devname_ptr; /* offset into blob_buffer table */
3290 + uint32_t reserved0;
3291 + uint64_t size; /* device size in bytes */
3292 + uint64_t reserved1;
3293 + uint64_t reserved2;
3294 +} VmaDeviceInfoHeader;
3296 +typedef struct VmaHeader {
3299 + unsigned char uuid[16];
3301 + unsigned char md5sum[16];
3303 + uint32_t blob_buffer_offset;
3304 + uint32_t blob_buffer_size;
3305 + uint32_t header_size;
3307 + unsigned char reserved[1984];
3309 + uint32_t config_names[VMA_MAX_CONFIGS]; /* offset into blob_buffer table */
3310 + uint32_t config_data[VMA_MAX_CONFIGS]; /* offset into blob_buffer table */
3312 + uint32_t reserved1;
3314 + VmaDeviceInfoHeader dev_info[256];
3317 +typedef struct VmaExtentHeader {
3319 + uint16_t reserved1;
3320 + uint16_t block_count;
3321 + unsigned char uuid[16];
3322 + unsigned char md5sum[16];
3323 + uint64_t blockinfo[VMA_BLOCKS_PER_EXTENT];
3326 +/* functions/definitions to read/write vma files */
3328 +typedef struct VmaReader VmaReader;
3330 +typedef struct VmaWriter VmaWriter;
3332 +typedef struct VmaConfigData {
3338 +typedef struct VmaStreamInfo {
3340 + uint64_t cluster_count;
3341 + uint64_t transferred;
3342 + uint64_t zero_bytes;
3347 +typedef struct VmaStatus {
3350 + char errmsg[8192];
3351 + char uuid_str[37];
3352 + VmaStreamInfo stream_info[256];
3355 +typedef struct VmaDeviceInfo {
3356 + uint64_t size; /* device size in bytes */
3357 + const char *devname;
3360 +VmaWriter *vma_writer_create(const char *filename, uuid_t uuid, Error **errp);
3361 +int vma_writer_close(VmaWriter *vmaw, Error **errp);
3362 +void vma_writer_error_propagate(VmaWriter *vmaw, Error **errp);
3363 +void vma_writer_destroy(VmaWriter *vmaw);
3364 +int vma_writer_add_config(VmaWriter *vmaw, const char *name, gpointer data,
3366 +int vma_writer_register_stream(VmaWriter *vmaw, const char *devname,
3369 +int64_t coroutine_fn vma_writer_write(VmaWriter *vmaw, uint8_t dev_id,
3370 + int64_t cluster_num, unsigned char *buf,
3371 + size_t *zero_bytes);
3373 +int coroutine_fn vma_writer_close_stream(VmaWriter *vmaw, uint8_t dev_id);
3374 +int coroutine_fn vma_writer_flush_output(VmaWriter *vmaw);
3376 +int vma_writer_get_status(VmaWriter *vmaw, VmaStatus *status);
3377 +void vma_writer_set_error(VmaWriter *vmaw, const char *fmt, ...);
3380 +VmaReader *vma_reader_create(const char *filename, Error **errp);
3381 +void vma_reader_destroy(VmaReader *vmar);
3382 +VmaHeader *vma_reader_get_header(VmaReader *vmar);
3383 +GList *vma_reader_get_config_data(VmaReader *vmar);
3384 +VmaDeviceInfo *vma_reader_get_device_info(VmaReader *vmar, guint8 dev_id);
3385 +int vma_reader_register_bs(VmaReader *vmar, guint8 dev_id,
3386 + BlockBackend *target, bool write_zeroes,
3388 +int vma_reader_restore(VmaReader *vmar, int vmstate_fd, bool verbose,
3390 +int vma_reader_verify(VmaReader *vmar, bool verbose, Error **errp);
3392 +#endif /* BACKUP_VMA_H */