]> git.proxmox.com Git - mirror_edk2.git/commitdiff
StandaloneMmPkg/StandaloneMmCoreEntryPoint: drop explicit SerialPortLib call
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Mon, 21 Jan 2019 15:05:23 +0000 (16:05 +0100)
committerArd Biesheuvel <ard.biesheuvel@linaro.org>
Mon, 11 Mar 2019 11:51:12 +0000 (12:51 +0100)
Sending DEBUG output to the serial port should only be done via
DebugLib calls, which is in charge of initializing the serial
port when appropriate. So drop the explicit SerialPortInitialize ()
invocation, and rely on normal constructor ordering to get the
serial port into the appropriate state at the right time.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: "Yao, Jiewen" <jiewen.yao@intel.com>
Reviewed-by: Achin Gupta <achin.gupta@arm.com>
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c

index 5cca532456fdca82889939f2ca54f504a3779d9a..c8e11a253d24998235ec9c49480885e103ecc18c 100644 (file)
@@ -232,9 +232,6 @@ _ModuleEntryPoint (
   VOID                                    *TeData;\r
   UINTN                                   TeDataSize;\r
 \r
-  Status = SerialPortInitialize ();\r
-  ASSERT_EFI_ERROR (Status);\r
-\r
   // Get Secure Partition Manager Version Information\r
   Status = GetSpmVersion ();\r
   if (EFI_ERROR (Status)) {\r