mirror_edk2.git
8 years agoShellPkg: add the last PCIe extended capability decodings
Jaben Carsey [Fri, 10 Jan 2014 22:34:13 +0000 (22:34 +0000)]
ShellPkg: add the last PCIe extended capability decodings

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15097 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoMdePkg: add missing #defines for decoding PCIe 2.1 extended capability structures
Jaben Carsey [Fri, 10 Jan 2014 22:30:37 +0000 (22:30 +0000)]
MdePkg: add missing #defines for decoding PCIe 2.1 extended capability structures

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15096 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoShellPkg: remove potential memory leak with new apps on old shell
Jaben Carsey [Fri, 10 Jan 2014 16:42:45 +0000 (16:42 +0000)]
ShellPkg: remove potential memory leak with new apps on old shell

This pointer never gets free when running new apps on the old shell.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15095 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoShellPkg: remove double free operation
Jaben Carsey [Fri, 10 Jan 2014 16:41:54 +0000 (16:41 +0000)]
ShellPkg: remove double free operation

This pointer gets free twice and this does not work.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15094 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoArmPkg/ArmPkg.dec: Redefined PcdSystemMemory(Base|Size) as UINT64
Olivier Martin [Fri, 10 Jan 2014 11:27:31 +0000 (11:27 +0000)]
ArmPkg/ArmPkg.dec: Redefined PcdSystemMemory(Base|Size) as UINT64

The System Memory region might be out of the 32-bit memory space.

This change has been validated on the FVP AArch64 model using 4GB
of DRAM at 0x8_0000_0000:

-  # System Memory (2GB)
-  gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
-  gArmTokenSpaceGuid.PcdSystemMemorySize|0x80000000
+  # System Memory (4GB)
+  gArmTokenSpaceGuid.PcdSystemMemoryBase|0x800000000
+  gArmTokenSpaceGuid.PcdSystemMemorySize|0x100000000

EFI Shell and Linux kernel boot successfully.

Note: This change has not been validated on AArch32. I expect some
early assembly code to not work.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15093 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoFix bug in unload function: Check if component name protocol exist, only uninstall...
Fu Siyuan [Fri, 10 Jan 2014 08:24:29 +0000 (08:24 +0000)]
Fix bug in unload function: Check if component name protocol exist, only uninstall it when it really exists.
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Tian, Feng <feng.tian@intel.com>
Reviewed-by: Jin, Eric <eric.jin@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15092 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate PcAtChipsetPkg package version from 0.2 to 0.3
Ruiyu Ni [Fri, 10 Jan 2014 07:29:32 +0000 (07:29 +0000)]
Update PcAtChipsetPkg package version from 0.2 to 0.3

Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Hot Tian <hot.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15091 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoMdeModulePkg/NvmExpressDxe: Fix a bug in NvmExpressDxe driver’s Unload() that forget...
Feng Tian [Fri, 10 Jan 2014 07:15:52 +0000 (07:15 +0000)]
MdeModulePkg/NvmExpressDxe: Fix a bug in NvmExpressDxe driver’s Unload() that forget to uninstall the DriverSupportedEfiVersionProtocol

Signed-off-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Elvin Li <elvin.li@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15090 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoSync BaseTool trunk (version r2640) into EDKII BaseTools.
Gao, Liming [Fri, 10 Jan 2014 05:25:50 +0000 (05:25 +0000)]
Sync BaseTool trunk (version r2640) into EDKII BaseTools.

Signed-off-by: Gao, Liming <liming.gao@intel.com>
Reviewed-by: Liu, Jiang A <jiang.a.liu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15089 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoNew EdkShell binaries.
Ruiyu Ni [Fri, 10 Jan 2014 04:57:57 +0000 (04:57 +0000)]
New EdkShell binaries.
Update EdkShellBinPkg.dec version from 0.4 to 0.5.

Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Hot Tian <hot.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15088 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoFix a bug in DebugPort driver's Unload() that leaves the DriverBinding/ComponentName...
Ruiyu Ni [Fri, 10 Jan 2014 03:42:36 +0000 (03:42 +0000)]
Fix a bug in DebugPort driver's Unload() that leaves the DriverBinding/ComponentName(2) installed.

Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15087 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoFix bug when reserve stack space to fill exception context.
Jeff Fan [Fri, 10 Jan 2014 02:48:49 +0000 (02:48 +0000)]
Fix bug when reserve stack space to fill exception context.

Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15086 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoNew FatDxe binary.
Ruiyu Ni [Fri, 10 Jan 2014 02:44:43 +0000 (02:44 +0000)]
New FatDxe binary.
Update DEC revision to 0.3.

Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Hot Tian <hot.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15085 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate CryptoPkg version: 0.92 -> 0.93
Long, Qin [Fri, 10 Jan 2014 02:30:22 +0000 (02:30 +0000)]
Update CryptoPkg version: 0.92 -> 0.93

Signed-off-by: Long, Qin <qin.long@intel.com>
Reviewed-by: Tian, Hot <hot.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15084 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoAdd the feature "dmpstore -l" and "dmpstore -s".
Ruiyu Ni [Fri, 10 Jan 2014 01:52:24 +0000 (01:52 +0000)]
Add the feature "dmpstore -l" and "dmpstore -s".
The file format is as below:
<File> := <Variable>+
<Variable> := <Name-Size> <Data-Size> <Name> <GUID> <Attributes> <Data> <Crc32>

Each variable representation in the file has a CRC32 value which can provide a mechanism to detect the file modification.
When any CRC32 is incorrect, dmpstore rejects to load the variables from the file.

Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15083 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdates MdeModulePkg package version from 0.92 to 0.93
Tian, Feng [Fri, 10 Jan 2014 01:43:02 +0000 (01:43 +0000)]
Updates MdeModulePkg package version from 0.92 to 0.93

Signed-off-by: Tian, Feng <feng.tian@intel.com>
Reviewed-by: Tian, Hot <hot.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15082 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpgrade package version to 0.93
Dong Guo [Fri, 10 Jan 2014 01:24:51 +0000 (01:24 +0000)]
Upgrade package version to 0.93

Signed-off-by: Dong Guo <guo.dong@intel.com>
Reviewed-by: Tian, Hot <hot.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15081 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate SourceLevelDebugPkg version: 0.85->0.86
Jeff Fan [Fri, 10 Jan 2014 01:21:14 +0000 (01:21 +0000)]
Update SourceLevelDebugPkg version: 0.85->0.86

Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Hot Tian <hot.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15080 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate UefiCpuPkg version: 0.2->0.3
Jeff Fan [Fri, 10 Jan 2014 01:20:26 +0000 (01:20 +0000)]
Update UefiCpuPkg version: 0.2->0.3

Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Hot Tian <hot.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15079 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate IntelFrameworkModulePkg version: 0.92->0.93
Jeff Fan [Fri, 10 Jan 2014 01:19:03 +0000 (01:19 +0000)]
Update IntelFrameworkModulePkg version: 0.92->0.93

Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Hot Tian <hot.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15078 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate IntelFrameworkPkg version: 0.92->0.93
Jeff Fan [Fri, 10 Jan 2014 01:18:20 +0000 (01:18 +0000)]
Update IntelFrameworkPkg version: 0.92->0.93

Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Hot Tian <hot.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15077 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoMdePkg: Add PCI Express 2.1 and 3.0 structures
Jaben Carsey [Thu, 9 Jan 2014 21:55:03 +0000 (21:55 +0000)]
MdePkg: Add PCI Express 2.1 and 3.0 structures

This adds PCI Express extended capabilities structures.  These structures are required for enhancements to the shell.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15076 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoMmcDxe: Perform diagnostics specifically on the requested controller
Olivier Martin [Thu, 9 Jan 2014 19:15:06 +0000 (19:15 +0000)]
MmcDxe: Perform diagnostics specifically on the requested controller

In RunDiagnostics, find the controller specified by ControllerHandle and run
diagnostics only on that controller, returning EFI_UNSUPPORTED if it isn't in
the driver's pool of managed devices.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15075 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoMmcDxe: Adding eMMC support
Olivier Martin [Thu, 9 Jan 2014 19:06:25 +0000 (19:06 +0000)]
MmcDxe: Adding eMMC support

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15074 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoShellPkg: remove memory leak in file handle list
Jaben Carsey [Thu, 9 Jan 2014 18:05:24 +0000 (18:05 +0000)]
ShellPkg: remove memory leak in file handle list

The shell was not freeing sufficient memory when freeing a list of files.  The structure contained a pointer which was being left behind.  I made a new function to replace the shared freeing function which frees the “Path” member of the SHELL_COMMAND_FILE_HANDLE structure.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15073 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoShellPkg: Fix NSH parsing
Jaben Carsey [Thu, 9 Jan 2014 18:02:26 +0000 (18:02 +0000)]
ShellPkg: Fix NSH parsing

This skips lines in NSH files that are completely comments.  This reduces the memory overhead and the later processing.

This also frees memory correctly when a second memory allocation fails.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <Ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15072 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoShellPkg: Remove memory leak from file list usage
Jaben Carsey [Thu, 9 Jan 2014 17:59:46 +0000 (17:59 +0000)]
ShellPkg: Remove memory leak from file list usage

This change removes an un-used parameter that was then causing a leak since the memory was assumed to be used.

This also verifies that the list is freed when no longer needed.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <Ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15071 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoShellPkg: Add more output to PCI command for extended configuration.
Jaben Carsey [Thu, 9 Jan 2014 16:54:13 +0000 (16:54 +0000)]
ShellPkg: Add more output to PCI command for extended configuration.

there is a new non-spec parameter "-_e" which allows additional information output to be controlled.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15070 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoIf the driver does not start before, we do not disconnect driver and we must still...
Elvin Li [Thu, 9 Jan 2014 08:47:03 +0000 (08:47 +0000)]
If the driver does not start before, we do not disconnect driver and we must still uninstall other protocols on image handle. The original implementation of error return is not correct.

Signed-off-by: Elvin Li <elvin.li@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15069 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate NetworkPkg package version to 0.94.
Fu Siyuan [Thu, 9 Jan 2014 07:05:09 +0000 (07:05 +0000)]
Update NetworkPkg package version to 0.94.

Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15068 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoReturn to BMM page if parse the file info failed.
Eric Dong [Thu, 9 Jan 2014 05:59:53 +0000 (05:59 +0000)]
Return to BMM page if parse the file info failed.

Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15067 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoClarify PcdPeiCoreMaxPeimPerFv description that means the maximum supported file...
Gao, Liming [Thu, 9 Jan 2014 05:25:56 +0000 (05:25 +0000)]
Clarify PcdPeiCoreMaxPeimPerFv description that means the maximum supported file count in one FV, not only PEIM.

Signed-off-by: Gao, Liming <liming.gao@intel.com>
Reviewed-by: Zeng, Star <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15066 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdates MdePkg package version from 1.03 to 1.04
Gao, Liming [Thu, 9 Jan 2014 05:15:53 +0000 (05:15 +0000)]
Updates MdePkg package version from 1.03 to 1.04

Signed-off-by: Gao, Liming <liming.gao@intel.com>
Reviewed-by: Tian, Hot <hot.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15065 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoMdeModulePkg FaultTolerantWrite: Let FaultTolerantWrite driver to depend on gEfiRunti...
Star Zeng [Thu, 9 Jan 2014 02:57:10 +0000 (02:57 +0000)]
MdeModulePkg FaultTolerantWrite: Let FaultTolerantWrite driver to depend on gEfiRuntimeArchProtocolGuid to consume gBS->CalculateCrc32().

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15064 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoCorrect function comments of S3BootScriptCloseTable().
Liming Gao [Thu, 9 Jan 2014 01:54:43 +0000 (01:54 +0000)]
Correct function comments of S3BootScriptCloseTable().

Signed-off-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15063 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoCorrect function comments of S3BootScriptCloseTable().
Liming Gao [Thu, 9 Jan 2014 01:53:33 +0000 (01:53 +0000)]
Correct function comments of S3BootScriptCloseTable().

Signed-off-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15062 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoAdd processor family 2 definition in SMBIOS header file.
Yi Li [Thu, 9 Jan 2014 01:32:58 +0000 (01:32 +0000)]
Add processor family 2 definition in SMBIOS header file.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yi Li <yi.li@linaro.org>
Reviewed by: Star Zeng <star.zeng@intel.com>
Reviewed by: Elvin Li <elvin.li@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15061 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoAdd code to check whether the pointer 'NewBuffer' in 'FileHandelWrappers.c' and...
Shumin Qiu [Thu, 9 Jan 2014 00:30:27 +0000 (00:30 +0000)]
Add code to check whether the pointer 'NewBuffer'  in 'FileHandelWrappers.c' and the pointer 'FoundVarName' in 'Dmpstore.c' are NULL before used.

Signed-off-by: Shumin Qiu <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15060 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoRollback the patch 15054.
Eric Dong [Wed, 8 Jan 2014 08:21:22 +0000 (08:21 +0000)]
Rollback the patch 15054.

Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15059 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoCheck if component name protocol exist, uninstall it when it really exists.
Elvin Li [Wed, 8 Jan 2014 03:47:43 +0000 (03:47 +0000)]
Check if component name protocol exist, uninstall it when it really exists.

Signed-off-by: Elvin Li <elvin.li@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15058 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoArmPlatformPkg/ArmFvpDxe: Fixed the line endings
oliviermartin [Tue, 7 Jan 2014 11:20:14 +0000 (11:20 +0000)]
ArmPlatformPkg/ArmFvpDxe: Fixed the line endings

The line endings for EDK2 source files should be CRLF.

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15057 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoMdePkg PcdLib: Except for SizeOfBuffer is greater than the maximum size supported...
Star Zeng [Tue, 7 Jan 2014 09:28:33 +0000 (09:28 +0000)]
MdePkg PcdLib: Except for SizeOfBuffer is greater than the maximum size supported, align the behavior of LibPcdSetPtr with LibPcdSetN to handle error status returned.

Let the comments to be aligned with code behavior for LibPcdSetX APIs.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed by: Liming Gao <liming.gao@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15056 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoThis patch fix date/time op-code shows abnormal.
Eric Dong [Tue, 7 Jan 2014 08:07:47 +0000 (08:07 +0000)]
This patch fix date/time op-code shows abnormal.

Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15055 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoNot update the status until parse the file info success.
Eric Dong [Tue, 7 Jan 2014 07:34:20 +0000 (07:34 +0000)]
Not update the status until parse the file info success.

Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15054 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoMtrrDebugPrintAllMtrrs() should loop until the max physical address is reached.
Jeff Fan [Tue, 7 Jan 2014 06:24:16 +0000 (06:24 +0000)]
MtrrDebugPrintAllMtrrs() should loop until the max physical address is reached.
GetMemoryCacheTypeFromMtrrType () should return the default memory type instead of UC type for MTRR_CACHE_INVALID_TYPE.

Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15053 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoEnhance Shell 2.0 to not depend on keyboard driver implementation to fix the "CTRL...
Ruiyu Ni [Tue, 7 Jan 2014 02:23:10 +0000 (02:23 +0000)]
Enhance Shell 2.0 to not depend on keyboard driver implementation to fix the "CTRL+s" pause malfunction issue.

Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Carsey Jaben <jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15052 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoAdd the comment for function 'IsValidSplit' in 'Shell.c'. Add code to check whether...
Shumin Qiu [Tue, 7 Jan 2014 01:51:08 +0000 (01:51 +0000)]
Add the comment for function 'IsValidSplit' in 'Shell.c'. Add code to check whether pointer 'DataBuffer' in 'DmpStore.c' is NULL before used.

Signed-off-by: Shumin Qiu <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15051 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoMdeModulePkg CdExpressPei: Use correct PeiServices pointer to call low level BlockIoP...
Star Zeng [Mon, 6 Jan 2014 03:36:31 +0000 (03:36 +0000)]
MdeModulePkg CdExpressPei: Use correct PeiServices pointer to call low level BlockIoPpi->ReadBlocks.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15050 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoBug fix: IpSec driver treats BOOLEAN as EFI_STATUS in error handling code.
Fu Siyuan [Mon, 6 Jan 2014 03:01:09 +0000 (03:01 +0000)]
Bug fix: IpSec driver treats BOOLEAN as EFI_STATUS in error handling code.
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Dong, Guo <guo.dong@intel.com>
Reviewed-by: Jin, Eric <eric.jin@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15049 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoFix “reconnect -r” ASSERT after VLAN configured.
Fu Siyuan [Mon, 6 Jan 2014 02:17:12 +0000 (02:17 +0000)]
Fix “reconnect -r” ASSERT after VLAN configured.
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Zhang, Chao B <chao.b.zhang@intel.com>
Reviewed-by: Jin, Eric <eric.jin@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15048 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate PXE driver to support PXE forced mode.
Fu Siyuan [Mon, 6 Jan 2014 02:08:05 +0000 (02:08 +0000)]
Update PXE driver to support PXE forced mode.

Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Dong, Guo <guo.dong@intel.com>
Reviewed-by: Jin, Eric <eric.jin@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15047 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg: QemuFwCfgLib: implement for SEC
Laszlo Ersek [Fri, 3 Jan 2014 19:57:36 +0000 (19:57 +0000)]
OvmfPkg: QemuFwCfgLib: implement for SEC

The QemuFwCfgSecLib library instance
- is stateless,
- has no library constructor,
- is available to SEC client code,
- must be queried with QemuFwCfgIsAvailable() before use,
- is restricted to SEC in order to limit the explicit querying
  requirement. (There is no current user.)

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15046 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg: QemuFwCfgLib: extract stateful implementation
Laszlo Ersek [Fri, 3 Jan 2014 19:57:26 +0000 (19:57 +0000)]
OvmfPkg: QemuFwCfgLib: extract stateful implementation

The current implementation of QemuFwCfgLib is:
- stateful
- implicitly initialized in the library constructor.

OVMF's SEC runs from read-only memory/flash. When the library is linked
into a SEC binary (which currently never happens), the
"mQemuFwCfgSupported" global variable becomes read-only, making the
library non-functional.

Extract the stateful, implicitly initialized library implementation into a
separate file, making room for a stateless, explicitly queried
implementation that's usable in SEC. Restrict the stateful implementation
to the current, non-SEC clients.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15045 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg: QemuFwCfgLib: introduce InternalQemuFwCfgIsAvailable()
Laszlo Ersek [Fri, 3 Jan 2014 19:57:17 +0000 (19:57 +0000)]
OvmfPkg: QemuFwCfgLib: introduce InternalQemuFwCfgIsAvailable()

This internal function allows separation of library-internal and
for-clients external availability of fw_cfg.

The interface contract of QemuFwCfgIsAvailable() is changed so that now it
may modify fw_cfg state. All current users are compliant with the new
contract.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15044 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg/create-release.py: Read License.txt files
Jordan Justen [Fri, 3 Jan 2014 19:19:43 +0000 (19:19 +0000)]
OvmfPkg/create-release.py: Read License.txt files

Rather than embedding the License information in this script,
we now read the License.txt files from MdePkg & FatBinPkg.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15043 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg/create-release.py: Support git hash versions
Jordan Justen [Fri, 3 Jan 2014 19:19:38 +0000 (19:19 +0000)]
OvmfPkg/create-release.py: Support git hash versions

Previously we would run 'git svn info' if a .svn directory
wasn't found. This would fail if the current local commit
was not from git-svn.

Now we look for the svn info in the output from git log.
If the svn version is not in a git-svn-id tag from
git log, then we use the git commit hash.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15042 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg/create-release.py: Support GCC44 through GCC47
Jordan Justen [Fri, 3 Jan 2014 19:19:32 +0000 (19:19 +0000)]
OvmfPkg/create-release.py: Support GCC44 through GCC47

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15041 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg/create-release.py: Remove '-alpha' from filename
Jordan Justen [Fri, 3 Jan 2014 19:19:26 +0000 (19:19 +0000)]
OvmfPkg/create-release.py: Remove '-alpha' from filename

The source control revision is still the produced filename.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15040 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg/README: Update OVMF status
Jordan Justen [Fri, 3 Jan 2014 19:19:20 +0000 (19:19 +0000)]
OvmfPkg/README: Update OVMF status

Remove 'Alpha' status tag. Let's just refer to the OVMF
releases by their revision control version.

Remove 'stabilize UEFI Linux' to-do item.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15039 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg/README: Update information about running OVMF
Jordan Justen [Fri, 3 Jan 2014 19:19:14 +0000 (19:19 +0000)]
OvmfPkg/README: Update information about running OVMF

The new instructions document -pflash & -bios options
for running OVMF on QEMU.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15038 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoCorrect function comments of S3BootScriptSaveDispatch2().
Liming Gao [Fri, 3 Jan 2014 03:27:18 +0000 (03:27 +0000)]
Correct function comments of S3BootScriptSaveDispatch2().

Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15037 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate the heap migration logic to avoid memory overflow.
Liming Gao [Thu, 2 Jan 2014 07:16:09 +0000 (07:16 +0000)]
Update the heap migration logic to avoid memory overflow.

Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15036 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoCorrect the RemainingPages calculation in PEI AllocatePages service.
Liming Gao [Thu, 2 Jan 2014 02:38:32 +0000 (02:38 +0000)]
Correct the RemainingPages calculation in PEI AllocatePages service.

Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15035 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate MemoryAllocationLib AllocateAlignedPages API comments for memory overflow...
Liming Gao [Tue, 31 Dec 2013 07:19:52 +0000 (07:19 +0000)]
Update MemoryAllocationLib AllocateAlignedPages API comments for memory overflow ASSERT case.

Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15034 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate MemoryAllocationLib.AllocateAlignedPages API comments for memory overflow...
Liming Gao [Tue, 31 Dec 2013 07:19:09 +0000 (07:19 +0000)]
Update MemoryAllocationLib.AllocateAlignedPages API comments for memory overflow ASSERT case.

Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15033 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoKeep consistent about the return value between the caller and callee.
Eric Dong [Tue, 31 Dec 2013 04:46:53 +0000 (04:46 +0000)]
Keep consistent about the return value between the caller and callee.

Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15032 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoSet the type of variable 'StatusCode' as SHELL_STATUS to match the parameter type...
Shumin Qiu [Tue, 31 Dec 2013 04:01:17 +0000 (04:01 +0000)]
Set the type of variable 'StatusCode' as SHELL_STATUS to match the parameter type of function 'SetLastError'.

Signed-off-by: Shumin Qiu <shumin.qiu@intel.com>
Reviewed-by: Gao, Liming <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15031 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoRollback the change 15021.
Eric Dong [Mon, 30 Dec 2013 06:07:29 +0000 (06:07 +0000)]
Rollback the change 15021.

Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15030 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoMdePkg: First instruction after clearing CR0.PE must be a far jmp.
David Woodhouse [Mon, 30 Dec 2013 01:14:13 +0000 (01:14 +0000)]
MdePkg: First instruction after clearing CR0.PE must be a far jmp.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15029 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoClean up hard-coded offsets and other utter bogosity in Thunk16.S
David Woodhouse [Mon, 30 Dec 2013 01:12:10 +0000 (01:12 +0000)]
Clean up hard-coded offsets and other utter bogosity in Thunk16.S

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15028 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoMdeModulePkg Pcd DXE: Handle the case gPcdDataBaseHobGuid HOB is not present.
Star Zeng [Sun, 29 Dec 2013 07:14:57 +0000 (07:14 +0000)]
MdeModulePkg Pcd DXE: Handle the case gPcdDataBaseHobGuid HOB is not present.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed by: Liming Gao <liming.gao@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15027 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate HostSequenceNo for Command packet instead for Response packet.
Jeff Fan [Fri, 27 Dec 2013 08:10:37 +0000 (08:10 +0000)]
Update HostSequenceNo for Command packet instead for Response packet.

Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15026 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoRemove Debug message output from UpdateMailboxContent(), it may cause Mailbox locker...
Jeff Fan [Fri, 27 Dec 2013 06:14:25 +0000 (06:14 +0000)]
Remove Debug message output from UpdateMailboxContent(), it may cause Mailbox locker nested issue.

Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15025 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg: QemuFwCfgLib: drop bogus dependency on UefiBootServicesTableLib
Laszlo Ersek [Thu, 26 Dec 2013 21:05:17 +0000 (21:05 +0000)]
OvmfPkg: QemuFwCfgLib: drop bogus dependency on UefiBootServicesTableLib

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15024 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg: PlatformPei: reuse PublishPeiMemory() in MemDetect()
Laszlo Ersek [Thu, 26 Dec 2013 20:44:29 +0000 (20:44 +0000)]
OvmfPkg: PlatformPei: reuse PublishPeiMemory() in MemDetect()

Although SVN r14944 ("OvmfPkg: introduce PublishPeiMemory") copied a big
chunk of code from MemDetect(), calling the new PublishPeiMemory()
function in MemDetect() could not have replaced the original code in the
latter. However, with the help of the previous patch, we can do it now.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15023 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg: PlatformPei: simplify memory range expressions in MemDetect()
Laszlo Ersek [Thu, 26 Dec 2013 20:44:20 +0000 (20:44 +0000)]
OvmfPkg: PlatformPei: simplify memory range expressions in MemDetect()

Exploit that (MemoryBase + MemorySize) always equals LowerMemorySize.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15022 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoKeep consistent about the return value between the caller and callee.
Eric Dong [Thu, 26 Dec 2013 04:19:37 +0000 (04:19 +0000)]
Keep consistent about the return value between the caller and callee.

Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15021 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate XhcWaitOpRegBit to take Timout argument as microsecond.
Elvin Li [Wed, 25 Dec 2013 07:52:55 +0000 (07:52 +0000)]
Update XhcWaitOpRegBit to take Timout argument as microsecond.

Signed-off-by: Elvin Li <elvin.li@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15020 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoFix ECC errors:1.Update the comments in function headers to follow the Doxygen specia...
Shumin Qiu [Wed, 25 Dec 2013 00:55:33 +0000 (00:55 +0000)]
Fix ECC errors:1.Update the comments in function headers to follow the Doxygen special documentation. 2.Make the first line of text in  a comment block end with a period. 3.Update the member variable name for SHELL_OPERATION_TYPES to follow the rules "Must contain lower case characters". 4. Return type of a function should exist and in the first line.

Signed-off-by: Shumin Qiu <shumin.qiu@intel.com>
Reviewed-by: Dong, Eric <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15019 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoAdd default way for switch in function 'RunCommandOrFile' of 'Shell.c'.
Laszlo Ersek [Tue, 24 Dec 2013 07:25:31 +0000 (07:25 +0000)]
Add default way for switch in function 'RunCommandOrFile' of 'Shell.c'.

Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Shumin Qiu <shumin.qiu@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15018 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoFix a bug for vlan ping failure.
Wu Jiaxin [Mon, 23 Dec 2013 08:43:09 +0000 (08:43 +0000)]
Fix a bug for vlan ping failure.

Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com >
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Jin Eric <eric.jin@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15017 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoMdePkg PcdLib: Follow the comment of LibPcdGetNextToken to ASSERT when an invalid...
Star Zeng [Mon, 23 Dec 2013 06:41:36 +0000 (06:41 +0000)]
MdePkg PcdLib: Follow the comment of LibPcdGetNextToken to ASSERT when an invalid TokenNumber input.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed by: Liming Gao <liming.gao@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15016 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoMdeModulePkg Pcd: Extend PcdVpdBaseAddress to support PcdsPatchableInModule type.
Star Zeng [Mon, 23 Dec 2013 06:33:12 +0000 (06:33 +0000)]
MdeModulePkg Pcd: Extend PcdVpdBaseAddress to support PcdsPatchableInModule type.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed by: Liming Gao <liming.gao@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15015 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoShellPkg: fix DmpStore for deleting
Jaben Carsey [Fri, 20 Dec 2013 22:33:01 +0000 (22:33 +0000)]
ShellPkg: fix DmpStore for deleting

This change allows DmpStore command to delete all variables whereas before it would stop after a single deletion due to looping errors.  It uses a recursive function and deletes the last item returned from GetNextVariableName() first and then goes "backwards" to the first items.

This can't delete authenticated variables.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15014 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOnly save HostSequenceNo for new command in Debug Timer handler.
Jeff Fan [Fri, 20 Dec 2013 05:49:15 +0000 (05:49 +0000)]
Only save HostSequenceNo for new command in Debug Timer handler.

Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15013 6f19259b-4bc3-4df7-8a09-765794883524

8 years ago1. Only dump CPU Context and CpuDeadLoop () for CPU exception.
Jeff Fan [Fri, 20 Dec 2013 05:42:41 +0000 (05:42 +0000)]
1. Only dump CPU Context and CpuDeadLoop () for CPU exception.
2. mEnabledInterruptNum is total enabled interrupt number, InterruptType should less than mEnabledInterruptNum.

Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15012 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoShellPkg: pre-verify split commands
Jaben Carsey [Fri, 20 Dec 2013 01:13:36 +0000 (01:13 +0000)]
ShellPkg: pre-verify split commands

This makes sure that all parts of commands split via pipe operation are valid before starting.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15011 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoShellPkg: API name typo.
Jaben Carsey [Thu, 19 Dec 2013 22:09:17 +0000 (22:09 +0000)]
ShellPkg: API name typo.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15010 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoShellPkg: fix whitespace character trimming
Jaben Carsey [Thu, 19 Dec 2013 22:03:37 +0000 (22:03 +0000)]
ShellPkg: fix whitespace character trimming

This makes TrimSpaces() trim tab characters off the end of the string also (not just the beginning).  Also updates loop to prevent buffer underrun.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15009 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoShellPkg: CTRL-C stops a running script at the same time
Jaben Carsey [Thu, 19 Dec 2013 21:55:13 +0000 (21:55 +0000)]
ShellPkg: CTRL-C stops a running script at the same time

This makes CTRL-C stop a running script after trying to stop the command.  And adds comments to describe the behavior more clearly.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15008 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoShellPkg: Refactor the RunCommand API
Jaben Carsey [Thu, 19 Dec 2013 16:05:34 +0000 (16:05 +0000)]
ShellPkg: Refactor the RunCommand API

This almost completely splits the RunCommand API into sub-routines.

 - the ProcessCommandLineToFinal API handles replacing the a found alias and any found environment variables.  This will redirect "-?" to "help", if necessary.  Upon return, the command line is complete and finalized.  It may still have redirection in it, and those will get chopped off later (but no further modifications occur).
 - the SetupAndRunCommandOrFile API handles updating and then later restoring StdIn, StdOut, and StdErr (and removing their information from the command line).  It will call into RunCommandOrFile.
 - the RunCommandOrFile API divides the logic to RunInternalCommand, RunScriptFile, or running an .EFI file directly.
 - the RunInternalCommand API handles updating and then restoring Argc and Argv.  It will run the internal command in between.
 - the SetLastError API handles updating of the environment variable "lasterror"
 - the DoHelpUpdateArgcArgv was changed to DoHelpUpdate and now works on the raw command line and not the argc/argv.  This allows the processing to be moved earlier.

Note this change has the following positive side effects (this eliminates unnecessary step):
 - Argc/Argv are only updated for internal commands (as they are library based)
 - no Argv/Argc/StdIn/StdOut/StdErr processing is done for file system changes.
 - The ProcessCommandLineToFinal API exists and it's critical to the ability to correctly pre-process split ("|") command lines ahead of time to verify their correctness.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15007 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoConverse the return value from 'int' to 'BOOLEAN' for function ‘ContainsSplit’ in...
Shumin Qiu [Thu, 19 Dec 2013 02:03:42 +0000 (02:03 +0000)]
Converse the return value from 'int' to 'BOOLEAN' for function ‘ContainsSplit’ in Shell.c.

Signed-off-by: Shumin Qiu <shumin.qiu@intel.com>
Reviewed-by: Ni, Ruiyu <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15006 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg: VirtioBlkInit(): log topology attributes
Laszlo Ersek [Wed, 18 Dec 2013 19:57:57 +0000 (19:57 +0000)]
OvmfPkg: VirtioBlkInit(): log topology attributes

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15005 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg: VirtioBlkInit(): expose virtio-blk topology in BlockIo
Laszlo Ersek [Wed, 18 Dec 2013 19:57:46 +0000 (19:57 +0000)]
OvmfPkg: VirtioBlkInit(): expose virtio-blk topology in BlockIo

UEFI spec                                virtio spec
=======================================  =================================
LowestAlignedLba EFI_LBA (UINT64)        alignment_offset u8
+--------------------------------------  +--------------------------------
| first LBA that is aligned to a         | offset of first aligned
| physical block boundary (SCSI          | logical block
| definition)

LogicalBlocksPerPhysicalBlock UINT32     physical_block_exp u8
+--------------------------------------  +--------------------------------
| number of logical blocks per           | # of logical blocks per
| physical block [...] does not contain  | physical block (log2)
| an exponential value

OptimalTransferLengthGranularity UINT32  opt_io_size le32
+--------------------------------------  +--------------------------------
| optimal transfer length granularity    | optimal (suggested maximum) I/O
| as a number of logical blocks [...] A  | size in blocks
| value of 0 means there is no reported
| optimal transfer length granularity

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15004 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg/VirtioBlkDxe/VirtioBlk.c: rewrap overlong lines
Laszlo Ersek [Wed, 18 Dec 2013 19:57:36 +0000 (19:57 +0000)]
OvmfPkg/VirtioBlkDxe/VirtioBlk.c: rewrap overlong lines

Lines should be no longer than 79 characters.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15003 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg: IndustryStandard/VirtioBlk: introduce topology-related definitions
Laszlo Ersek [Wed, 18 Dec 2013 19:57:28 +0000 (19:57 +0000)]
OvmfPkg: IndustryStandard/VirtioBlk: introduce topology-related definitions

Based on
<https://tools.oasis-open.org/version-control/browse/wsvn/virtio/virtio-v1.0-wd01-part1-specification.txt?rev=159>,
which is the last text format revision.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15002 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoOvmfPkg: IndustryStandard/VirtioBlk: add extra horizontal whitespace
Laszlo Ersek [Wed, 18 Dec 2013 19:57:18 +0000 (19:57 +0000)]
OvmfPkg: IndustryStandard/VirtioBlk: add extra horizontal whitespace

We're going to introduce a new macro and a new VIRTIO_BLK_CONFIG member
that need realignment of existing definitions and comments. Separate out
the whitespace changes in this patch.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15001 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoRollback the change to EFI_BOOT_KEY_DATA structure since UEFI Spec adds the clarifica...
Ruiyu Ni [Wed, 18 Dec 2013 05:51:22 +0000 (05:51 +0000)]
Rollback the change to EFI_BOOT_KEY_DATA structure since UEFI Spec adds the clarification that bitfields are ordered such that bit 0 is the least significant bit.

Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15000 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoUpdate code to avoid using potential NULL pointer.
Eric Dong [Wed, 18 Dec 2013 03:02:52 +0000 (03:02 +0000)]
Update code to avoid using potential NULL pointer.

Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14999 6f19259b-4bc3-4df7-8a09-765794883524

8 years agoShellPkg: Add missing function header comments
Jaben Carsey [Tue, 17 Dec 2013 22:23:05 +0000 (22:23 +0000)]
ShellPkg: Add missing function header comments

I found that some function headers had insufficient/incorrect information.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14998 6f19259b-4bc3-4df7-8a09-765794883524